Merge pull request nextcloud#57495 from nextcloud/fix/noid/no-data-response

ArtificialOwl · web-flow · commit 048037b62966 · 2026-01-13T11:21:03.000-01:00
fix(ocm): empty response
diff --git a/apps/cloud_federation_api/lib/Controller/OCMRequestController.php b/apps/cloud_federation_api/lib/Controller/OCMRequestController.php
@@ -15,7 +15,6 @@
 use OCP\AppFramework\Http\Attribute\BruteForceProtection;
 use OCP\AppFramework\Http\Attribute\NoCSRFRequired;
 use OCP\AppFramework\Http\Attribute\PublicPage;
-use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\Http\JSONResponse;
 use OCP\AppFramework\Http\Response;
 use OCP\EventDispatcher\IEventDispatcher;
@@ -83,6 +82,6 @@ public function manageOCMRequests(string $ocmPath): Response {
 		);
 		$this->eventDispatcher->dispatchTyped($event);
 
-		return $event->getResponse() ?? new DataResponse('', Http::STATUS_NOT_FOUND);
+		return $event->getResponse() ?? new Response(Http::STATUS_NOT_FOUND);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`	`use OCP\AppFramework\Http\Attribute\BruteForceProtection;`
`16`	`16`	`use OCP\AppFramework\Http\Attribute\NoCSRFRequired;`
`17`	`17`	`use OCP\AppFramework\Http\Attribute\PublicPage;`
`18`		`-use OCP\AppFramework\Http\DataResponse;`
`19`	`18`	`use OCP\AppFramework\Http\JSONResponse;`
`20`	`19`	`use OCP\AppFramework\Http\Response;`
`21`	`20`	`use OCP\EventDispatcher\IEventDispatcher;`
`@@ -83,6 +82,6 @@ public function manageOCMRequests(string $ocmPath): Response {`
`83`	`82`	`);`
`84`	`83`	`$this->eventDispatcher->dispatchTyped($event);`
`85`	`84`
`86`		`- return $event->getResponse() ?? new DataResponse('', Http::STATUS_NOT_FOUND);`
	`85`	`+ return $event->getResponse() ?? new Response(Http::STATUS_NOT_FOUND);`
`87`	`86`	`}`
`88`	`87`	`}`