feat(telegram): Introduce public and full bot command registration

Refactor Telegram command registration to separate public commands visible to all users from full commands for approved users. Implement a new function to register full commands per chat, ensuring that only approved users see the complete command set. Enhance error handling and logging for command registration processes.

Author: MarvelNwachukwu

src/services/TelegramService.ts

@@ -78,19 +78,38 @@ function getTextFromRequest(request: LlmRequest): string {
 }
 
 /**
- * Bot commands to register with Telegram
+ * Public bot commands visible to all users (including unapproved)
  */
-const BOT_COMMANDS = [
+const PUBLIC_BOT_COMMANDS = [
+	{ command: "start", description: "Start the bot and pair" },
+	{ command: "help", description: "Show available commands" },
+];
+
+/**
+ * Full bot commands visible only to approved/paired users
+ */
+const FULL_BOT_COMMANDS = [
 	{ command: "start", description: "Start the bot and pair" },
 	{ command: "new", description: "Save session and start fresh" },
 	{ command: "reset", description: "Clear session without saving" },
 	{ command: "help", description: "Show available commands" },
 ];
 
 /**
- * Register bot commands with Telegram API
+ * Track chatIds that have had full commands registered
+ * so we only register once per session per chat
  */
-async function registerBotCommands(botToken: string): Promise<void> {
+const registeredChats = new Set<string>();
+
+/**
+ * Register bot commands with Telegram API at global scopes.
+ * Called at startup with public commands so all users (including unapproved)
+ * can see /start and /help in the command menu.
+ */
+async function registerBotCommands(
+	botToken: string,
+	commandList: typeof PUBLIC_BOT_COMMANDS = PUBLIC_BOT_COMMANDS,
+): Promise<void> {
 	const api = `https://api.telegram.org/bot${botToken}`;
 	const headers = { "Content-Type": "application/json" };
 	const scopes = [
@@ -113,7 +132,7 @@ async function registerBotCommands(botToken: string): Promise<void> {
 			const response = await fetch(`${api}/setMyCommands`, {
 				method: "POST",
 				headers,
-				body: JSON.stringify({ commands: BOT_COMMANDS, scope }),
+				body: JSON.stringify({ commands: commandList, scope }),
 			});
 			const result = (await response.json()) as {
 				ok: boolean;
@@ -126,13 +145,57 @@ async function registerBotCommands(botToken: string): Promise<void> {
 			}
 		}
 		log.info(
-			`Registered ${BOT_COMMANDS.length} bot commands: ${BOT_COMMANDS.map((c) => `/${c.command}`).join(", ")}`,
+			`Registered ${commandList.length} bot commands: ${commandList.map((c) => `/${c.command}`).join(", ")}`,
 		);
 	} catch (error) {
 		log.warn(`Could not register bot commands: ${error}`);
 	}
 }
 
+/**
+ * Register full bot commands for a specific chat (approved user).
+ * Uses Telegram's per-chat scope so the user sees all commands
+ * including /new and /reset in their command menu.
+ */
+async function registerUserCommands(
+	botToken: string,
+	chatId: string,
+): Promise<void> {
+	const api = `https://api.telegram.org/bot${botToken}`;
+	const headers = { "Content-Type": "application/json" };
+	const scope = { type: "chat", chat_id: Number(chatId) };
+
+	try {
+		// Clear existing per-chat commands first
+		await fetch(`${api}/deleteMyCommands`, {
+			method: "POST",
+			headers,
+			body: JSON.stringify({ scope }),
+		});
+
+		// Set full command list for this specific chat
+		const response = await fetch(`${api}/setMyCommands`, {
+			method: "POST",
+			headers,
+			body: JSON.stringify({ commands: FULL_BOT_COMMANDS, scope }),
+		});
+		const result = (await response.json()) as {
+			ok: boolean;
+			description?: string;
+		};
+		if (!result.ok) {
+			log.warn(
+				`Failed to register user commands for chat ${chatId}: ${result.description}`,
+			);
+		} else {
+			registeredChats.add(chatId);
+			log.info(`Registered full commands for chat ${chatId}`);
+		}
+	} catch (error) {
+		log.warn(`Could not register user commands for chat ${chatId}: ${error}`);
+	}
+}
+
 /**
  * Command handlers
  */
@@ -259,17 +322,29 @@ export async function startTelegramBot(): Promise<void> {
 				return getPairingResponse(userId, undefined, chatId);
 			}
 
+			// Register full commands for newly approved users on first message
+			if (!registeredChats.has(chatId)) {
+				registerUserCommands(config.telegramBotToken, chatId);
+			}
+
 			// Track in session
 			sessionManager.getOrCreate(chatId, userId);
 			sessionManager.addMessage(chatId, "user", messageText);
 
 			// Get response from agent
-			const response = await runner.ask(messageText);
+			try {
+				const response = await runner.ask(messageText);
 
-			// Track response
-			sessionManager.addMessage(chatId, "assistant", response);
+				// Track response
+				sessionManager.addMessage(chatId, "assistant", response);
 
-			return response;
+				return response;
+			} catch (error) {
+				log.error(
+					`Failed to get response for chatId=${chatId}: ${error instanceof Error ? error.message : error}`,
+				);
+				return "⚠️ Sorry, I'm having trouble right now. Please try again in a moment.";
+			}
 		},
 	);