Refactor: CollectionsRepository

Author: GPortas

src/collections/infra/repositories/CollectionsRepository.ts

@@ -67,42 +67,13 @@ export class CollectionsRepository extends ApiRepository implements ICollections
     collectionDTO: CollectionDTO,
     parentCollectionId: number | string = ROOT_COLLECTION_ALIAS
   ): Promise<number> {
-    const dataverseContacts: NewCollectionContactRequestPayload[] = collectionDTO.contacts.map(
-      (contact) => ({
-        contactEmail: contact
-      })
-    )
-
-    const inputLevelsRequestBody: NewCollectionInputLevelRequestPayload[] =
-      collectionDTO.inputLevels?.map((inputLevel) => ({
-        datasetFieldTypeName: inputLevel.datasetFieldName,
-        include: inputLevel.include,
-        required: inputLevel.required
-      }))
-
-    const requestBody: NewCollectionRequestPayload = {
-      alias: collectionDTO.alias,
-      name: collectionDTO.name,
-      dataverseContacts: dataverseContacts,
-      dataverseType: collectionDTO.type,
-      ...(collectionDTO.description && {
-        description: collectionDTO.description
-      }),
-      ...(collectionDTO.affiliation && {
-        affiliation: collectionDTO.affiliation
-      }),
-      metadataBlocks: {
-        metadataBlockNames: collectionDTO.metadataBlockNames,
-        facetIds: collectionDTO.facetIds,
-        inputLevels: inputLevelsRequestBody
-      }
-    }
+    const requestBody = this.createCreateOrUpdateRequestBody(collectionDTO);
 
     return this.doPost(`/${this.collectionsResourceName}/${parentCollectionId}`, requestBody)
       .then((response) => response.data.data.id)
       .catch((error) => {
-        throw error
-      })
+        throw error;
+      });
   }
 
   public async getCollectionFacets(
@@ -189,42 +160,40 @@ export class CollectionsRepository extends ApiRepository implements ICollections
     collectionIdOrAlias: string | number,
     updatedCollection: CollectionDTO
   ): Promise<void> {
-    const dataverseContacts: NewCollectionContactRequestPayload[] = updatedCollection.contacts.map(
-      (contact) => ({
-        contactEmail: contact
-      })
-    )
+    const requestBody = this.createCreateOrUpdateRequestBody(updatedCollection);
+
+    return this.doPut(`/${this.collectionsResourceName}/${collectionIdOrAlias}`, requestBody)
+      .then(() => undefined)
+      .catch((error) => {
+        throw error;
+      });
+  }
+
+  private createCreateOrUpdateRequestBody(collectionDTO: CollectionDTO): NewCollectionRequestPayload {
+    const dataverseContacts: NewCollectionContactRequestPayload[] = collectionDTO.contacts.map((contact) => ({
+      contactEmail: contact
+    }));
 
     const inputLevelsRequestBody: NewCollectionInputLevelRequestPayload[] =
-      updatedCollection.inputLevels?.map((inputLevel) => ({
+      collectionDTO.inputLevels?.map((inputLevel) => ({
         datasetFieldTypeName: inputLevel.datasetFieldName,
         include: inputLevel.include,
         required: inputLevel.required
-      }))
+      }));
 
-    const requestBody: NewCollectionRequestPayload = {
-      alias: updatedCollection.alias,
-      name: updatedCollection.name,
+    return {
+      alias: collectionDTO.alias,
+      name: collectionDTO.name,
       dataverseContacts: dataverseContacts,
-      dataverseType: updatedCollection.type,
-      ...(updatedCollection.description && {
-        description: updatedCollection.description
-      }),
-      ...(updatedCollection.affiliation && {
-        affiliation: updatedCollection.affiliation
-      }),
+      dataverseType: collectionDTO.type,
+      ...(collectionDTO.description && { description: collectionDTO.description }),
+      ...(collectionDTO.affiliation && { affiliation: collectionDTO.affiliation }),
       metadataBlocks: {
-        metadataBlockNames: updatedCollection.metadataBlockNames,
-        facetIds: updatedCollection.facetIds,
+        metadataBlockNames: collectionDTO.metadataBlockNames,
+        facetIds: collectionDTO.facetIds,
         inputLevels: inputLevelsRequestBody
       }
-    }
-
-    return this.doPut(`/${this.collectionsResourceName}/${collectionIdOrAlias}`, requestBody)
-      .then(() => undefined)
-      .catch((error) => {
-        throw error
-      })
+    };
   }
 
   private applyCollectionSearchCriteriaToQueryParams(