keep showTypeCounts as last arg

Author: g-saracca

src/collections/domain/repositories/ICollectionsRepository.ts

@@ -27,8 +27,8 @@ export interface ICollectionsRepository {
     limit?: number,
     offset?: number,
     collectionSearchCriteria?: CollectionSearchCriteria,
-    showTypeCounts?: boolean,
-    searchServiceName?: string
+    searchServiceName?: string,
+    showTypeCounts?: boolean
   ): Promise<CollectionItemSubset>
   getMyDataCollectionItems(
     roleIds: number[],

src/collections/domain/useCases/GetCollectionItems.ts

@@ -26,16 +26,16 @@ export class GetCollectionItems implements UseCase<CollectionItemSubset> {
     limit?: number,
     offset?: number,
     collectionSearchCriteria?: CollectionSearchCriteria,
-    showTypeCounts = false,
-    searchServiceName?: string
+    searchServiceName?: string,
+    showTypeCounts = false
   ): Promise<CollectionItemSubset> {
     return await this.collectionsRepository.getCollectionItems(
       collectionId,
       limit,
       offset,
       collectionSearchCriteria,
-      showTypeCounts,
-      searchServiceName
+      searchServiceName,
+      showTypeCounts
     )
   }
 }

src/collections/infra/repositories/CollectionsRepository.ts

@@ -158,8 +158,8 @@ export class CollectionsRepository extends ApiRepository implements ICollections
     limit?: number,
     offset?: number,
     collectionSearchCriteria?: CollectionSearchCriteria,
-    showTypeCounts?: boolean,
-    searchServiceName?: string
+    searchServiceName?: string,
+    showTypeCounts?: boolean
   ): Promise<CollectionItemSubset> {
     const queryParams = new URLSearchParams({
       [GetCollectionItemsQueryParams.QUERY]: '*',

test/integration/collections/CollectionsRepository.test.ts

@@ -771,6 +771,7 @@ describe('CollectionsRepository', () => {
         undefined,
         undefined,
         undefined,
+        undefined,
         true
       )
       expect(actual.countPerObjectType?.collections).toBe(1)

test/unit/collections/GetCollectionItems.test.ts

@@ -55,8 +55,8 @@ describe('execute', () => {
       undefined,
       undefined,
       undefined,
-      false,
-      undefined
+      undefined,
+      false
     )
     expect(actual).toEqual(testItemSubset)
   })
@@ -72,8 +72,8 @@ describe('execute', () => {
       limit,
       undefined,
       undefined,
-      false,
-      undefined
+      undefined,
+      false
     )
     expect(actual).toEqual(testItemSubset)
   })
@@ -89,8 +89,8 @@ describe('execute', () => {
       undefined,
       offset,
       undefined,
-      false,
-      undefined
+      undefined,
+      false
     )
     expect(actual).toEqual(testItemSubset)
   })
@@ -106,16 +106,16 @@ describe('execute', () => {
       undefined,
       undefined,
       searchCriteria,
-      false
+      undefined
     )
 
     expect(collectionRepositoryStub.getCollectionItems).toHaveBeenCalledWith(
       undefined,
       undefined,
       undefined,
       searchCriteria,
-      false,
-      undefined
+      undefined,
+      false
     )
     expect(actual).toEqual(testItemSubset)
   })
@@ -140,6 +140,7 @@ describe('execute', () => {
       undefined,
       undefined,
       undefined,
+      undefined,
       showTypeCounts
     )
 
@@ -148,8 +149,8 @@ describe('execute', () => {
       undefined,
       undefined,
       undefined,
-      showTypeCounts,
-      undefined
+      undefined,
+      showTypeCounts
     )
     expect(actual).toEqual(testItemSubsetWithCount)
   })
@@ -169,17 +170,17 @@ describe('execute', () => {
       limit,
       offset,
       searchCriteria,
-      false,
-      undefined
+      undefined,
+      false
     )
 
     expect(collectionRepositoryStub.getCollectionItems).toHaveBeenCalledWith(
       collectionId,
       limit,
       offset,
       searchCriteria,
-      false,
-      undefined
+      undefined,
+      false
     )
     expect(actual).toEqual(testItemSubset)
   })