Skip to content

Commit 1f3edf1

Browse files
committed
Changed: rename RecreateCurrentApiToken
1 parent 8bb6d32 commit 1f3edf1

File tree

8 files changed

+25
-22
lines changed

8 files changed

+25
-22
lines changed

src/users/domain/repositories/IUsersRepository.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { AuthenticatedUser } from '../models/AuthenticatedUser'
33

44
export interface IUsersRepository {
55
getCurrentAuthenticatedUser(): Promise<AuthenticatedUser>
6-
recreateApiToken(): Promise<ApiTokenInfo>
6+
recreateCurrentApiToken(): Promise<ApiTokenInfo>
77
getCurrentApiToken(): Promise<ApiTokenInfo>
88
deleteCurrentApiToken(): Promise<void>
99
}

src/users/domain/useCases/RecreateApiToken.ts renamed to src/users/domain/useCases/RecreateCurrentApiToken.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { UseCase } from '../../../core/domain/useCases/UseCase'
22
import { ApiTokenInfo } from '../models/ApiTokenInfo'
33
import { IUsersRepository } from '../repositories/IUsersRepository'
44

5-
export class RecreateApiToken implements UseCase<ApiTokenInfo> {
5+
export class RecreateCurrentApiToken implements UseCase<ApiTokenInfo> {
66
private usersRepository: IUsersRepository
77

88
constructor(usersRepository: IUsersRepository) {
@@ -15,6 +15,6 @@ export class RecreateApiToken implements UseCase<ApiTokenInfo> {
1515
* @returns {Promise<ApiTokenInfo>}
1616
*/
1717
async execute(): Promise<ApiTokenInfo> {
18-
return await this.usersRepository.recreateApiToken()
18+
return await this.usersRepository.recreateCurrentApiToken()
1919
}
2020
}

src/users/index.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,21 @@
11
import { UsersRepository } from './infra/repositories/UsersRepository'
22
import { GetCurrentAuthenticatedUser } from './domain/useCases/GetCurrentAuthenticatedUser'
3-
import { RecreateApiToken } from './domain/useCases/RecreateApiToken'
3+
import { RecreateCurrentApiToken } from './domain/useCases/RecreateCurrentApiToken'
44
import { GetCurrentApiToken } from './domain/useCases/GetCurrentApiToken'
55
import { DeleteCurrentApiToken } from './domain/useCases/DeleteCurrentApiToken'
66

77
const usersRepository = new UsersRepository()
88

99
const getCurrentAuthenticatedUser = new GetCurrentAuthenticatedUser(usersRepository)
10-
const recreateApiToken = new RecreateApiToken(usersRepository)
10+
const recreateCurrentApiToken = new RecreateCurrentApiToken(usersRepository)
1111
const getCurrentApiToken = new GetCurrentApiToken(usersRepository)
1212
const deleteCurrentApiToken = new DeleteCurrentApiToken(usersRepository)
1313

14-
export { getCurrentAuthenticatedUser, recreateApiToken, getCurrentApiToken, deleteCurrentApiToken }
14+
export {
15+
getCurrentAuthenticatedUser,
16+
recreateCurrentApiToken,
17+
getCurrentApiToken,
18+
deleteCurrentApiToken
19+
}
1520
export { AuthenticatedUser } from './domain/models/AuthenticatedUser'
1621
export { ApiTokenInfo } from './domain/models/ApiTokenInfo'

src/users/infra/repositories/UsersRepository.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export class UsersRepository extends ApiRepository implements IUsersRepository {
1919
})
2020
}
2121

22-
public async recreateApiToken(): Promise<ApiTokenInfo> {
22+
public async recreateCurrentApiToken(): Promise<ApiTokenInfo> {
2323
return this.doPost(`/${this.usersResourceName}/token/recreate?returnExpiration=true`, {})
2424
.then((response) => transformRecreateApiTokenResponseToApiTokenInfo(response))
2525
.catch((error) => {

test/functional/users/DeleteCurrentApiToken.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ describe('execute', () => {
2525
ApiConfig.init(TestConstants.TEST_API_URL, DataverseApiAuthMechanism.API_KEY, testApiToken)
2626
await deleteCurrentApiToken.execute()
2727
// Since the token has been deleted, the next call using it should return a WriteError
28-
await expect(
29-
deleteCurrentApiToken.execute()
30-
).rejects.toBeInstanceOf(WriteError)
28+
await expect(deleteCurrentApiToken.execute()).rejects.toBeInstanceOf(WriteError)
3129
})
3230
})

test/functional/users/RecreateApiToken.test.ts renamed to test/functional/users/RecreateCurrentApiToken.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ApiConfig, recreateApiToken } from '../../../src'
1+
import { ApiConfig, recreateCurrentApiToken } from '../../../src'
22
import { DataverseApiAuthMechanism } from '../../../src/core/infra/repositories/ApiConfig'
33
import { TestConstants } from '../../testHelpers/TestConstants'
44
import { createApiTokenViaApi } from '../../testHelpers/users/apiTokenHelper'
@@ -21,9 +21,9 @@ describe('execute', () => {
2121
})
2222

2323
test('should successfully recreate the API token', async () => {
24-
const testApiToken = await createApiTokenViaApi('recreateApiTokenFTUser')
24+
const testApiToken = await createApiTokenViaApi('recreateCurrentApiTokenFTUser')
2525
ApiConfig.init(TestConstants.TEST_API_URL, DataverseApiAuthMechanism.API_KEY, testApiToken)
26-
const actualRecreatedApiTokenInfo = await recreateApiToken.execute()
26+
const actualRecreatedApiTokenInfo = await recreateCurrentApiToken.execute()
2727
expect(actualRecreatedApiTokenInfo.apiToken).not.toBeUndefined()
2828
expect(actualRecreatedApiTokenInfo.apiToken).not.toBe(testApiToken)
2929
expect(typeof actualRecreatedApiTokenInfo.expirationDate).toBe('object')

test/integration/users/UsersRepository.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ describe('UsersRepository', () => {
3737
})
3838
})
3939

40-
describe('recreateApiToken', () => {
40+
describe('recreateCurrentApiToken', () => {
4141
test('should recreate API token and return the new API token info when valid authentication is provided', async () => {
42-
const testApiToken = await createApiTokenViaApi('recreateApiTokenITUser')
42+
const testApiToken = await createApiTokenViaApi('recreateCurrentApiTokenITUser')
4343
ApiConfig.init(TestConstants.TEST_API_URL, DataverseApiAuthMechanism.API_KEY, testApiToken)
44-
const actualRecreatedApiTokenInfo = await sut.recreateApiToken()
44+
const actualRecreatedApiTokenInfo = await sut.recreateCurrentApiToken()
4545
expect(actualRecreatedApiTokenInfo.apiToken).not.toBeUndefined()
4646
expect(actualRecreatedApiTokenInfo.apiToken).not.toBe(testApiToken)
4747
expect(typeof actualRecreatedApiTokenInfo.expirationDate).toBe('object')
@@ -51,7 +51,7 @@ describe('UsersRepository', () => {
5151
ApiConfig.init(TestConstants.TEST_API_URL, DataverseApiAuthMechanism.API_KEY, 'invalidApiKey')
5252

5353
const errorExpected: WriteError = new WriteError('[401] Bad API key')
54-
await expect(sut.recreateApiToken()).rejects.toThrow(errorExpected)
54+
await expect(sut.recreateCurrentApiToken()).rejects.toThrow(errorExpected)
5555
})
5656
})
5757

test/unit/users/RecreateApiToken.test.ts renamed to test/unit/users/RecreateCurrentApiToken.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { IUsersRepository } from '../../../src/users/domain/repositories/IUsersRepository'
2-
import { RecreateApiToken } from '../../../src/users/domain/useCases/RecreateApiToken'
2+
import { RecreateCurrentApiToken } from '../../../src/users/domain/useCases/RecreateCurrentApiToken'
33
import { WriteError } from '../../../src'
44
import { ApiTokenInfo } from '../../../src/users/domain/models/ApiTokenInfo'
55
import { TestConstants } from '../../testHelpers/TestConstants'
@@ -11,8 +11,8 @@ describe('execute', () => {
1111
expirationDate: new Date()
1212
}
1313
const usersRepositoryStub: IUsersRepository = {} as IUsersRepository
14-
usersRepositoryStub.recreateApiToken = jest.fn().mockResolvedValue(testNewTokenInfo)
15-
const sut = new RecreateApiToken(usersRepositoryStub)
14+
usersRepositoryStub.recreateCurrentApiToken = jest.fn().mockResolvedValue(testNewTokenInfo)
15+
const sut = new RecreateCurrentApiToken(usersRepositoryStub)
1616

1717
const actual = await sut.execute()
1818

@@ -21,8 +21,8 @@ describe('execute', () => {
2121

2222
test('should return error result on repository error', async () => {
2323
const usersRepositoryStub: IUsersRepository = {} as IUsersRepository
24-
usersRepositoryStub.recreateApiToken = jest.fn().mockRejectedValue(new WriteError())
25-
const sut = new RecreateApiToken(usersRepositoryStub)
24+
usersRepositoryStub.recreateCurrentApiToken = jest.fn().mockRejectedValue(new WriteError())
25+
const sut = new RecreateCurrentApiToken(usersRepositoryStub)
2626

2727
await expect(sut.execute()).rejects.toThrow(WriteError)
2828
})

0 commit comments

Comments
 (0)