Skip to content

Commit 20337f5

Browse files
committed
feat: some updates happened to metadatablock leading to wrong test results
1 parent 4346be6 commit 20337f5

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

test/functional/metadataBlocks/GetAllFacetableMetadataFields.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ describe('execute', () => {
1212
})
1313

1414
test('should return all facetable metadata fields', async () => {
15-
let metadataFieldInfos: MetadataFieldInfo[] = null
15+
let metadataFieldInfos: MetadataFieldInfo[] | null = null
1616
try {
1717
metadataFieldInfos = await getAllFacetableMetadataFields.execute()
1818
} catch (error) {
1919
throw new Error('Should not raise an error')
2020
} finally {
21-
expect(metadataFieldInfos.length).toBe(59)
22-
expect(metadataFieldInfos[0].name).toBe('authorName')
23-
expect(metadataFieldInfos[0].displayName).toBe('Author Name')
21+
expect(metadataFieldInfos?.length).toBe(64)
22+
expect(metadataFieldInfos?.[0].name).toBe('authorName')
23+
expect(metadataFieldInfos?.[0].displayName).toBe('Author Name')
2424
}
2525
})
2626
})

test/functional/metadataBlocks/GetAllMetadataBlocks.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ describe('execute', () => {
1212
})
1313

1414
test('should successfully return metadatablocks', async () => {
15-
let metadataBlocks: MetadataBlock[] = null
15+
let metadataBlocks: MetadataBlock[] | null = null
1616
try {
1717
metadataBlocks = await getAllMetadataBlocks.execute()
1818
} catch (error) {
1919
throw new Error('Should not raise an error')
2020
} finally {
2121
expect(metadataBlocks).not.toBeNull()
22-
expect(metadataBlocks.length).toBe(6)
23-
expect(metadataBlocks[0].metadataFields.title.name).toBe('title')
22+
expect(metadataBlocks?.length).toBe(7)
23+
expect(metadataBlocks?.[0].metadataFields.title.name).toBe('title')
2424
}
2525
})
2626
})

test/integration/metadataBlocks/MetadataBlocksRepository.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ describe('MetadataBlocksRepository', () => {
5959
describe('getAllMetadataBlocks', () => {
6060
test('should return all metadata blocks', async () => {
6161
const actual = await sut.getAllMetadataBlocks()
62-
expect(actual.length).toBe(6)
62+
expect(actual.length).toBe(7)
6363
expect(actual[0].name).toBe(citationMetadataBlockName)
6464
expect(actual[0].metadataFields.title.name).toBe('title')
6565
})

test/integration/metadataBlocks/MetadataFieldsInfoRepository.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ describe('getAllFacetableMetadataFields', () => {
1919
test('should return all facetable metadata fields', async () => {
2020
const actual = await sut.getAllFacetableMetadataFields()
2121

22-
expect(actual.length).toBe(59)
22+
expect(actual.length).toBe(64)
2323
expect(actual[0].name).toBe('authorName')
2424
expect(actual[0].displayName).toBe('Author Name')
2525
})

0 commit comments

Comments
 (0)