fix CollectionsRepository.test.ts: use persistentId to test the correct notification.

Author: ekraffmiller

test/integration/collections/CollectionsRepository.test.ts

@@ -380,9 +380,14 @@ describe('CollectionsRepository', () => {
 
     const testTextFile1Name = 'test-file-1.txt'
     const testSubCollectionAlias = 'collectionsRepositoryTestSubCollection'
-
+    const testCollectionItemsAlias = 'collectionsRepositoryTestCollectionItems'
     beforeAll(async () => {
-      await createCollectionViaApi(testSubCollectionAlias, testCollectionAlias).catch(() => {
+      await createCollectionViaApi(testCollectionItemsAlias, ROOT_COLLECTION_ALIAS).catch(() => {
+        throw new Error(
+          `Tests beforeAll(): Error while creating collection ${testCollectionItemsAlias}`
+        )
+      })
+      await createCollectionViaApi(testSubCollectionAlias, testCollectionItemsAlias).catch(() => {
         throw new Error(
           `Tests beforeAll(): Error while creating subcollection ${testSubCollectionAlias}`
         )
@@ -421,7 +426,7 @@ describe('CollectionsRepository', () => {
       // Give enough time to Solr for indexing
       await new Promise((resolve) => setTimeout(resolve, 5000))
 
-      let actual = await sut.getCollectionItems(testCollectionAlias)
+      let actual = await sut.getCollectionItems(testCollectionItemsAlias)
       const actualFilePreview = actual.items[1] as FilePreview
       const actualDatasetPreview = actual.items[0] as DatasetPreview
       const actualCollectionPreview = actual.items[2] as CollectionPreview
@@ -539,12 +544,12 @@ describe('CollectionsRepository', () => {
       expect(actualCollectionPreview.alias).toBe(testSubCollectionAlias)
       expect(actualCollectionPreview.description).toBe('We do all the science.')
       expect(actualCollectionPreview.imageUrl).toBe(undefined)
-      expect(actualCollectionPreview.parentAlias).toBe(testCollectionAlias)
+      expect(actualCollectionPreview.parentAlias).toBe(testCollectionItemsAlias)
       expect(actualCollectionPreview.parentName).toBe(expectedCollectionsName)
       expect(actualCollectionPreview.publicationStatuses).toContain(PublicationStatus.Unpublished)
       expect(actualCollectionPreview.releaseOrCreateDate).not.toBeUndefined()
       expect(actualCollectionPreview.affiliation).toBe('Scientific Research University')
-      expect(actualCollectionPreview.parentAlias).toBe('collectionsRepositoryTestCollection')
+      expect(actualCollectionPreview.parentAlias).toBe('collectionsRepositoryTestCollectionItems')
       expect(actualCollectionPreview.parentName).toBe(expectedCollectionsName)
       expect(actualCollectionPreview.type).toBe(CollectionItemType.COLLECTION)
 
@@ -553,7 +558,7 @@ describe('CollectionsRepository', () => {
       expect(actual.facets).toEqual(expectedFacetsAll)
 
       // Test limit and offset
-      actual = await sut.getCollectionItems(testCollectionAlias, 1, 1)
+      actual = await sut.getCollectionItems(testCollectionItemsAlias, 1, 1)
       expect((actual.items[0] as FilePreview).name).toBe(expectedFileName)
       expect(actual.items.length).toBe(1)
       expect(actual.totalItemCount).toBe(3)
@@ -563,7 +568,7 @@ describe('CollectionsRepository', () => {
         'test-fi'
       )
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaForFile
@@ -575,7 +580,7 @@ describe('CollectionsRepository', () => {
         'Dataset created using'
       )
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaForDataset
@@ -587,7 +592,7 @@ describe('CollectionsRepository', () => {
       const collectionSearchCriteriaForDatasetAndCollection =
         new CollectionSearchCriteria().withSearchText('the')
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaForDatasetAndCollection
@@ -598,7 +603,7 @@ describe('CollectionsRepository', () => {
 
       // Test search text, limit and offset
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         1,
         1,
         collectionSearchCriteriaForDatasetAndCollection
@@ -611,7 +616,7 @@ describe('CollectionsRepository', () => {
       const collectionSearchCriteriaForCollectionType =
         new CollectionSearchCriteria().withItemTypes([CollectionItemType.COLLECTION])
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaForCollectionType
@@ -626,7 +631,7 @@ describe('CollectionsRepository', () => {
         CollectionItemType.DATASET
       ])
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaForDatasetType
@@ -641,7 +646,7 @@ describe('CollectionsRepository', () => {
         CollectionItemType.FILE
       ])
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaForFileType
@@ -657,7 +662,7 @@ describe('CollectionsRepository', () => {
         CollectionItemType.COLLECTION
       ])
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaForMultiTypes
@@ -674,7 +679,7 @@ describe('CollectionsRepository', () => {
         .withOrder(OrderType.ASC)
 
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaNameAscending
@@ -691,7 +696,7 @@ describe('CollectionsRepository', () => {
         .withOrder(OrderType.DESC)
 
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaNameDescending
@@ -708,7 +713,7 @@ describe('CollectionsRepository', () => {
         .withOrder(OrderType.ASC)
 
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaDateAscending
@@ -725,7 +730,7 @@ describe('CollectionsRepository', () => {
         .withOrder(OrderType.DESC)
 
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaDateDescending
@@ -741,7 +746,7 @@ describe('CollectionsRepository', () => {
         new CollectionSearchCriteria().withFilterQueries(['dvCategory:Laboratory'])
 
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaFilterQueryCollection
@@ -758,7 +763,7 @@ describe('CollectionsRepository', () => {
         ])
 
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaFilterQueryDataset
@@ -773,7 +778,7 @@ describe('CollectionsRepository', () => {
         new CollectionSearchCriteria().withFilterQueries(['fileAccess:Public'])
 
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         collectionSearchCriteriaFilterQuerieCollAndFile
@@ -786,7 +791,7 @@ describe('CollectionsRepository', () => {
 
       // Test with showTypeCounts param in true
       actual = await sut.getCollectionItems(
-        testCollectionAlias,
+        testCollectionItemsAlias,
         undefined,
         undefined,
         undefined,