test: update due to ts errors and image url

Author: g-saracca

test/functional/collections/DeleteCollectionFeaturedItems.test.ts

@@ -71,7 +71,7 @@ describe('execute', () => {
     try {
       await deleteCollectionFeaturedItems.execute(invalidCollectionAlias)
     } catch (error) {
-      writeError = error
+      writeError = error as WriteError
     } finally {
       expect(writeError).toBeInstanceOf(WriteError)
       expect((writeError as WriteError).message).toEqual(

test/functional/collections/GetCollectionFeaturedItems.test.ts

@@ -59,7 +59,7 @@ describe('execute', () => {
     expect(featuredItemsResponse[0].displayOrder).toBe(1)
     expect(featuredItemsResponse[0].content).toBe('<p class="rte-paragraph">Test content</p>')
     expect(featuredItemsResponse[0].imageFileUrl).toBe(
-      `http://localhost:8080/api/access/dataverseFeatureItemImage/${featuredItemsResponse[0].id}`
+      `http://localhost:8080/api/access/dataverseFeaturedItemImage/${featuredItemsResponse[0].id}`
     )
     expect(featuredItemsResponse[0].imageFileName).toBe('featured-item-test-image.png')
   })
@@ -95,7 +95,7 @@ describe('execute', () => {
     try {
       await getCollectionFeaturedItems.execute(invalidCollectionAlias)
     } catch (error) {
-      readError = error
+      readError = error as ReadError
     } finally {
       expect(readError).toBeInstanceOf(ReadError)
       expect((readError as ReadError).message).toEqual(

test/functional/collections/UpdateCollectionFeaturedItems.test.ts

@@ -92,7 +92,7 @@ describe('execute', () => {
     expect(updatedFeaturedItemsResponse[2].displayOrder).toBe(newFeaturedItems[2].displayOrder)
     expect(updatedFeaturedItemsResponse[2].imageFileName).toEqual('featured-item-test-image-3.png')
     expect(updatedFeaturedItemsResponse[2].imageFileUrl).toBe(
-      `http://localhost:8080/api/access/dataverseFeatureItemImage/${updatedFeaturedItemsResponse[2].id}`
+      `http://localhost:8080/api/access/dataverseFeaturedItemImage/${updatedFeaturedItemsResponse[2].id}`
     )
   })
 
@@ -123,7 +123,7 @@ describe('execute', () => {
     try {
       await updateCollectionFeaturedItems.execute(invalidCollectionAlias, newFeaturedItems)
     } catch (error) {
-      writeError = error
+      writeError = error as WriteError
     } finally {
       expect(writeError).toBeInstanceOf(WriteError)
       expect((writeError as WriteError).message).toEqual(
@@ -146,7 +146,7 @@ describe('execute', () => {
     try {
       await updateCollectionFeaturedItems.execute(testCollectionAlias, newFeaturedItems)
     } catch (error) {
-      writeError = error
+      writeError = error as WriteError
     } finally {
       expect(writeError).toBeInstanceOf(WriteError)
       expect((writeError as WriteError).message).toEqual(
@@ -209,7 +209,7 @@ describe('execute', () => {
       // Should keep the existing file even if a file was not provided because keepFile is true
       expect(updatedFeaturedItemsResponse[0].imageFileName).toEqual(testFeaturedItemFilename)
       expect(updatedFeaturedItemsResponse[0].imageFileUrl).toBe(
-        `http://localhost:8080/api/access/dataverseFeatureItemImage/${updatedFeaturedItemsResponse[0].id}`
+        `http://localhost:8080/api/access/dataverseFeaturedItemImage/${updatedFeaturedItemsResponse[0].id}`
       )
     })
 
@@ -261,7 +261,7 @@ describe('execute', () => {
         'featured-item-test-image-updated.png'
       )
       expect(updatedFeaturedItemsResponse[0].imageFileUrl).toBe(
-        `http://localhost:8080/api/access/dataverseFeatureItemImage/${updatedFeaturedItemsResponse[0].id}`
+        `http://localhost:8080/api/access/dataverseFeaturedItemImage/${updatedFeaturedItemsResponse[0].id}`
       )
     })
 
@@ -288,7 +288,7 @@ describe('execute', () => {
       // Should keep the existing file even if a file was provided because keepFile is true
       expect(updatedFeaturedItemsResponse[0].imageFileName).toEqual(testFeaturedItemFilename)
       expect(updatedFeaturedItemsResponse[0].imageFileUrl).toBe(
-        `http://localhost:8080/api/access/dataverseFeatureItemImage/${updatedFeaturedItemsResponse[0].id}`
+        `http://localhost:8080/api/access/dataverseFeaturedItemImage/${updatedFeaturedItemsResponse[0].id}`
       )
     })
   })

test/integration/collections/CollectionsRepository.test.ts

@@ -926,7 +926,7 @@ describe('CollectionsRepository', () => {
       expect(featuredItemsResponse[0].displayOrder).toBe(1)
       expect(featuredItemsResponse[0].content).toBe('<p class="rte-paragraph">Test content</p>')
       expect(featuredItemsResponse[0].imageFileUrl).toBe(
-        `http://localhost:8080/api/access/dataverseFeatureItemImage/${featuredItemsResponse[0].id}`
+        `http://localhost:8080/api/access/dataverseFeaturedItemImage/${featuredItemsResponse[0].id}`
       )
       expect(featuredItemsResponse[0].imageFileName).toBe('featured-item-test-image.png')
     })
@@ -997,7 +997,7 @@ describe('CollectionsRepository', () => {
       expect(response[2].displayOrder).toEqual(newFeaturedItems[2].displayOrder)
       expect(response[2].imageFileName).toEqual('featured-item-test-image-3.png')
       expect(response[2].imageFileUrl).toBe(
-        `http://localhost:8080/api/access/dataverseFeatureItemImage/${response[2].id}`
+        `http://localhost:8080/api/access/dataverseFeaturedItemImage/${response[2].id}`
       )
     })
   })

test/testHelpers/collections/collectionFeaturedItemsHelper.ts

@@ -86,7 +86,7 @@ export const createCollectionFeaturedItemsModel = (): CollectionFeaturedItem[] =
       content: 'This is a featured item',
       displayOrder: 1,
       imageFileName: 'test-image.png',
-      imageFileUrl: 'http://localhost:8080/api/access/dataverseFeatureItemImage/1'
+      imageFileUrl: 'http://localhost:8080/api/access/dataverseFeaturedItemImage/1'
     },
     {
       id: 2,