Skip to content

Commit 424e2d5

Browse files
committed
feat: export types and rename some
1 parent fb690f9 commit 424e2d5

File tree

3 files changed

+14
-15
lines changed

3 files changed

+14
-15
lines changed
Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
export interface DatasetVersionSummaryInfo {
22
id: number
33
versionNumber: string
4-
summary?: DatasetVersionSummary | SummaryStringValues
4+
summary?: DatasetVersionSummary | DatasetVersionSummaryStringValues
55
contributors: string
66
publishedOn?: string
77
}
@@ -10,32 +10,27 @@ export type DatasetVersionSummary = {
1010
[key: string]: SummaryUpdates | SummaryUpdatesWithFields | FilesSummaryUpdates | boolean
1111
}
1212

13-
export interface SummaryUpdates {
13+
interface SummaryUpdates {
1414
added: number
1515
deleted: number
1616
changed: number
1717
}
1818

19-
export interface SummaryUpdatesWithFields {
19+
interface SummaryUpdatesWithFields {
2020
[key: string]: SummaryUpdates
2121
}
2222

23-
export interface FilesSummaryUpdates {
23+
interface FilesSummaryUpdates {
2424
added: number
2525
removed: number
2626
replaced: number
2727
changedFileMetaData: number
2828
changedVariableMetadata: number
2929
}
3030

31-
export enum SummaryStringValues {
31+
export enum DatasetVersionSummaryStringValues {
3232
firstPublished = 'firstPublished',
3333
firstDraft = 'firstDraft',
3434
versionDeaccessioned = 'versionDeaccessioned',
3535
previousVersionDeaccessioned = 'previousVersionDeaccessioned'
3636
}
37-
38-
export enum SummaryKnownFields {
39-
files = 'files',
40-
termsAccessChanged = 'termsAccessChanged'
41-
}

src/datasets/index.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,3 +95,7 @@ export {
9595
export { DatasetDeaccessionDTO } from './domain/dtos/DatasetDeaccessionDTO'
9696
export { CreatedDatasetIdentifiers } from './domain/models/CreatedDatasetIdentifiers'
9797
export { VersionUpdateType } from './domain/models/Dataset'
98+
export {
99+
DatasetVersionSummaryInfo,
100+
DatasetVersionSummaryStringValues
101+
} from './domain/models/DatasetVersionSummaryInfo'

test/integration/datasets/DatasetsRepository.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ import {
4545
} from '../../testHelpers/files/filesHelper'
4646
import {
4747
DatasetVersionSummary,
48-
SummaryStringValues
48+
DatasetVersionSummaryStringValues
4949
} from '../../../src/datasets/domain/models/DatasetVersionSummaryInfo'
5050
import { FilesRepository } from '../../../src/files/infra/repositories/FilesRepository'
5151
import { DirectUploadClient } from '../../../src/files/infra/clients/DirectUploadClient'
@@ -968,7 +968,7 @@ describe('DatasetsRepository', () => {
968968

969969
expect(actual.length).toBeGreaterThan(0)
970970
expect(actual[0].versionNumber).toBe('DRAFT')
971-
expect(actual[0].summary).toBe(SummaryStringValues.firstDraft)
971+
expect(actual[0].summary).toBe(DatasetVersionSummaryStringValues.firstDraft)
972972

973973
await deleteUnpublishedDatasetViaApi(testDatasetIds.numericId)
974974
})
@@ -986,7 +986,7 @@ describe('DatasetsRepository', () => {
986986

987987
expect(actual.length).toBeGreaterThan(0)
988988
expect(actual[0].versionNumber).toBe('1.0')
989-
expect(actual[0].summary).toBe(SummaryStringValues.firstPublished)
989+
expect(actual[0].summary).toBe(DatasetVersionSummaryStringValues.firstPublished)
990990

991991
await deletePublishedDatasetViaApi(testDatasetIds.persistentId)
992992
})
@@ -1045,7 +1045,7 @@ describe('DatasetsRepository', () => {
10451045
})
10461046

10471047
expect(actual[1].versionNumber).toBe('1.0')
1048-
expect(actual[1].summary).toBe(SummaryStringValues.firstPublished)
1048+
expect(actual[1].summary).toBe(DatasetVersionSummaryStringValues.firstPublished)
10491049

10501050
await deletePublishedDatasetViaApi(testDatasetIds.persistentId)
10511051
})
@@ -1106,7 +1106,7 @@ describe('DatasetsRepository', () => {
11061106
})
11071107

11081108
expect(actual[1].versionNumber).toBe('1.0')
1109-
expect(actual[1].summary).toBe(SummaryStringValues.firstPublished)
1109+
expect(actual[1].summary).toBe(DatasetVersionSummaryStringValues.firstPublished)
11101110

11111111
await deletePublishedDatasetViaApi(testDatasetIds.persistentId)
11121112
})

0 commit comments

Comments
 (0)