Skip to content

Commit 5307e38

Browse files
committed
Changed: getAllDatasetPreviews using subcollection to avoid conflicts with other running ITs
1 parent 586c52b commit 5307e38

File tree

1 file changed

+35
-17
lines changed

1 file changed

+35
-17
lines changed

test/integration/datasets/DatasetsRepository.test.ts

Lines changed: 35 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,18 @@ describe('DatasetsRepository', () => {
8080

8181
const createDatasets = async () => {
8282
try {
83-
firstDatasetIds = await createDataset.execute(TestConstants.TEST_NEW_DATASET_DTO)
84-
secondDatasetIds = await createDataset.execute(TestConstants.TEST_NEW_DATASET_DTO)
85-
thirdDatasetIds = await createDataset.execute(TestConstants.TEST_NEW_DATASET_DTO)
83+
firstDatasetIds = await createDataset.execute(
84+
TestConstants.TEST_NEW_DATASET_DTO,
85+
TestConstants.TEST_CREATED_COLLECTION_ALIAS
86+
)
87+
secondDatasetIds = await createDataset.execute(
88+
TestConstants.TEST_NEW_DATASET_DTO,
89+
TestConstants.TEST_CREATED_COLLECTION_ALIAS
90+
)
91+
thirdDatasetIds = await createDataset.execute(
92+
TestConstants.TEST_NEW_DATASET_DTO,
93+
TestConstants.TEST_CREATED_COLLECTION_ALIAS
94+
)
8695
fourthDatasetIds = await createDataset.execute(
8796
TestConstants.TEST_NEW_DATASET_DTO,
8897
TestConstants.TEST_CREATED_COLLECTION_ALIAS
@@ -114,49 +123,58 @@ describe('DatasetsRepository', () => {
114123
}
115124

116125
test('should return all dataset previews when no pagination params are defined', async () => {
117-
const actual: DatasetPreviewSubset = await sut.getAllDatasetPreviews()
126+
const actual: DatasetPreviewSubset = await sut.getAllDatasetPreviews(
127+
undefined,
128+
undefined,
129+
TestConstants.TEST_CREATED_COLLECTION_ALIAS
130+
)
118131
expect(actual.datasetPreviews.length).toEqual(expectedTotalDatasetCount)
119132
expect(actual.datasetPreviews[0].persistentId).toMatch(fourthDatasetIds.persistentId)
120133
expect(actual.totalDatasetCount).toEqual(expectedTotalDatasetCount)
121134
})
122135

123136
test('should return first dataset preview page', async () => {
124-
const actual = await sut.getAllDatasetPreviews(testPageLimit, 0)
137+
const actual = await sut.getAllDatasetPreviews(
138+
testPageLimit,
139+
0,
140+
TestConstants.TEST_CREATED_COLLECTION_ALIAS
141+
)
125142
expect(actual.datasetPreviews.length).toEqual(1)
126143
expect(actual.datasetPreviews[0].persistentId).toMatch(fourthDatasetIds.persistentId)
127144
expect(actual.totalDatasetCount).toEqual(expectedTotalDatasetCount)
128145
})
129146

130147
test('should return second dataset preview page', async () => {
131-
const actual = await sut.getAllDatasetPreviews(testPageLimit, 1)
148+
const actual = await sut.getAllDatasetPreviews(
149+
testPageLimit,
150+
1,
151+
TestConstants.TEST_CREATED_COLLECTION_ALIAS
152+
)
132153
expect(actual.datasetPreviews.length).toEqual(1)
133154
expect(actual.datasetPreviews[0].persistentId).toMatch(thirdDatasetIds.persistentId)
134155
expect(actual.totalDatasetCount).toEqual(expectedTotalDatasetCount)
135156
})
136157

137158
test('should return third dataset preview page', async () => {
138-
const actual = await sut.getAllDatasetPreviews(testPageLimit, 2)
159+
const actual = await sut.getAllDatasetPreviews(
160+
testPageLimit,
161+
2,
162+
TestConstants.TEST_CREATED_COLLECTION_ALIAS
163+
)
139164
expect(actual.datasetPreviews.length).toEqual(1)
140165
expect(actual.datasetPreviews[0].persistentId).toMatch(secondDatasetIds.persistentId)
141166
expect(actual.totalDatasetCount).toEqual(expectedTotalDatasetCount)
142167
})
143168

144169
test('should return fourth dataset preview page', async () => {
145-
const actual = await sut.getAllDatasetPreviews(testPageLimit, 3)
146-
expect(actual.datasetPreviews.length).toEqual(1)
147-
expect(actual.datasetPreviews[0].persistentId).toMatch(firstDatasetIds.persistentId)
148-
expect(actual.totalDatasetCount).toEqual(expectedTotalDatasetCount)
149-
})
150-
151-
test('should return datasets in the specified collection', async () => {
152170
const actual = await sut.getAllDatasetPreviews(
153171
testPageLimit,
154-
0,
172+
3,
155173
TestConstants.TEST_CREATED_COLLECTION_ALIAS
156174
)
157-
expect(actual.datasetPreviews[0].persistentId).toMatch(fourthDatasetIds.persistentId)
158175
expect(actual.datasetPreviews.length).toEqual(1)
159-
expect(actual.totalDatasetCount).toEqual(1)
176+
expect(actual.datasetPreviews[0].persistentId).toMatch(firstDatasetIds.persistentId)
177+
expect(actual.totalDatasetCount).toEqual(expectedTotalDatasetCount)
160178
})
161179
})
162180

0 commit comments

Comments
 (0)