Skip to content

Commit 600cb77

Browse files
g-saraccag-saracca
committed
fix: ts errors in unit tests
1 parent d1b4b35 commit 600cb77

File tree

8 files changed

+23
-23
lines changed

8 files changed

+23
-23
lines changed

‎test/unit/auth/AuthRepository.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ describe('logout', () => {
5454
test('should return error result on error response', async () => {
5555
jest.spyOn(axios, 'post').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
5656

57-
let error: WriteError = undefined
57+
let error: WriteError | undefined = undefined
5858
await sut.logout().catch((e) => (error = e))
5959

6060
expect(axios.post).toHaveBeenCalledWith(

‎test/unit/files/FilesRepository.test.ts‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ describe('FilesRepository', () => {
261261
offset: testOffset,
262262
orderCriteria: testFileOrderCriteria,
263263
contentType: testFileCriteria.contentType,
264-
accessStatus: testFileCriteria.accessStatus.toString(),
264+
accessStatus: testFileCriteria.accessStatus?.toString(),
265265
categoryName: testFileCriteria.categoryName,
266266
tabularTagName: testFileCriteria.tabularTagName
267267
}
@@ -330,7 +330,7 @@ describe('FilesRepository', () => {
330330
test('should return error result on error response', async () => {
331331
jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
332332

333-
let error: ReadError = undefined
333+
let error: ReadError | undefined = undefined
334334
await sut
335335
.getDatasetFiles(
336336
testDatasetId,
@@ -402,7 +402,7 @@ describe('FilesRepository', () => {
402402
test('should return error result on error response', async () => {
403403
jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
404404

405-
let error: ReadError = undefined
405+
let error: ReadError | undefined = undefined
406406
await sut
407407
.getDatasetFiles(
408408
TestConstants.TEST_DUMMY_PERSISTENT_ID,
@@ -440,7 +440,7 @@ describe('FilesRepository', () => {
440440
const expectedRequestParamsWithOptional = {
441441
includeDeaccessioned: testIncludeDeaccessioned,
442442
contentType: testFileCriteria.contentType,
443-
accessStatus: testFileCriteria.accessStatus.toString(),
443+
accessStatus: testFileCriteria.accessStatus?.toString(),
444444
categoryName: testFileCriteria.categoryName,
445445
tabularTagName: testFileCriteria.tabularTagName
446446
}
@@ -504,7 +504,7 @@ describe('FilesRepository', () => {
504504
test('should return error result on error response', async () => {
505505
jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
506506

507-
let error: ReadError = undefined
507+
let error: ReadError | undefined = undefined
508508
await sut
509509
.getDatasetFileCounts(testDatasetId, testDatasetVersionId, testIncludeDeaccessioned)
510510
.catch((e) => (error = e))
@@ -549,7 +549,7 @@ describe('FilesRepository', () => {
549549
test('should return error result on error response', async () => {
550550
jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
551551

552-
let error: ReadError = undefined
552+
let error: ReadError | undefined = undefined
553553
await sut
554554
.getDatasetFileCounts(
555555
TestConstants.TEST_DUMMY_PERSISTENT_ID,
@@ -595,7 +595,7 @@ describe('FilesRepository', () => {
595595
mode: FileDownloadSizeMode.ARCHIVAL.toString(),
596596
includeDeaccessioned: testIncludeDeaccessioned,
597597
contentType: testFileCriteria.contentType,
598-
accessStatus: testFileCriteria.accessStatus.toString(),
598+
accessStatus: testFileCriteria.accessStatus?.toString(),
599599
categoryName: testFileCriteria.categoryName,
600600
tabularTagName: testFileCriteria.tabularTagName
601601
},
@@ -656,7 +656,7 @@ describe('FilesRepository', () => {
656656
test('should return error result on error response', async () => {
657657
jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
658658

659-
let error: ReadError = undefined
659+
let error: ReadError | undefined = undefined
660660
await sut
661661
.getDatasetFilesTotalDownloadSize(
662662
testDatasetId,
@@ -708,7 +708,7 @@ describe('FilesRepository', () => {
708708
test('should return error result on error response', async () => {
709709
jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
710710

711-
let error: ReadError = undefined
711+
let error: ReadError | undefined = undefined
712712
await sut
713713
.getDatasetFilesTotalDownloadSize(
714714
TestConstants.TEST_DUMMY_PERSISTENT_ID,
@@ -765,7 +765,7 @@ describe('FilesRepository', () => {
765765
test('should return error result on error response', async () => {
766766
jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
767767

768-
let error: ReadError = undefined
768+
let error: ReadError | undefined = undefined
769769
await sut.getFileDownloadCount(testFile.id).catch((e) => (error = e))
770770

771771
expect(axios.get).toHaveBeenCalledWith(
@@ -806,7 +806,7 @@ describe('FilesRepository', () => {
806806
test('should return error result on error response', async () => {
807807
jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
808808

809-
let error: ReadError = undefined
809+
let error: ReadError | undefined = undefined
810810
await sut
811811
.getFileDownloadCount(TestConstants.TEST_DUMMY_PERSISTENT_ID)
812812
.catch((e) => (error = e))
@@ -859,7 +859,7 @@ describe('FilesRepository', () => {
859859
test('should return error result on error response', async () => {
860860
jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
861861

862-
let error: ReadError = undefined
862+
let error: ReadError | undefined = undefined
863863
await sut.getFileUserPermissions(testFile.id).catch((e) => (error = e))
864864

865865
expect(axios.get).toHaveBeenCalledWith(
@@ -899,7 +899,7 @@ describe('FilesRepository', () => {
899899
test('should return error result on error response', async () => {
900900
jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
901901

902-
let error: ReadError = undefined
902+
let error: ReadError | undefined = undefined
903903
await sut
904904
.getFileUserPermissions(TestConstants.TEST_DUMMY_PERSISTENT_ID)
905905
.catch((e) => (error = e))
@@ -952,7 +952,7 @@ describe('FilesRepository', () => {
952952
test('should return error result on error response', async () => {
953953
jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
954954

955-
let error: ReadError = undefined
955+
let error: ReadError | undefined = undefined
956956
await sut.getFileDataTables(testFile.id).catch((e) => (error = e))
957957

958958
expect(axios.get).toHaveBeenCalledWith(
@@ -993,7 +993,7 @@ describe('FilesRepository', () => {
993993
test('should return error result on error response', async () => {
994994
jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
995995

996-
let error: ReadError = undefined
996+
let error: ReadError | undefined = undefined
997997
await sut
998998
.getFileDataTables(TestConstants.TEST_DUMMY_PERSISTENT_ID)
999999
.catch((e) => (error = e))

‎test/unit/files/GetFileDataTables.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ describe('execute', () => {
2525
filesRepositoryStub.getFileDataTables = jest.fn().mockRejectedValue(testReadError)
2626
const sut = new GetFileDataTables(filesRepositoryStub)
2727

28-
let actualError: ReadError = undefined
28+
let actualError: ReadError | undefined = undefined
2929
await sut.execute(testFileId).catch((e: ReadError) => (actualError = e))
3030

3131
expect(actualError).toBe(testReadError)

‎test/unit/info/GetDataverseVersion.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ describe('execute', () => {
2222
dataverseInfoRepositoryStub.getDataverseVersion = jest.fn().mockRejectedValue(testReadError)
2323
const sut = new GetDataverseVersion(dataverseInfoRepositoryStub)
2424

25-
let actualError: ReadError = undefined
25+
let actualError: ReadError | undefined = undefined
2626
await sut.execute().catch((e) => (actualError = e))
2727

2828
expect(actualError).toBe(testReadError)

‎test/unit/info/GetZipDownloadLimit.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ describe('execute', () => {
2222
dataverseInfoRepositoryStub.getZipDownloadLimit = jest.fn().mockRejectedValue(new ReadError())
2323
const sut = new GetZipDownloadLimit(dataverseInfoRepositoryStub)
2424

25-
let actualError: ReadError
25+
let actualError: ReadError | undefined = undefined
2626
await sut.execute().catch((e) => (actualError = e))
2727

2828
expect(actualError).toBeInstanceOf(ReadError)

‎test/unit/metadataBlocks/GetMetadataBlockByName.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ describe('execute', () => {
2929
.mockRejectedValue(new ReadError())
3030
const sut = new GetMetadataBlockByName(metadataBlocksRepositoryStub)
3131

32-
let actualError: ReadError
32+
let actualError: ReadError | undefined = undefined
3333
await sut.execute(testMetadataBlockName).catch((e) => (actualError = e))
3434

3535
expect(actualError).toBeInstanceOf(ReadError)

‎test/unit/metadataBlocks/MetadataBlocksRepository.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ describe('MetadataBlocksRepository', () => {
6363
}
6464
jest.spyOn(axios, 'get').mockRejectedValue(testErrorResponse)
6565

66-
let error: ReadError = undefined
66+
let error: ReadError | undefined = undefined
6767
await sut
6868
.getCollectionMetadataBlocks(TestConstants.TEST_DUMMY_COLLECTION_ID, true)
6969
.catch((e) => (error = e))
@@ -104,7 +104,7 @@ describe('MetadataBlocksRepository', () => {
104104
}
105105
jest.spyOn(axios, 'get').mockRejectedValue(testErrorResponse)
106106

107-
let error: ReadError = undefined
107+
let error: ReadError | undefined = undefined
108108
await sut.getMetadataBlockByName(testMetadataBlockName).catch((e) => (error = e))
109109

110110
expect(axios.get).toHaveBeenCalledWith(

‎test/unit/users/UsersRepository.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ describe('getCurrentAuthenticatedUser', () => {
6767
test('should return error result on error response', async () => {
6868
jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
6969

70-
let error: ReadError = undefined
70+
let error: ReadError | undefined = undefined
7171
await sut.getCurrentAuthenticatedUser().catch((e) => (error = e))
7272

7373
expect(axios.get).toHaveBeenCalledWith(

0 commit comments

Comments
 (0)