refactor: remove date format validation logic and associated error handling

Author: g-saracca

src/datasets/domain/useCases/validators/SingleMetadataFieldValidator.ts

@@ -3,14 +3,12 @@ import {
   DatasetMetadataFieldAndValueInfo
 } from './BaseMetadataFieldValidator'
 import { ControlledVocabularyFieldError } from './errors/ControlledVocabularyFieldError'
-import { DateFormatFieldError } from './errors/DateFormatFieldError'
 import { MetadataFieldValidator } from './MetadataFieldValidator'
 import { DatasetMetadataChildFieldValueDTO } from '../../dtos/DatasetDTO'
 import { MultipleMetadataFieldValidator } from './MultipleMetadataFieldValidator'
 import {
   MetadataFieldInfo,
-  MetadataFieldType,
-  MetadataFieldWatermark
+  MetadataFieldType
 } from '../../../../metadataBlocks/domain/models/MetadataBlock'
 
 export class SingleMetadataFieldValidator extends BaseMetadataFieldValidator {
@@ -50,10 +48,6 @@ export class SingleMetadataFieldValidator extends BaseMetadataFieldValidator {
       this.validateControlledVocabularyFieldValue(datasetMetadataFieldAndValueInfo)
     }
 
-    if (metadataFieldInfo.type == MetadataFieldType.Date) {
-      this.validateDateFieldValue(datasetMetadataFieldAndValueInfo)
-    }
-
     if (metadataFieldInfo.childMetadataFields != undefined) {
       this.validateChildMetadataFieldValues(datasetMetadataFieldAndValueInfo)
     }
@@ -76,47 +70,6 @@ export class SingleMetadataFieldValidator extends BaseMetadataFieldValidator {
     }
   }
 
-  private validateDateFieldValue(
-    datasetMetadataFieldAndValueInfo: DatasetMetadataFieldAndValueInfo
-  ) {
-    const {
-      metadataFieldInfo: { watermark },
-      metadataFieldValue
-    } = datasetMetadataFieldAndValueInfo
-
-    const acceptsAllDateFormats = watermark === MetadataFieldWatermark.YYYYOrYYYYMMOrYYYYMMDD
-
-    const YYYY_MM_DD_DATE_FORMAT_REGEX = /^\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[12][0-9]|3[01])$/
-
-    const YYYY_MM_FORMAT_REGEX = /^\d{4}-(0[1-9]|1[0-2])$/
-
-    const YYYY_FORMAT_REGEX = /^\d{4}$/
-
-    const isValidDateFormat = (value: string): boolean => {
-      if (acceptsAllDateFormats) {
-        // Check if it matches any of the formats
-        return (
-          YYYY_MM_DD_DATE_FORMAT_REGEX.test(value) ||
-          YYYY_MM_FORMAT_REGEX.test(value) ||
-          YYYY_FORMAT_REGEX.test(value)
-        )
-      } else {
-        // Only accepts YYYY-MM-DD format
-        return YYYY_MM_DD_DATE_FORMAT_REGEX.test(value)
-      }
-    }
-
-    if (!isValidDateFormat(metadataFieldValue as string)) {
-      throw new DateFormatFieldError(
-        datasetMetadataFieldAndValueInfo.metadataFieldKey,
-        datasetMetadataFieldAndValueInfo.metadataBlockName,
-        watermark,
-        datasetMetadataFieldAndValueInfo.metadataParentFieldKey,
-        datasetMetadataFieldAndValueInfo.metadataFieldPosition
-      )
-    }
-  }
-
   private validateChildMetadataFieldValues(
     datasetMetadataFieldAndValueInfo: DatasetMetadataFieldAndValueInfo
   ) {

src/datasets/domain/useCases/validators/errors/DateFormatFieldError.ts

@@ -154,64 +154,6 @@ describe('validate', () => {
     expect(() => sut.validate(testDataset, testMetadataBlocks)).not.toThrow()
   })
 
-  test('should raise a date format validation error when a date field has an invalid format', () => {
-    const testDataset = createDatasetDTO(undefined, undefined, undefined, '1-1-2020')
-
-    expect.assertions(6)
-    runValidateExpectingFieldValidationError(
-      testDataset,
-      'timePeriodCoveredStart',
-      'There was an error when validating the field timePeriodCoveredStart from metadata block citation. Reason was: The field requires a valid date format (YYYY or YYYY-MM or YYYY-MM-DD).'
-    )
-  })
-
-  test('should not raise a date format validation error when a date field has a valid YYYY-MM-DD format', () => {
-    const testDataset = createDatasetDTO(undefined, undefined, undefined, '2020-01-01')
-    expect(() => sut.validate(testDataset, testMetadataBlocks)).not.toThrow()
-  })
-
-  test('should not raise a date format validation error when a date field has a valid YYYY-MM format', () => {
-    const testDataset = createDatasetDTO(undefined, undefined, undefined, '2020-01')
-    expect(() => sut.validate(testDataset, testMetadataBlocks)).not.toThrow()
-  })
-
-  test('should not raise a date format validation error when a date field has a valid YYYY format', () => {
-    const testDataset = createDatasetDTO(undefined, undefined, undefined, '2020')
-    expect(() => sut.validate(testDataset, testMetadataBlocks)).not.toThrow()
-  })
-
-  test('should raise a date format validation error when a date field has a wrong date format according to the field watermark', () => {
-    const testDataset = createDatasetDTO(
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      '01-03'
-    )
-
-    expect.assertions(6)
-    runValidateExpectingFieldValidationError(
-      testDataset,
-      'dateOfCreation',
-      'There was an error when validating the field dateOfCreation from metadata block citation. Reason was: The field requires a valid date format (YYYY-MM-DD).'
-    )
-  })
-
-  test('should not raise a date format validation error when a date field has a valid format according to the field watermark', () => {
-    const testDataset = createDatasetDTO(
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      '2024-01-03'
-    )
-    expect(() => sut.validate(testDataset, testMetadataBlocks)).not.toThrow()
-  })
-
   test('should raise a controlled vocabulary error when a controlled vocabulary field has an invalid format', () => {
     const testDataset = createDatasetDTO(
       undefined,