fix: update the response format

Author: ChengShi-1

src/datasets/domain/models/CitationResponse.ts

@@ -1,7 +1,4 @@
-import { CitationFormats } from './CitationFormats'
-
 export type CitationResponse = {
-  content: string
-  format: CitationFormats
+  content: string | object
   contentType: string
 }

src/datasets/infra/repositories/DatasetsRepository.ts

@@ -108,20 +108,11 @@ export class DatasetsRepository extends ApiRepository implements IDatasetsReposi
       `versions/${datasetVersionId}/citation/${format}`,
       datasetId
     )
+    const response = await this.doGet(endpoint, true, { includeDeaccessioned })
 
-    const queryParams = { includeDeaccessioned }
-
-    try {
-      const response = await this.doGet(endpoint, true, queryParams)
-
-      return {
-        content: response.data,
-        format,
-        contentType: response.headers['content-type'] ?? 'text/plain'
-      }
-    } catch (error) {
-      console.error(`[DatasetsRepository] Error fetching citation:`, error)
-      throw error
+    return {
+      content: response.data,
+      contentType: response.headers['content-type']
     }
   }
 

test/integration/datasets/DatasetsRepository.test.ts

@@ -512,7 +512,6 @@ describe('DatasetsRepository', () => {
       )
 
       expect(typeof citation.content).toBe('string')
-      expect(citation.format).toBe(CitationFormats.BibTeX)
       expect(citation.contentType).toMatch(/text\/plain/)
     })
 
@@ -524,7 +523,6 @@ describe('DatasetsRepository', () => {
       )
 
       expect(typeof citation.content).toBe('string')
-      expect(citation.format).toBe(CitationFormats.RIS)
       expect(citation.contentType).toMatch(/text\/plain/)
     })
 
@@ -536,7 +534,6 @@ describe('DatasetsRepository', () => {
       )
 
       expect(typeof citation.content).toBe('object')
-      expect(citation.format).toBe(CitationFormats.CSLJson)
       expect(citation.contentType).toMatch(/application\/json/)
     })
 
@@ -548,7 +545,6 @@ describe('DatasetsRepository', () => {
       )
 
       expect(typeof citation.content).toBe('string')
-      expect(citation.format).toBe(CitationFormats.EndNote)
       expect(citation.contentType).toMatch('text/xml;charset=UTF-8')
     })
 
@@ -560,7 +556,6 @@ describe('DatasetsRepository', () => {
       )
 
       expect(typeof citation.content).toBe('string')
-      expect(citation.format).toBe(CitationFormats.Internal)
       expect(citation.contentType).toMatch(/text\/html/)
     })
 
@@ -590,7 +585,6 @@ describe('DatasetsRepository', () => {
       )
 
       expect(typeof citation.content).toBe('string')
-      expect(citation.format).toBe(CitationFormats.RIS)
       expect(citation.contentType).toMatch(/text\/plain/)
     })
   })

test/unit/datasets/GetDatasetCitationInOtherFormats.test.ts

@@ -13,7 +13,6 @@ describe('GetDatasetCitationInOtherFormats.execute', () => {
   test('should return citation response on repository success', async () => {
     const expectedCitation: CitationResponse = {
       content: '@data{example, ...}',
-      format: CitationFormats.BibTeX,
       contentType: 'text/plain'
     }