Skip to content

Commit 8be8962

Browse files
committed
fix: dataset download count
1 parent 8843762 commit 8be8962

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
export interface DatasetDownloadCount {
2-
id: number
2+
id: number | string
33
downloadCount: number
44
MDCStartDate?: string
55
}

test/environment/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ services:
3232
-Ddataverse.files.localstack1.access-key=default
3333
-Ddataverse.files.localstack1.secret-key=default
3434
ports:
35-
- '8081:8080'
35+
- '8080:8080'
3636
networks:
3737
- dataverse
3838
depends_on:

test/integration/datasets/DatasetsRepository.test.ts

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,9 +1106,7 @@ describe('DatasetsRepository', () => {
11061106
expect(actual[1].versionNumber).toBe('1.0')
11071107
expect(actual[1].summary).toBe(DatasetVersionSummaryStringValues.firstPublished)
11081108

1109-
// await deletePublishedDatasetViaApi(testDatasetIds.persistentId)
1110-
console.log('od', testDatasetIds.numericId)
1111-
console.log('X-Dataverse-Key', process.env.TEST_API_KEY)
1109+
await deletePublishedDatasetViaApi(testDatasetIds.persistentId)
11121110
})
11131111
})
11141112

@@ -1132,6 +1130,16 @@ describe('DatasetsRepository', () => {
11321130
expect(actual.downloadCount).toBe(0)
11331131
})
11341132

1133+
test('should return download count including MDC data with persistent ID', async () => {
1134+
const testDatasetIds = await createDataset.execute(TestConstants.TEST_NEW_DATASET_DTO)
1135+
await publishDatasetViaApi(testDatasetIds.numericId)
1136+
await waitForNoLocks(testDatasetIds.numericId, 10)
1137+
1138+
const actual = await sut.getDatasetDownloadCount(testDatasetIds.persistentId, true)
1139+
1140+
expect(actual.downloadCount).toBe(0)
1141+
})
1142+
11351143
test('should return error when dataset does not exist', async () => {
11361144
await expect(sut.getDatasetDownloadCount(nonExistentTestDatasetId)).rejects.toBeInstanceOf(
11371145
ReadError

0 commit comments

Comments
 (0)