fix tests and remove logs

Author: ekraffmiller

src/notifications/infra/repositories/NotificationsRepository.ts

@@ -19,16 +19,12 @@ export class NotificationsRepository extends ApiRepository implements INotificat
     if (onlyUnread) queryParams.set('onlyUnread', 'true')
     if (limit !== undefined) queryParams.set('limit', limit.toString())
     if (offset !== undefined) queryParams.set('offset', offset.toString())
-    console.log('Fetching notifications with params:', queryParams.toString())
-    console.log('keys:', Array.from(queryParams.keys()))
-    console.log('length:', Object.keys(queryParams).length)
     return this.doGet(
       this.buildApiEndpoint(this.notificationsResourceName, 'all'),
       true,
       queryParams
     )
       .then((response) => {
-        console.log('Notifications API response:', response.data)
         const notifications = response.data.data.map((notification: NotificationPayload) => {
           const { dataverseDisplayName, dataverseAlias, ...restNotification } = notification
           return {

test/functional/notifications/DeleteNotification.test.ts

@@ -20,7 +20,8 @@ describe('execute', () => {
 
     const notificationsAfterDeleteSubset = await getAllNotificationsByUser.execute()
     const notificationsAfterDelete = notificationsAfterDeleteSubset.notifications
-    expect(notificationsAfterDelete.length).toBe(notifications.length - 1)
+    const deletedExists = notificationsAfterDelete.some((n) => n.id === notificationId)
+    expect(deletedExists).toBe(false)
   })
 
   test('should throw an error when the notification id does not exist', async () => {

test/integration/notifications/NotificationsRepository.test.ts

@@ -189,22 +189,16 @@ describe('NotificationsRepository', () => {
     const notificationSubset: NotificationSubset = await sut.getAllNotificationsByUser(true, true)
 
     expect(Array.isArray(notificationSubset.notifications)).toBe(true)
-    const originalUnreadCount = notificationSubset.totalNotificationCount
     expect(notificationSubset.notifications.length).toBeGreaterThanOrEqual(0)
+    const notificationToMarkRead = notificationSubset.notifications[0]
+    await expect(sut.markNotificationAsRead(notificationToMarkRead.id)).resolves.toBeUndefined()
 
-    await expect(
-      sut.markNotificationAsRead(notificationSubset.notifications[0].id)
-    ).resolves.toBeUndefined()
-
-    const updatedNotifications: NotificationSubset = await sut.getAllNotificationsByUser(
-      true,
-      true,
-      10,
-      0
+    const updatedNotifications: NotificationSubset = await sut.getAllNotificationsByUser(true, true)
+    const stillPresent = updatedNotifications.notifications.some(
+      (n) => n.id === notificationToMarkRead.id
     )
-    expect(updatedNotifications.totalNotificationCount).toBe(originalUnreadCount - 1)
-
-    const hasReadNotifications = notificationSubset.notifications.some(
+    expect(stillPresent).toBe(false)
+    const hasReadNotifications = updatedNotifications.notifications.some(
       (n) => n.displayAsRead === true
     )
     expect(hasReadNotifications).toBe(false)