Refactor: code styling

Author: GPortas

src/collections/infra/repositories/CollectionsRepository.ts

@@ -53,20 +53,18 @@ export class CollectionsRepository extends ApiRepository implements ICollections
       })
     )
 
-    const inputLevelsRequestBody: NewCollectionInputLevelRequestPayload[] = []
-    collectionDTO.inputLevels.forEach((element) => {
-      inputLevelsRequestBody.push({
-        datasetFieldTypeName: element.datasetFieldName,
-        include: element.include,
-        required: element.required
-      })
-    })
+    const inputLevelsRequestBody: NewCollectionInputLevelRequestPayload[] =
+      collectionDTO.inputLevels.map((inputLevel) => ({
+        datasetFieldTypeName: inputLevel.datasetFieldName,
+        include: inputLevel.include,
+        required: inputLevel.required
+      }))
 
     const requestBody: NewCollectionRequestPayload = {
       alias: collectionDTO.alias,
       name: collectionDTO.name,
       dataverseContacts: dataverseContacts,
-      dataverseType: collectionDTO.type.toString(),
+      dataverseType: collectionDTO.type,
       metadataBlocks: {
         metadataBlockNames: collectionDTO.metadataBlockNames,
         facetIds: collectionDTO.facetIds,

src/collections/infra/repositories/transformers/collectionTransformers.ts

@@ -32,13 +32,9 @@ const transformPayloadToCollection = (collectionPayload: CollectionPayload): Col
 const transformInputLevelsPayloadToInputLevels = (
   inputLevelsPayload: CollectionInputLevelPayload[]
 ): CollectionInputLevel[] => {
-  const collectionInputLevels: CollectionInputLevel[] = []
-  inputLevelsPayload.forEach((element) => {
-    collectionInputLevels.push({
-      datasetFieldName: element.datasetFieldTypeName,
-      include: element.include,
-      required: element.required
-    })
-  })
-  return collectionInputLevels
+  return inputLevelsPayload.map((inputLevel) => ({
+    datasetFieldName: inputLevel.datasetFieldTypeName,
+    include: inputLevel.include,
+    required: inputLevel.required
+  }))
 }