test: add unit and integration tests

Author: g-saracca

test/integration/info/DataverseInfoRepository.test.ts

@@ -4,7 +4,11 @@ import {
   DataverseApiAuthMechanism
 } from '../../../src/core/infra/repositories/ApiConfig'
 import { TestConstants } from '../../testHelpers/TestConstants'
-import { setMaxEmbargoDurationInMonthsViaApi } from '../../testHelpers/info/infoHelper'
+import {
+  deleteApplicationTermsOfUseViaApi,
+  setApplicationTermsOfUseViaApi,
+  setMaxEmbargoDurationInMonthsViaApi
+} from '../../testHelpers/info/infoHelper'
 import { ReadError } from '../../../src/core/domain/repositories/ReadError'
 
 describe('DataverseInfoRepository', () => {
@@ -49,4 +53,23 @@ describe('DataverseInfoRepository', () => {
       expect(actual).toBe(testMaxEmbargoDurationInMonths)
     })
   })
+
+  describe('getApplicationTermsOfUse', () => {
+    test('should return no terms message when terms are not set', async () => {
+      const defaultNoTermsOfUseMessage =
+        'There are no Terms of Use for this Dataverse installation.'
+      const actual = await sut.getApplicationTermsOfUse()
+
+      expect(actual).toBe(defaultNoTermsOfUseMessage)
+    })
+    test('should return terms when terms are set', async () => {
+      const testTermsOfUse = 'Be excellent to each other.'
+      await setApplicationTermsOfUseViaApi(testTermsOfUse)
+      const actual = await sut.getApplicationTermsOfUse()
+
+      expect(actual).toBe(testTermsOfUse)
+
+      await deleteApplicationTermsOfUseViaApi()
+    })
+  })
 })

test/testHelpers/info/infoHelper.ts

@@ -12,3 +12,19 @@ export const setMaxEmbargoDurationInMonthsViaApi = async (
     }
   )
 }
+
+export const setApplicationTermsOfUseViaApi = async (
+  applicationTermsOfUse: string
+): Promise<AxiosResponse> => {
+  return await axios.put(
+    `${TestConstants.TEST_API_URL}/admin/settings/:ApplicationTermsOfUse`,
+    applicationTermsOfUse,
+    {
+      headers: { 'Content-Type': 'text/plain' }
+    }
+  )
+}
+
+export const deleteApplicationTermsOfUseViaApi = async (): Promise<AxiosResponse> => {
+  return await axios.delete(`${TestConstants.TEST_API_URL}/admin/settings/:ApplicationTermsOfUse`)
+}

test/unit/info/DataverseInfoRepository.test.ts

@@ -123,4 +123,69 @@ describe('DataverseInfoRepository', () => {
       expect(error).toBeInstanceOf(Error)
     })
   })
+
+  describe('getApplicationTermsOfUse', () => {
+    test('should return terms of use on successful response', async () => {
+      const testTermsOfUse = 'Be excellent to each other.'
+      const testSuccessfulResponse = {
+        data: {
+          status: 'OK',
+          data: {
+            message: testTermsOfUse
+          }
+        }
+      }
+      jest.spyOn(axios, 'get').mockResolvedValue(testSuccessfulResponse)
+
+      const actual = await sut.getApplicationTermsOfUse()
+
+      expect(axios.get).toHaveBeenCalledWith(
+        `${TestConstants.TEST_API_URL}/info/applicationTermsOfUse`,
+        TestConstants.TEST_EXPECTED_UNAUTHENTICATED_REQUEST_CONFIG
+      )
+      expect(actual).toMatch(testTermsOfUse)
+    })
+
+    test('should return terms of use on successful response with lang', async () => {
+      const testLang = 'en'
+      const testTermsOfUse = 'Be excellent to each other.'
+      const testSuccessfulResponse = {
+        data: {
+          status: 'OK',
+          data: {
+            message: testTermsOfUse
+          }
+        }
+      }
+      jest.spyOn(axios, 'get').mockResolvedValue(testSuccessfulResponse)
+
+      const actual = await sut.getApplicationTermsOfUse(testLang)
+
+      expect(axios.get).toHaveBeenCalledWith(
+        `${TestConstants.TEST_API_URL}/info/applicationTermsOfUse`,
+        {
+          params: {
+            lang: testLang
+          },
+          headers: {
+            'Content-Type': 'application/json'
+          }
+        }
+      )
+      expect(actual).toMatch(testTermsOfUse)
+    })
+
+    test('should return error result on error response', async () => {
+      jest.spyOn(axios, 'get').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
+
+      let error: ReadError | undefined
+      await sut.getApplicationTermsOfUse().catch((e) => (error = e))
+
+      expect(axios.get).toHaveBeenCalledWith(
+        `${TestConstants.TEST_API_URL}/info/applicationTermsOfUse`,
+        TestConstants.TEST_EXPECTED_UNAUTHENTICATED_REQUEST_CONFIG
+      )
+      expect(error).toBeInstanceOf(Error)
+    })
+  })
 })

test/unit/info/GetApplicationTermsOfUse.test.ts

@@ -0,0 +1,29 @@
+import { ReadError } from '../../../src/core/domain/repositories/ReadError'
+import { IDataverseInfoRepository } from '../../../src/info/domain/repositories/IDataverseInfoRepository'
+import { GetApplicationTermsOfUse } from '../../../src/info/domain/useCases/GetApplicationTermsOfUse'
+
+describe('execute', () => {
+  test('should return successful result with terms of use on repository success', async () => {
+    const testTermsOfUse = 'Be excellent to each other.'
+    const dataverseInfoRepositoryStub: IDataverseInfoRepository = {} as IDataverseInfoRepository
+    dataverseInfoRepositoryStub.getApplicationTermsOfUse = jest
+      .fn()
+      .mockResolvedValue(testTermsOfUse)
+    const sut = new GetApplicationTermsOfUse(dataverseInfoRepositoryStub)
+
+    const actual = await sut.execute()
+
+    expect(actual).toBe(testTermsOfUse)
+  })
+
+  test('should return error result on repository error', async () => {
+    const dataverseInfoRepositoryStub: IDataverseInfoRepository = {} as IDataverseInfoRepository
+    const testReadError = new ReadError()
+    dataverseInfoRepositoryStub.getApplicationTermsOfUse = jest
+      .fn()
+      .mockRejectedValue(testReadError)
+    const sut = new GetApplicationTermsOfUse(dataverseInfoRepositoryStub)
+
+    await expect(sut.execute()).rejects.toThrow(ReadError)
+  })
+})