Skip to content

Commit 97bc082

Browse files
committed
fix: order of version parameters
1 parent a8fa2cb commit 97bc082

File tree

4 files changed

+41
-11
lines changed

4 files changed

+41
-11
lines changed

docs/useCases.md

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ The different use cases currently available in the package are classified below,
2626
- [Get Dataset Locks](#get-dataset-locks)
2727
- [Get Dataset Summary Field Names](#get-dataset-summary-field-names)
2828
- [Get User Permissions on a Dataset](#get-user-permissions-on-a-dataset)
29+
- [Get Differences between Two Dataset Versions](#get-differences-between-two-dataset-versions)
2930
- [List All Datasets](#list-all-datasets)
3031
- [Datasets write use cases](#datasets-write-use-cases)
3132
- [Create a Dataset](#create-a-dataset)
@@ -428,6 +429,35 @@ _See [use case](../src/datasets/domain/useCases/GetDatasetUserPermissions.ts) im
428429

429430
The `datasetId` parameter can be a string, for persistent identifiers, or a number, for numeric identifiers.
430431

432+
#### Get Differences between Two Dataset Versions
433+
434+
Returns an instance of [DatasetVersionDiff](../src/datasets/domain/models/DatasetVersionDiff.ts) that contains the differences between two Dataset Versions.
435+
436+
##### Example call:
437+
438+
```typescript
439+
import { getDatasetVersionDiff } from '@iqss/dataverse-client-javascript'
440+
441+
/* ... */
442+
443+
const datasetId = 'doi:10.77777/FK2/AAAAAA'
444+
const oldVersion = '1.0'
445+
const newVersion = '2.0'
446+
447+
getDatasetVersionDiff.execute(datasetId, oldVersion, newVersion).then((versionDiff: DatasetVersionDiff) => {
448+
/* ... */
449+
})
450+
451+
/* ... */
452+
```
453+
454+
_See [use case](../src/datasets/domain/useCases/GetDatasetVersionDiff.ts) implementation_.
455+
456+
The `datasetId` parameter can be a string, for persistent identifiers, or a number, for numeric identifiers.
457+
458+
The `oldVersion` and `newVersion` parameters specify the versions of the dataset to compare.
459+
460+
431461
#### List All Datasets
432462

433463
Returns an instance of [DatasetPreviewSubset](../src/datasets/domain/models/DatasetPreviewSubset.ts) that contains reduced information for each dataset that the calling user can access in the installation.

src/datasets/domain/useCases/GetDatasetVersionDiff.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,18 @@ export class GetDatasetVersionDiff implements UseCase<DatasetVersionDiff> {
1212
/**
1313
* Returns a DatasetVersionDiff instance, which contains the differences between the two given versions.
1414
* @param {number | string} [datasetId] - The dataset identifier, which can be a string (for persistent identifiers), or a number (for numeric identifiers).
15-
* @param {string } [newVersionId] - The dataset version identifier, which can be a version-specific numeric string (for example, 1.0) or a DatasetNotNumberedVersion enum value.
1615
* @param {string } [oldVersionId] - The dataset version identifier, which can be a version-specific numeric string (for example, 1.0) or a DatasetNotNumberedVersion enum value.
16+
* @param {string } [newVersionId] - The dataset version identifier, which can be a version-specific numeric string (for example, 1.0) or a DatasetNotNumberedVersion enum value.
1717
*/
1818
async execute(
1919
datasetId: number | string,
20-
newVersionId: string,
21-
oldVersionId: string
20+
oldVersionId: string,
21+
newVersionId: string
2222
): Promise<DatasetVersionDiff> {
2323
return await this.datasetsRepository.getDatasetVersionDiff(
2424
datasetId,
25-
newVersionId,
26-
oldVersionId
25+
oldVersionId,
26+
newVersionId
2727
)
2828
}
2929
}

src/datasets/infra/repositories/DatasetsRepository.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,8 @@ export class DatasetsRepository extends ApiRepository implements IDatasetsReposi
145145

146146
public async getDatasetVersionDiff(
147147
datasetId: string | number,
148-
newVersionId: string,
149-
oldVersionId: string
148+
oldVersionId: string,
149+
newVersionId: string
150150
): Promise<DatasetVersionDiff> {
151151
return this.doGet(
152152
this.buildApiEndpoint(

test/integration/datasets/DatasetsRepository.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -490,8 +490,8 @@ describe('DatasetsRepository', () => {
490490
])
491491
const actual = await sut.getDatasetVersionDiff(
492492
testDatasetIds.numericId,
493-
DatasetNotNumberedVersion.DRAFT,
494-
'1.0'
493+
'1.0',
494+
DatasetNotNumberedVersion.DRAFT
495495
)
496496
expect(actual.metadataChanges[0].blockName).toEqual('Citation Metadata')
497497
})
@@ -516,8 +516,8 @@ describe('DatasetsRepository', () => {
516516
await uploadFileViaApi(testDatasetIds.numericId, testTextFile1Name, fileMetadata)
517517
const actual = await sut.getDatasetVersionDiff(
518518
testDatasetIds.numericId,
519-
DatasetNotNumberedVersion.DRAFT,
520-
'1.0'
519+
'1.0',
520+
DatasetNotNumberedVersion.DRAFT
521521
)
522522
expect(actual.filesAdded).toEqual(expectedFilesAdded)
523523
})

0 commit comments

Comments
 (0)