Skip to content

Commit b681b76

Browse files
committed
fix: add string type
1 parent a279321 commit b681b76

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

docs/useCases.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1312,7 +1312,7 @@ replaceFile.execute(fileId, uploadedFileDTO)
13121312

13131313
_See [use case](../src/files/domain/useCases/ReplaceFile.ts) implementation_.
13141314

1315-
The `fileId` parameter should be a number, the numeric identifier.
1315+
The `fileId` parameter can be a string, for persistent identifiers, or a number, for numeric identifiers.
13161316

13171317
The `uploadedFileDTO` parameter is a [UploadedFileDTO](../src/files/domain/dtos/UploadedFileDTO.ts) and includes properties related to the uploaded files. Some of these properties should be calculated from the uploaded File Blob objects and the resulting storage identifiers from the Upload File use case.
13181318

src/files/domain/repositories/IFilesRepository.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export interface IFilesRepository {
6262

6363
deleteFile(fileId: number | string): Promise<undefined>
6464

65-
replaceFile(fileId: number, uploadedFileDTO: UploadedFileDTO): Promise<undefined>
65+
replaceFile(fileId: number | string, uploadedFileDTO: UploadedFileDTO): Promise<undefined>
6666

6767
restrictFile(fileId: number | string, restrict: boolean): Promise<undefined>
6868
}

src/files/domain/useCases/ReplaceFile.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export class ReplaceFile implements UseCase<void> {
2222
* @returns {Promise<void>} A promise that resolves when the file has been successfully replaced.
2323
* @throws {WriteError} - If there are errors while writing data.
2424
*/
25-
async execute(fileId: number, uploadedFileDTO: UploadedFileDTO): Promise<void> {
25+
async execute(fileId: number | string, uploadedFileDTO: UploadedFileDTO): Promise<void> {
2626
await this.filesRepository.replaceFile(fileId, uploadedFileDTO)
2727
}
2828
}

src/files/infra/repositories/FilesRepository.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,10 @@ export class FilesRepository extends ApiRepository implements IFilesRepository {
303303
})
304304
}
305305

306-
public async replaceFile(fileId: number, uploadedFileDTO: UploadedFileDTO): Promise<undefined> {
306+
public async replaceFile(
307+
fileId: number | string,
308+
uploadedFileDTO: UploadedFileDTO
309+
): Promise<undefined> {
307310
const requestBody: UploadedFileRequestBody = {
308311
fileName: uploadedFileDTO.fileName,
309312
checksum: {

0 commit comments

Comments
 (0)