Changed: createCollection returning created collection id

Author: GPortas

src/collections/domain/repositories/ICollectionsRepository.ts

@@ -3,5 +3,5 @@ import { Collection } from '../models/Collection'
 
 export interface ICollectionsRepository {
   getCollection(collectionIdOrAlias: number | string): Promise<Collection>
-  createCollection(collectionDTO: CollectionDTO, parentCollectionId: string): Promise<void>
+  createCollection(collectionDTO: CollectionDTO, parentCollectionId: string): Promise<number>
 }

src/collections/domain/useCases/CreateCollection.ts

@@ -2,7 +2,7 @@ import { UseCase } from '../../../core/domain/useCases/UseCase'
 import { CollectionDTO } from '../dtos/CollectionDTO'
 import { ICollectionsRepository } from '../repositories/ICollectionsRepository'
 
-export class CreateCollection implements UseCase<void> {
+export class CreateCollection implements UseCase<number> {
   private collectionsRepository: ICollectionsRepository
 
   constructor(collectionsRepository: ICollectionsRepository) {
@@ -12,7 +12,7 @@ export class CreateCollection implements UseCase<void> {
   /**
    * TODO
    */
-  async execute(newCollection: CollectionDTO, parentCollectionId = 'root'): Promise<void> {
-    await this.collectionsRepository.createCollection(newCollection, parentCollectionId)
+  async execute(newCollection: CollectionDTO, parentCollectionId = 'root'): Promise<number> {
+    return await this.collectionsRepository.createCollection(newCollection, parentCollectionId)
   }
 }

src/collections/infra/repositories/CollectionsRepository.ts

@@ -22,7 +22,7 @@ export class CollectionsRepository extends ApiRepository implements ICollections
   public async createCollection(
     collectionDTO: CollectionDTO,
     parentCollectionId = 'root'
-  ): Promise<void> {
+  ): Promise<number> {
     const dataverseContacts = collectionDTO.contacts.map((contact) => ({
       contactEmail: contact
     }))
@@ -35,7 +35,7 @@ export class CollectionsRepository extends ApiRepository implements ICollections
     }
 
     return this.doPost(`/${this.collectionsResourceName}/${parentCollectionId}`, requestBody)
-      .then(() => undefined)
+      .then((response) => response.data.data.id)
       .catch((error) => {
         throw error
       })

test/integration/collections/CollectionsRepository.test.ts

@@ -90,7 +90,8 @@ describe('CollectionsRepository', () => {
   describe('createCollection', () => {
     test('should create collection in root when no parent collection is set', async () => {
       const newCollectionDTO = createCollectionDTO()
-      await sut.createCollection(newCollectionDTO)
+      const actual = await sut.createCollection(newCollectionDTO)
+      expect(typeof actual).toBe('number')
     })
   })
 })

test/unit/collections/CreateCollection.test.ts

@@ -5,15 +5,16 @@ import { createCollectionDTO } from '../../testHelpers/collections/collectionHel
 
 describe('execute', () => {
   const testCollectionDTO = createCollectionDTO()
+  const testCollectionId = 1
 
   test('should return undefined on repository success', async () => {
     const collectionRepositoryStub: ICollectionsRepository = {} as ICollectionsRepository
-    collectionRepositoryStub.createCollection = jest.fn().mockResolvedValue(undefined)
+    collectionRepositoryStub.createCollection = jest.fn().mockResolvedValue(testCollectionId)
     const testCreateCollection = new CreateCollection(collectionRepositoryStub)
 
     const actual = await testCreateCollection.execute(testCollectionDTO)
 
-    expect(actual).toEqual(undefined)
+    expect(actual).toEqual(testCollectionId)
   })
 
   test('should return error result on repository error', async () => {