Fixed: CollectionType enum definition

Author: GPortas

src/collections/domain/dtos/CollectionDTO.ts

@@ -6,13 +6,13 @@ export interface CollectionDTO {
 }
 
 export enum CollectionType {
-  RESEARCHERS,
-  RESEARCH_PROJECTS,
-  JOURNALS,
-  ORGANIZATIONS_INSTITUTIONS,
-  TEACHING_COURSES,
-  UNCATEGORIZED,
-  LABORATORY,
-  RESEARCH_GROUP,
-  DEPARTMENT
+  RESEARCHERS = 'RESEARCHERS',
+  RESEARCH_PROJECTS = 'RESEARCH_PROJECTS',
+  JOURNALS = 'JOURNALS',
+  ORGANIZATIONS_INSTITUTIONS = 'ORGANIZATIONS_INSTITUTIONS',
+  TEACHING_COURSES = 'TEACHING_COURSES',
+  UNCATEGORIZED = 'UNCATEGORIZED',
+  LABORATORY = 'LABORATORY',
+  RESEARCH_GROUP = 'RESEARCH_GROUP',
+  DEPARTMENT = 'DEPARTMENT'
 }

src/collections/domain/repositories/ICollectionsRepository.ts

@@ -3,5 +3,8 @@ import { Collection } from '../models/Collection'
 
 export interface ICollectionsRepository {
   getCollection(collectionIdOrAlias: number | string): Promise<Collection>
-  createCollection(collectionDTO: CollectionDTO, parentCollectionId: number | string): Promise<number>
+  createCollection(
+    collectionDTO: CollectionDTO,
+    parentCollectionId: number | string
+  ): Promise<number>
 }

src/collections/domain/useCases/CreateCollection.ts

@@ -13,7 +13,10 @@ export class CreateCollection implements UseCase<number> {
   /**
    * TODO
    */
-  async execute(newCollection: CollectionDTO, parentCollectionId: number | string = ROOT_COLLECTION_ALIAS): Promise<number> {
+  async execute(
+    newCollection: CollectionDTO,
+    parentCollectionId: number | string = ROOT_COLLECTION_ALIAS
+  ): Promise<number> {
     return await this.collectionsRepository.createCollection(newCollection, parentCollectionId)
   }
 }

src/collections/infra/repositories/CollectionsRepository.ts

@@ -5,9 +5,9 @@ import { Collection, ROOT_COLLECTION_ALIAS } from '../../domain/models/Collectio
 import { CollectionDTO } from '../../domain/dtos/CollectionDTO'
 
 export interface NewCollectionRequestPayload {
-  alias: string,
-  name: string,
-  dataverseContacts: NewCollectionContactRequestPayload[],
+  alias: string
+  name: string
+  dataverseContacts: NewCollectionContactRequestPayload[]
   dataverseType: string
 }
 
@@ -34,9 +34,11 @@ export class CollectionsRepository extends ApiRepository implements ICollections
     collectionDTO: CollectionDTO,
     parentCollectionId: number | string = ROOT_COLLECTION_ALIAS
   ): Promise<number> {
-    const dataverseContacts: NewCollectionContactRequestPayload[] = collectionDTO.contacts.map((contact) => ({
-      contactEmail: contact
-    }))
+    const dataverseContacts: NewCollectionContactRequestPayload[] = collectionDTO.contacts.map(
+      (contact) => ({
+        contactEmail: contact
+      })
+    )
 
     const requestBody: NewCollectionRequestPayload = {
       alias: collectionDTO.alias,

test/integration/collections/CollectionsRepository.test.ts

@@ -102,7 +102,10 @@ describe('CollectionsRepository', () => {
     })
 
     test('should create collection in parent collection when parent collection is set', async () => {
-      const actual = await sut.createCollection(createCollectionDTO(testCreateCollectionAlias2), testCollectionId)
+      const actual = await sut.createCollection(
+        createCollectionDTO(testCreateCollectionAlias2),
+        testCollectionId
+      )
       expect(typeof actual).toBe('number')
     })
 
@@ -111,9 +114,12 @@ describe('CollectionsRepository', () => {
         `[404] Can't find dataverse with identifier='${TestConstants.TEST_DUMMY_COLLECTION_ID}'`
       )
       const testCreateCollectionAlias3 = 'createCollection-test-3'
-      await expect(sut.createCollection(createCollectionDTO(testCreateCollectionAlias3), TestConstants.TEST_DUMMY_COLLECTION_ID)).rejects.toThrow(
-        expectedError
-      )
+      await expect(
+        sut.createCollection(
+          createCollectionDTO(testCreateCollectionAlias3),
+          TestConstants.TEST_DUMMY_COLLECTION_ID
+        )
+      ).rejects.toThrow(expectedError)
     })
   })
 })

test/integration/files/DirectUploadClient.test.ts

@@ -22,7 +22,7 @@ import {
 } from '../../testHelpers/files/filesHelper'
 import { FileUploadCancelError } from '../../../src/files/infra/clients/errors/FileUploadCancelError'
 
-describe.skip('DirectUploadClient', () => {
+describe('DirectUploadClient', () => {
   const testCollectionAlias = 'directUploadTestCollection'
   let testDataset1Ids: CreatedDatasetIdentifiers
   let testDataset2Ids: CreatedDatasetIdentifiers

test/testHelpers/collections/collectionHelper.ts

@@ -103,7 +103,7 @@ export async function setStorageDriverViaApi(
   }
 }
 
-export const createCollectionDTO = (alias: string = 'test-collection'): CollectionDTO => {
+export const createCollectionDTO = (alias = 'test-collection'): CollectionDTO => {
   return {
     alias: alias,
     name: 'Test Collection',

test/unit/collections/CollectionsRepository.test.ts

@@ -30,7 +30,7 @@ describe('CollectionsRepository', () => {
       DataverseApiAuthMechanism.API_KEY,
       TestConstants.TEST_DUMMY_API_KEY
     )
-    
+
     jest.clearAllMocks()
   })
 
@@ -116,18 +116,20 @@ describe('CollectionsRepository', () => {
 
   describe('createCollection', () => {
     const testNewCollection = createCollectionDTO()
-    
+
     const testCreatedCollectionId = 1
     const testCreateCollectionResponse = {
       data: {
         status: 'OK',
         data: {
-          id: testCreatedCollectionId,
+          id: testCreatedCollectionId
         }
       }
     }
 
-    const expectedNewCollectionRequestPayloadJson = JSON.stringify(createNewCollectionRequestPayload())
+    const expectedNewCollectionRequestPayloadJson = JSON.stringify(
+      createNewCollectionRequestPayload()
+    )
     const expectedApiEndpoint = `${TestConstants.TEST_API_URL}/dataverses/root`
 
     test('should call the API with a correct request payload', async () => {
@@ -160,9 +162,7 @@ describe('CollectionsRepository', () => {
       jest.spyOn(axios, 'post').mockRejectedValue(TestConstants.TEST_ERROR_RESPONSE)
 
       let error = undefined as unknown as WriteError
-      await sut
-        .createCollection(testNewCollection)
-        .catch((e) => (error = e))
+      await sut.createCollection(testNewCollection).catch((e) => (error = e))
 
       expect(axios.post).toHaveBeenCalledWith(
         expectedApiEndpoint,