Skip to content

Commit d06e2cb

Browse files
committed
fix: use mapper and correct test
1 parent 4405fc0 commit d06e2cb

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

src/licenses/infra/repositories/LicensesRepository.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
import { ApiRepository } from '../../../core/infra/repositories/ApiRepository'
22
import { ILicensesRepository } from '../../domain/repositories/ILicensesRepository'
33
import { License } from '../../domain/models/License'
4+
import { transformPayloadToLicense } from '../../domain/repositories/transformers/licenseTransformers'
45

56
export class LicensesRepository extends ApiRepository implements ILicensesRepository {
67
private readonly licensesResourceName: string = 'licenses'
78

89
public async getAvailableStandardLicenses(): Promise<License[]> {
910
return this.doGet(this.buildApiEndpoint(this.licensesResourceName))
10-
.then((response) => response.data.data)
11+
.then((response) => transformPayloadToLicense(response))
1112
.catch((error) => {
1213
throw error
1314
})

test/functional/licenses/GetAvailableStandardLicenses.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ describe('getAvailableStandardLicenses', () => {
1414

1515
test('should return available standard license terms', async () => {
1616
const actualLicenses: License[] = await getAvailableStandardLicenses.execute()
17-
const expectedLicenses = [
17+
const expectedLicenses: License[] = [
1818
{
1919
id: 1,
2020
name: 'CC0 1.0',
2121
shortDescription: 'Creative Commons CC0 1.0 Universal Public Domain Dedication.',
2222
uri: 'http://creativecommons.org/publicdomain/zero/1.0',
23-
iconUrl: 'https://licensebuttons.net/p/zero/1.0/88x31.png',
23+
iconUri: 'https://licensebuttons.net/p/zero/1.0/88x31.png',
2424
active: true,
2525
isDefault: true,
2626
sortOrder: 0,
@@ -34,7 +34,7 @@ describe('getAvailableStandardLicenses', () => {
3434
name: 'CC BY 4.0',
3535
shortDescription: 'Creative Commons Attribution 4.0 International License.',
3636
uri: 'http://creativecommons.org/licenses/by/4.0',
37-
iconUrl: 'https://licensebuttons.net/l/by/4.0/88x31.png',
37+
iconUri: 'https://licensebuttons.net/l/by/4.0/88x31.png',
3838
active: true,
3939
isDefault: false,
4040
sortOrder: 2,

test/integration/licenses/LicensesRepository.test.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {
44
} from '../../../src/core/infra/repositories/ApiConfig'
55
import { TestConstants } from '../../testHelpers/TestConstants'
66
import { LicensesRepository } from '../../../src/licenses/infra/repositories/LicensesRepository'
7+
import { License } from '../../../src/licenses/domain/models/License'
78

89
describe('LicensesRepository', () => {
910
const sut: LicensesRepository = new LicensesRepository()
@@ -20,13 +21,13 @@ describe('LicensesRepository', () => {
2021
test('should return list of available standard license terms', async () => {
2122
const actual = await sut.getAvailableStandardLicenses()
2223

23-
const licenses = [
24+
const licenses: License[] = [
2425
{
2526
id: 1,
2627
name: 'CC0 1.0',
2728
shortDescription: 'Creative Commons CC0 1.0 Universal Public Domain Dedication.',
2829
uri: 'http://creativecommons.org/publicdomain/zero/1.0',
29-
iconUrl: 'https://licensebuttons.net/p/zero/1.0/88x31.png',
30+
iconUri: 'https://licensebuttons.net/p/zero/1.0/88x31.png',
3031
active: true,
3132
isDefault: true,
3233
sortOrder: 0,
@@ -40,7 +41,7 @@ describe('LicensesRepository', () => {
4041
name: 'CC BY 4.0',
4142
shortDescription: 'Creative Commons Attribution 4.0 International License.',
4243
uri: 'http://creativecommons.org/licenses/by/4.0',
43-
iconUrl: 'https://licensebuttons.net/l/by/4.0/88x31.png',
44+
iconUri: 'https://licensebuttons.net/l/by/4.0/88x31.png',
4445
active: true,
4546
isDefault: false,
4647
sortOrder: 2,

0 commit comments

Comments
 (0)