fix: some tests

Author: ChengShi-1

docs/useCases.md

@@ -862,8 +862,6 @@ _See [use case](../src/datasets/domain/useCases/GetDatasetDownloadCount.ts) impl
 The `datasetId` parameter is a number for numeric identifiers.
 The `includeMDC` parameter is optional.
 
-Note:
-
 - Setting `includeMDC` to True will ignore the `MDCStartDate` setting and return a total count.
 - If MDC isn't enabled, the download count will return a total count, without `MDCStartDate`.
 - If MDC is enabled but the `includeMDC` is false, the count will be limited to the time before `MDCStartDate`

src/datasets/infra/repositories/DatasetsRepository.ts

@@ -249,7 +249,7 @@ export class DatasetsRepository extends ApiRepository implements IDatasetsReposi
       true,
       queryParams
     )
-      .then((response) => response.data.downloadCount)
+      .then((response) => response.data)
       .catch((error) => {
         throw error
       })

test/integration/datasets/DatasetsRepository.test.ts

@@ -1108,6 +1108,28 @@ describe('DatasetsRepository', () => {
 
       await deletePublishedDatasetViaApi(testDatasetIds.persistentId)
     })
+  })
+
+  describe('getDatasetDownloadCount', () => {
+    test('should return download count for a dataset', async () => {
+      const testDatasetIds = await createDataset.execute(TestConstants.TEST_NEW_DATASET_DTO)
+      await publishDatasetViaApi(testDatasetIds.numericId)
+      await waitForNoLocks(testDatasetIds.numericId, 10)
+      const actual = await sut.getDatasetDownloadCount(testDatasetIds.numericId)
+
+      expect(actual.downloadCount).toBe(0)
+    })
+
+    test('should return download count including MDC data', async () => {
+      const testDatasetIds = await createDataset.execute(TestConstants.TEST_NEW_DATASET_DTO)
+      await publishDatasetViaApi(testDatasetIds.numericId)
+      await waitForNoLocks(testDatasetIds.numericId, 10)
+
+      const actual = await sut.getDatasetDownloadCount(testDatasetIds.numericId, true)
+
+      expect(actual.downloadCount).toBe(0)
+    })
+
     test('should return error when dataset does not exist', async () => {
       await expect(sut.getDatasetDownloadCount(nonExistentTestDatasetId)).rejects.toBeInstanceOf(
         ReadError
@@ -1121,32 +1143,5 @@ describe('DatasetsRepository', () => {
         expectedError
       )
     })
-
-    describe('getDatasetDownloadCount', () => {
-      test('should return download count for a dataset', async () => {
-        const testDatasetIds = await createDataset.execute(TestConstants.TEST_NEW_DATASET_DTO)
-        const fileMetadata = {
-          description: 'test description',
-          directoryLabel: 'directoryLabel',
-          categories: ['category1', 'category2']
-        }
-        await uploadFileViaApi(testDatasetIds.numericId, testTextFile1Name, fileMetadata)
-        await publishDatasetViaApi(testDatasetIds.numericId)
-        await waitForNoLocks(testDatasetIds.numericId, 10)
-        const actual = await sut.getDatasetDownloadCount(testDatasetIds.numericId)
-
-        expect(actual.downloadCount).toBe(0)
-      })
-
-      test('should return download count including MDC data', async () => {
-        const testDatasetIds = await createDataset.execute(TestConstants.TEST_NEW_DATASET_DTO)
-        await publishDatasetViaApi(testDatasetIds.numericId)
-        await waitForNoLocks(testDatasetIds.numericId, 10)
-
-        const actual = await sut.getDatasetDownloadCount(testDatasetIds.numericId, true)
-
-        expect(actual.downloadCount).toBe(0)
-      })
-    })
   })
 })

test/unit/datasets/DatasetsRepository.test.ts

@@ -1030,7 +1030,7 @@ describe('DatasetsRepository', () => {
 
       expect(axios.get).toHaveBeenCalledWith(
         `${TestConstants.TEST_API_URL}/datasets/${testDatasetModel.id}/download/count`,
-        TestConstants.TEST_EXPECTED_UNAUTHENTICATED_REQUEST_CONFIG
+        TestConstants.TEST_EXPECTED_AUTHENTICATED_REQUEST_CONFIG_API_KEY
       )
       expect(actual).toStrictEqual(testDatasetDownloadCount)
     })
@@ -1043,7 +1043,7 @@ describe('DatasetsRepository', () => {
 
       expect(axios.get).toHaveBeenCalledWith(
         `${TestConstants.TEST_API_URL}/datasets/${testDatasetModel.id}/download/count`,
-        TestConstants.TEST_EXPECTED_UNAUTHENTICATED_REQUEST_CONFIG
+        TestConstants.TEST_EXPECTED_AUTHENTICATED_REQUEST_CONFIG_API_KEY
       )
       expect(error).toBeInstanceOf(Error)
     })