refactor: only stringify objects types

Author: g-saracca

src/core/infra/repositories/ApiRepository.ts

@@ -20,7 +20,7 @@ export abstract class ApiRepository {
 
   public async doPost(
     apiEndpoint: string,
-    data: string | object,
+    data: string | object | boolean,
     queryParams: object = {},
     contentType: string = ApiConstants.CONTENT_TYPE_APPLICATION_JSON
   ): Promise<AxiosResponse> {
@@ -29,7 +29,7 @@ export abstract class ApiRepository {
 
   public async doPut(
     apiEndpoint: string,
-    data: string | object,
+    data: string | object | boolean,
     queryParams: object = {},
     contentType: string = ApiConstants.CONTENT_TYPE_APPLICATION_JSON
   ): Promise<AxiosResponse> {
@@ -70,12 +70,20 @@ export abstract class ApiRepository {
   private async doRequest(
     method: 'post' | 'put',
     apiEndpoint: string,
-    data: string | object,
+    data: string | object | boolean,
     queryParams: object = {},
     contentType: string = ApiConstants.CONTENT_TYPE_APPLICATION_JSON
   ): Promise<AxiosResponse> {
-    const requestData =
-      contentType == ApiConstants.CONTENT_TYPE_APPLICATION_JSON ? JSON.stringify(data) : data
+    let requestData = data
+
+    if (contentType === ApiConstants.CONTENT_TYPE_APPLICATION_JSON) {
+      if (typeof data === 'object') {
+        requestData = JSON.stringify(data)
+      } else if (typeof data === 'boolean') {
+        requestData = data.toString()
+      }
+    }
+
     const requestUrl = buildRequestUrl(apiEndpoint)
     const requestConfig = buildRequestConfig(true, queryParams, contentType)
 

test/unit/auth/AuthRepository.test.ts

@@ -35,7 +35,7 @@ describe('logout', () => {
 
     expect(axios.post).toHaveBeenCalledWith(
       expectedApiEndpoint,
-      JSON.stringify(''),
+      '',
       TestConstants.TEST_EXPECTED_AUTHENTICATED_REQUEST_CONFIG_API_KEY
     )
 
@@ -46,7 +46,7 @@ describe('logout', () => {
 
     expect(axios.post).toHaveBeenCalledWith(
       expectedApiEndpoint,
-      JSON.stringify(''),
+      '',
       TestConstants.TEST_EXPECTED_AUTHENTICATED_REQUEST_CONFIG_SESSION_COOKIE
     )
   })
@@ -59,7 +59,7 @@ describe('logout', () => {
 
     expect(axios.post).toHaveBeenCalledWith(
       `${TestConstants.TEST_API_URL}/logout`,
-      JSON.stringify(''),
+      '',
       TestConstants.TEST_EXPECTED_AUTHENTICATED_REQUEST_CONFIG_API_KEY
     )
     expect(error).toBeInstanceOf(Error)