feat: update to delete draft dataset

Author: ChengShi-1

docs/useCases.md

@@ -838,9 +838,9 @@ The `version` parameter should be a string or a [DatasetNotNumberedVersion](../s
 
 You cannot deaccession a dataset more than once. If you call this endpoint twice for the same dataset version, you will get a not found error on the second call, since the dataset you are looking for will no longer be published since it is already deaccessioned.
 
-#### Delete a Dataset
+#### Delete a Draft Dataset
 
-Delete a Dataset, given its identifier.
+Delete a Draft Dataset, given its identifier.
 
 ##### Example call:
 

src/datasets/domain/useCases/DeleteDataset.ts

@@ -9,7 +9,7 @@ export class DeleteDataset implements UseCase<void> {
   }
 
   /**
-   * Delete a Dataset
+   * Delete a Draft Dataset
    *
    * @param {number | string} [datasetId] - The dataset identifier, which can be a string (for persistent identifiers), or a number (for numeric identifiers).
    */

src/datasets/infra/repositories/DatasetsRepository.ts

@@ -279,7 +279,9 @@ export class DatasetsRepository extends ApiRepository implements IDatasetsReposi
   }
 
   public async deleteDataset(datasetId: string | number): Promise<void> {
-    return this.doDelete(this.buildApiEndpoint(this.datasetsResourceName, undefined, datasetId))
+    return this.doDelete(
+      this.buildApiEndpoint(this.datasetsResourceName, 'versions/:draft', datasetId)
+    )
       .then(() => undefined)
       .catch((error) => {
         throw error

test/functional/datasets/DeleteDataset.test.ts

@@ -1,13 +1,7 @@
-import {
-  createDataset,
-  publishDataset,
-  VersionUpdateType,
-  deleteDataset
-} from '../../../src/datasets'
+import { createDataset, deleteDataset } from '../../../src/datasets'
 import { ApiConfig, WriteError } from '../../../src'
 import { TestConstants } from '../../testHelpers/TestConstants'
 import { DataverseApiAuthMechanism } from '../../../src/core/infra/repositories/ApiConfig'
-import { waitForNoLocks } from '../../testHelpers/datasets/datasetHelper'
 
 const testDataset = {
   license: {
@@ -56,24 +50,7 @@ describe('execute', () => {
     )
   })
 
-  test('should delete a dataset when it is published successfully', async () => {
-    const createdDatasetIdentifiers = await createDataset.execute(testDataset)
-
-    const response = await publishDataset.execute(
-      createdDatasetIdentifiers.persistentId,
-      VersionUpdateType.MAJOR
-    )
-
-    await waitForNoLocks(createdDatasetIdentifiers.numericId, 10)
-
-    expect(response).toBeUndefined()
-
-    const actual = await deleteDataset.execute(createdDatasetIdentifiers.numericId)
-
-    expect(actual).toBeUndefined()
-  })
-
-  test('should delete a dataset when it is not published successfully', async () => {
+  test('should delete a dataset when it is draft successfully', async () => {
     const createdDatasetIdentifiers = await createDataset.execute(testDataset)
 
     const actual = await deleteDataset.execute(createdDatasetIdentifiers.numericId)

test/integration/datasets/DatasetsRepository.test.ts

@@ -1356,26 +1356,6 @@ describe('DatasetsRepository', () => {
       ).rejects.toThrow(expectedError)
     })
 
-    test('should delete a published dataset', async () => {
-      const testDatasetIds = await createDataset.execute(TestConstants.TEST_NEW_DATASET_DTO)
-
-      await publishDatasetViaApi(testDatasetIds.numericId)
-
-      await waitForNoLocks(testDatasetIds.numericId, 10)
-
-      const actual = await sut.deleteDataset(testDatasetIds.numericId)
-
-      expect(actual).toBeUndefined()
-
-      const expectedError = new ReadError(
-        `[404] Dataset with ID ${testDatasetIds.numericId} not found.`
-      )
-
-      await expect(
-        sut.getDataset(testDatasetIds.numericId, DatasetNotNumberedVersion.LATEST, false, false)
-      ).rejects.toThrow(expectedError)
-    })
-
     test('should return error when dataset does not exist', async () => {
       const expectedError = new WriteError(
         `[404] Dataset with ID ${nonExistentTestDatasetId} not found.`