Added: enhanced IT coverage for getCollection and createCollection

Author: GPortas

test/environment/.env

@@ -1,6 +1,6 @@
 POSTGRES_VERSION=13
 DATAVERSE_DB_USER=dataverse
 SOLR_VERSION=9.3.0
-DATAVERSE_IMAGE_REGISTRY=docker.io
-DATAVERSE_IMAGE_TAG=unstable
+DATAVERSE_IMAGE_REGISTRY=ghcr.io
+DATAVERSE_IMAGE_TAG=10633-create-collection-api-ext
 DATAVERSE_BOOTSTRAP_TIMEOUT=5m

test/integration/collections/CollectionsRepository.test.ts

@@ -41,6 +41,13 @@ describe('CollectionsRepository', () => {
       test('should return the root collection of the Dataverse installation if no parameter is passed AS `root`', async () => {
         const actual = await sut.getCollection()
         expect(actual.alias).toBe(ROOT_COLLECTION_ALIAS)
+        expect(actual.id).toBe(1)
+        expect(actual.name).toBe('Root')
+        expect(actual.alias).toBe('root')
+        expect(actual.isReleased).toBe(true)
+        expect(actual.affiliation).toBe(undefined)
+        expect(actual.description).toBe('The root dataverse.')
+        expect(actual.inputLevels).toBe(undefined)
       })
 
       test('should return isReleased is true for root collection', async () => {
@@ -97,16 +104,33 @@ describe('CollectionsRepository', () => {
     })
 
     test('should create collection in root when no parent collection is set', async () => {
-      const actual = await sut.createCollection(createCollectionDTO(testCreateCollectionAlias1))
-      expect(typeof actual).toBe('number')
+      const newCollectionDTO = createCollectionDTO(testCreateCollectionAlias1)
+      const actualId = await sut.createCollection(newCollectionDTO)
+      expect(typeof actualId).toBe('number')
+
+      const createdCollection = await sut.getCollection(actualId)
+
+      expect(createdCollection.id).toBe(actualId)
+      expect(createdCollection.alias).toBe(newCollectionDTO.alias)
+      expect(createdCollection.name).toBe(newCollectionDTO.name)
+      expect(createdCollection.affiliation).toBe(newCollectionDTO.affiliation)
+      expect(createdCollection.isPartOf.type).toBe('DATAVERSE')
+      expect(createdCollection.isPartOf.displayName).toBe('Root')
+      expect(createdCollection.isPartOf.identifier).toBe('root')
+
+      expect(createdCollection.inputLevels?.length).toBe(1)
+      const inputLevel = createdCollection.inputLevels?.[0]
+      expect(inputLevel?.datasetFieldName).toBe('geographicCoverage')
+      expect(inputLevel?.include).toBe(true)
+      expect(inputLevel?.required).toBe(true)
     })
 
     test('should create collection in parent collection when parent collection is set', async () => {
-      const actual = await sut.createCollection(
+      const actualId = await sut.createCollection(
         createCollectionDTO(testCreateCollectionAlias2),
         testCollectionId
       )
-      expect(typeof actual).toBe('number')
+      expect(typeof actualId).toBe('number')
     })
 
     test('should return error when parent collection does not exist', async () => {

test/unit/collections/GetCollectionFacets.test.ts

@@ -7,18 +7,18 @@ describe('execute', () => {
     const testFacets = ['test1', 'test2']
     const collectionRepositoryStub: ICollectionsRepository = {} as ICollectionsRepository
     collectionRepositoryStub.getCollectionFacets = jest.fn().mockResolvedValue(testFacets)
-    const testGetCollection = new GetCollectionFacets(collectionRepositoryStub)
+    const testGetCollectionFacets = new GetCollectionFacets(collectionRepositoryStub)
 
-    const actual = await testGetCollection.execute(1)
+    const actual = await testGetCollectionFacets.execute(1)
 
     expect(actual).toEqual(testFacets)
   })
 
   test('should return error result on repository error', async () => {
     const collectionRepositoryStub: ICollectionsRepository = {} as ICollectionsRepository
     collectionRepositoryStub.getCollectionFacets = jest.fn().mockRejectedValue(new ReadError())
-    const testGetCollection = new GetCollectionFacets(collectionRepositoryStub)
+    const testGetCollectionFacets = new GetCollectionFacets(collectionRepositoryStub)
 
-    await expect(testGetCollection.execute(1)).rejects.toThrow(ReadError)
+    await expect(testGetCollectionFacets.execute(1)).rejects.toThrow(ReadError)
   })
 })