Skip to content

Commit f2cd4eb

Browse files
committed
feat: make categories optional and add testcase
1 parent 724e4bc commit f2cd4eb

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

src/files/domain/models/FilePreview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export interface FilePreview {
2323
releaseOrCreateDate: Date
2424
restricted: boolean
2525
canDownloadFile: boolean
26-
categories: string[]
26+
categories?: string[]
2727
tabularTags?: string[]
2828
variables?: number
2929
observations?: number

src/files/infra/repositories/transformers/FilePreviewPayload.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export interface FilePreviewPayload {
2121
releaseOrCreateDate: string
2222
restricted: boolean
2323
canDownloadFile: boolean
24-
categories: string[]
24+
categories?: string[]
2525
tabularTags?: string[]
2626
variables?: number
2727
observations?: number

src/files/infra/repositories/transformers/filePreviewTransformers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export const transformFilePreviewPayloadToFilePreview = (
3939
releaseOrCreateDate: new Date(filePreviewPayload.releaseOrCreateDate),
4040
restricted: filePreviewPayload.restricted,
4141
canDownloadFile: filePreviewPayload.canDownloadFile,
42-
categories: filePreviewPayload.categories,
42+
...(filePreviewPayload.categories && { categories: filePreviewPayload.categories }),
4343
...(filePreviewPayload.tabularTags && {
4444
tabularTags: filePreviewPayload.tabularTags
4545
}),

test/integration/collections/CollectionsRepository.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ describe('CollectionsRepository', () => {
293293

294294
const expectedFileMd5 = '68b22040025784da775f55cfcb6dee2e'
295295
const expectedDatasetCitationFragment =
296-
'Admin, Dataverse; Owner, Dataverse, 2024, "Dataset created using the createDataset use case'
296+
'Admin, Dataverse; Owner, Dataverse, 2025, "Dataset created using the createDataset use case'
297297
const expectedDatasetDescription = 'Dataset created using the createDataset use case'
298298
const expectedFileName = 'test-file-1.txt'
299299
const expectedCollectionsName = 'Scientific Research'
@@ -378,6 +378,8 @@ describe('CollectionsRepository', () => {
378378
expect(actualFilePreview.url).not.toBeUndefined()
379379
expect(actualFilePreview.releaseOrCreateDate).not.toBeUndefined()
380380
expect(actualFilePreview.type).toBe(CollectionItemType.FILE)
381+
expect(actualFilePreview.restricted).toBe(false)
382+
expect(actualFilePreview.canDownloadFile).toBe(true)
381383

382384
expect(actualDatasetPreview.title).toBe(expectedDatasetDescription)
383385
expect(actualDatasetPreview.citation).toContain(expectedDatasetCitationFragment)

test/testHelpers/files/filePreviewHelper.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ export const createFilePreviewModel = (): FilePreview => {
2727
publicationStatuses: [PublicationStatus.Published],
2828
releaseOrCreateDate: new Date('2023-05-15T08:21:01Z'),
2929
canDownloadFile: true,
30-
restricted: false,
31-
categories: []
30+
restricted: false
3231
}
3332
return filePreviewModel
3433
}
@@ -58,7 +57,6 @@ export const createFilePreviewPayload = (): FilePreviewPayload => {
5857
publicationStatuses: ['Published'],
5958
releaseOrCreateDate: '2023-05-15T08:21:01Z',
6059
canDownloadFile: true,
61-
restricted: false,
62-
categories: []
60+
restricted: false
6361
}
6462
}

0 commit comments

Comments
 (0)