feat: add more testcases

Author: ChengShi-1

docs/useCases.md

@@ -1336,8 +1336,8 @@ const updateFileMetadataDTO = {
   restrict: false
 }
 
-await updateFileMetadata.execute(fileId, updateFileMetadataDTO).then((fileId) => {
-  console.log(`File updated successfully with file ID: ${fileId}`)
+await updateFileMetadata.execute(fileId, updateFileMetadataDTO).then(() => {
+  console.log(`File updated successfully`)
 })
 ```
 
@@ -1360,8 +1360,8 @@ const fileId: number | string = 123
 const categories = ['category 1', 'category 1']
 const replace = true
 
-await updateFileCategories.execute(fileId, categories, replace).then((fileId) => {
-  console.log(`File updated successfully with file ID: ${fileId}`)
+await updateFileCategories.execute(fileId, categories, replace).then(() => {
+  console.log(`File updated successfully`)
 })
 ```
 
@@ -1383,8 +1383,8 @@ import { updateFileTabularTags } from '@iqss/dataverse-client-javascript'
 const fileId: number | string = 123
 const tabularTags = ['Surveys']
 
-await updateFileTabularTags.execute(fileId, tabularTags, replace).then((fileId) => {
-  console.log(`File updated successfully with file ID: ${fileId}`)
+await updateFileTabularTags.execute(fileId, tabularTags, replace).then(() => {
+  console.log(`File updated successfully`)
 })
 ```
 

test/functional/files/UpdateFileCategories.test.ts

@@ -96,6 +96,37 @@ describe('execute', () => {
     }
   })
 
+  test('should not duplicate categories when merging', async () => {
+    const datasetFiles = await getDatasetFiles.execute(testDatasetIds.numericId)
+    const fileId = datasetFiles.files[0].id
+
+    const initialCategories = ['Category 1', 'Category 2']
+    const newCategories = ['Category 2', 'Category 3']
+    const expectedMergedCategories = ['Category 1', 'Category 2', 'Category 3']
+
+    await updateFileCategories.execute(fileId, initialCategories, true)
+    await updateFileCategories.execute(fileId, newCategories, false)
+
+    const fileInfo = (await getFile.execute(fileId, DatasetNotNumberedVersion.LATEST)) as FileModel
+
+    expect(fileInfo.categories?.sort()).toEqual(expectedMergedCategories.sort())
+  })
+
+  test('should replace categories when replace = true', async () => {
+    const datasetFiles = await getDatasetFiles.execute(testDatasetIds.numericId)
+    const fileId = datasetFiles.files[0].id
+
+    const initialCategories = ['Category 1', 'Category 2', 'Category 3']
+    const newCategories = ['Category 4', 'Category 5', 'Category 6']
+
+    await updateFileCategories.execute(fileId, initialCategories, true)
+    await updateFileCategories.execute(fileId, newCategories, true)
+
+    const fileInfo = (await getFile.execute(fileId, DatasetNotNumberedVersion.LATEST)) as FileModel
+
+    expect(fileInfo.categories?.sort()).toEqual(newCategories.sort())
+  })
+
   test('should throw an error when the file id does not exist', async () => {
     let writeError: WriteError | undefined = undefined
     const nonExistentFileId = 5

test/functional/files/UpdateFileTabularTags.test.ts

@@ -97,6 +97,67 @@ describe('execute', () => {
     }
   })
 
+  test('should not duplicate tabular tags when merging', async () => {
+    const datasetFiles = await getDatasetFiles.execute(testDatasetIds.numericId)
+    const fileId = datasetFiles.files[0].id
+
+    const initialTags = ['Survey', 'Panel']
+    const newTags = ['Panel', 'Event']
+    const expectedMergedTags = ['Survey', 'Panel', 'Event']
+
+    await updateFileTabularTags.execute(fileId, initialTags, true)
+    await updateFileTabularTags.execute(fileId, newTags, false)
+
+    const fileInfo = (await getFile.execute(fileId, DatasetNotNumberedVersion.LATEST)) as FileModel
+
+    expect(fileInfo.tabularTags?.sort()).toEqual(expectedMergedTags.sort())
+  })
+
+  test('should replace tabular tags when replace = true', async () => {
+    const datasetFiles = await getDatasetFiles.execute(testDatasetIds.numericId)
+    const fileId = datasetFiles.files[0].id
+
+    const initialTags = ['Survey', 'Panel', 'Event']
+    const newTags = ['Survey', 'Network']
+
+    await updateFileTabularTags.execute(fileId, initialTags, true)
+    await updateFileTabularTags.execute(fileId, newTags, true)
+
+    const fileInfo = (await getFile.execute(fileId, DatasetNotNumberedVersion.LATEST)) as FileModel
+
+    expect(fileInfo.tabularTags?.sort()).toEqual(newTags.sort())
+  })
+
+  test('should throw an error when updating tabular tags on a non-tabular file', async () => {
+    const nonTabularFileName = 'test-file-1.txt'
+
+    try {
+      await uploadFileViaApi(testDatasetIds.numericId, nonTabularFileName)
+    } catch {
+      throw new Error(`Error uploading non-tabular file: ${nonTabularFileName}`)
+    }
+    const datasetFiles = await getDatasetFiles.execute(testDatasetIds.numericId)
+    const matchingFile = datasetFiles.files.find((f) => f.name === nonTabularFileName)
+    if (!matchingFile) {
+      throw new Error('Uploaded non-tabular file not found in dataset')
+    }
+
+    const fileId = matchingFile.id
+
+    let writeError: WriteError | undefined = undefined
+
+    try {
+      await updateFileTabularTags.execute(fileId, ['Survey'], false)
+    } catch (error) {
+      writeError = error as WriteError
+    } finally {
+      expect(writeError).toBeInstanceOf(WriteError)
+      expect(writeError?.message).toEqual(
+        `There was an error when writing the resource. Reason was: [400] This operation is only available for tabular files.`
+      )
+    }
+  })
+
   test('should throw an error when the file id does not exist', async () => {
     let writeError: WriteError | undefined = undefined
     const nonExistentFileId = 5