fix: map linked dataset correctly according to model

Author: g-saracca

src/collections/infra/repositories/transformers/collectionTransformers.ts

@@ -159,7 +159,13 @@ export const transformCollectionLinksResponseToCollectionLinks = (
   const responseDataPayload = response.data.data
   const linkedCollections = responseDataPayload.linkedDataverses
   const collectionsLinkingToThis = responseDataPayload.dataversesLinkingToThis
-  const linkedDatasets = responseDataPayload.linkedDatasets
+  const linkedDatasets = responseDataPayload.linkedDatasets.map(
+    (ld: { identifier: string; title: string }) => ({
+      persistentId: ld.identifier,
+      title: ld.title
+    })
+  )
+
   return {
     linkedCollections,
     collectionsLinkingToThis,

test/integration/collections/CollectionsRepository.test.ts

@@ -2093,16 +2093,18 @@ describe('CollectionsRepository', () => {
     const thirdCollectionAlias = 'getCollectionLinksThird'
     const fourthCollectionAlias = 'getCollectionLinksFourth'
     let childDatasetNumericId: number
+    let childDatasetPersistentId: string
     beforeAll(async () => {
       await createCollectionViaApi(firstCollectionAlias)
       await createCollectionViaApi(secondCollectionAlias)
       await createCollectionViaApi(thirdCollectionAlias)
       await createCollectionViaApi(fourthCollectionAlias)
-      const { numericId: createdId } = await createDataset.execute(
+      const { numericId: createdId, persistentId: createdPid } = await createDataset.execute(
         TestConstants.TEST_NEW_DATASET_DTO,
         fourthCollectionAlias
       )
       childDatasetNumericId = createdId
+      childDatasetPersistentId = createdPid
       await sut.linkCollection(secondCollectionAlias, firstCollectionAlias)
       await sut.linkCollection(firstCollectionAlias, thirdCollectionAlias)
       await sut.linkCollection(firstCollectionAlias, fourthCollectionAlias)
@@ -2131,6 +2133,7 @@ describe('CollectionsRepository', () => {
       expect(collectionLinks.linkedDatasets[0].title).toBe(
         'Dataset created using the createDataset use case'
       )
+      expect(collectionLinks.linkedDatasets[0].persistentId).toBe(childDatasetPersistentId)
     })
 
     test('should return error when collection does not exist', async () => {