implement use case for sending information to contacts#232
Merged
ofahimIQSS merged 14 commits intodevelopfrom Feb 14, 2025
Merged
Conversation
ChengShi-1
added
Size: 3
GPortas
requested changes
Dec 20, 2024
Contributor
GPortas
left a comment
GPortas
left a comment
There was a problem hiding this comment.
The design, layering, and approach are correct, but we should use a different API endpoint for the reasons I mentioned in one of my comments. If there isn't an alternative endpoint in the API, we will need to implement one.
GPortas
reviewed
Feb 10, 2025
Contributor
GPortas
left a comment
GPortas
left a comment
There was a problem hiding this comment.
Looks good! @ChengShi-1
I've added minor suggestions. I think we should always use email addresses under our control for testing, to avoid potential side effects.
Contributor
Author
|
@GPortas Thanks for your reviewing and suggestions:) I made some new changes here, waiting to be reviewed again. |
GPortas
approved these changes
Feb 12, 2025
Contributor
GPortas
left a comment
GPortas
left a comment
There was a problem hiding this comment.
Looks good to me. Approving!
Contributor
|
tests passing - merging PR |
ofahimIQSS
deleted the
231-implement-use-case-for-sending-information-to-contacts
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implement the use case allowing users to send feedback to contacts of collection or dataset.
The use case should:
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
visually inspect and run tests on it
Is there a release notes update needed for this change?:
Additional documentation: