Update file restriction fields and tabular information to the file preview#234
Merged
ofahimIQSS merged 5 commits intodevelopfrom Jan 10, 2025
Conversation
ekraffmiller
reviewed
Jan 6, 2025
Contributor
ekraffmiller
left a comment
There was a problem hiding this comment.
Looks good! I just had some suggestions for the CollectionRespository tests
ekraffmiller
approved these changes
Jan 8, 2025
Contributor
ekraffmiller
left a comment
There was a problem hiding this comment.
looks good, approved!
Contributor
|
Visually inspected code, tests are passing. Merging PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In collection page, some missing information is needed for every card item, including the lock icon, tags(categories), and tabular data info, so we need update in FilePreview model.
New fields include:
In datasetPreview, new field added
image_url: stringWhich issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Run all testcases and visually inspect
Is there a release notes update needed for this change?:
Additional documentation: