Add flake8 for style checking and improve adherence to PEP8

Author: rliebz

.travis.yml

@@ -7,4 +7,5 @@ python:
 install:
   - pip install -U .
 script:
+  - flake8 .
   - py.test

dataverse/connection.py

@@ -13,7 +13,11 @@ class Connection(object):
     def __init__(self, host, token):
         self.token = token
         self.host = host
-        self.sd_uri = 'https://{host}/dvn/api/data-deposit/v1.1/swordv2/service-document'.format(host=self.host)
+
+        self.base_url = 'https://{0}'.format(self.host)
+        self.native_base_url = '{0}/api/v1'.format(self.base_url)
+        self.sword_base_url = '{0}/dvn/api/data-deposit/v1.1/swordv2'.format(self.base_url)
+        self.sd_uri = '{0}/service-document'.format(self.sword_base_url)
         self._service_document = None
 
         self.get_service_document()
@@ -38,7 +42,7 @@ def get_service_document(self, refresh=False):
 
     def create_dataverse(self, alias, name, email, parent=':root'):
         resp = requests.post(
-            'https://{0}/api/dataverses/{1}'.format(self.host, parent),
+            '{0}/dataverses/{1}'.format(self.native_base_url, parent),
             json={
                 'alias': alias,
                 'name': name,
@@ -48,26 +52,36 @@ def create_dataverse(self, alias, name, email, parent=':root'):
         )
 
         if resp.status_code == 404:
-            raise exceptions.DataverseNotFoundError('Dataverse {0} was not found.'.format(parent))
+            raise exceptions.DataverseNotFoundError(
+                'Dataverse {0} was not found.'.format(parent)
+            )
         elif resp.status_code != 201:
-            raise exceptions.OperationFailedError('{0} Dataverse could not be created.'.format(name))
+            raise exceptions.OperationFailedError(
+                '{0} Dataverse could not be created.'.format(name)
+            )
 
         self.get_service_document(refresh=True)
         return self.get_dataverse(alias)
 
     def delete_dataverse(self, dataverse):
 
         resp = requests.delete(
-            'https://{0}/api/dataverses/{1}'.format(self.host, dataverse.alias),
+            '{0}/dataverses/{1}'.format(self.native_base_url, dataverse.alias),
             params={'key': self.token},
         )
 
         if resp.status_code == 401:
-            raise exceptions.UnauthorizedError('Delete Dataverse unauthorized.')
+            raise exceptions.UnauthorizedError(
+                'Delete Dataverse {0} unauthorized.'.format(dataverse.alias)
+            )
         elif resp.status_code == 404:
-            raise exceptions.DataverseNotFoundError('Dataverse {0} was not found.'.format(dataverse.alias))
+            raise exceptions.DataverseNotFoundError(
+                'Dataverse {0} was not found.'.format(dataverse.alias)
+            )
         elif resp.status_code != 200:
-            raise exceptions.OperationFailedError('Dataverse {0} could not be deleted.'.format(dataverse.alias))
+            raise exceptions.OperationFailedError(
+                'Dataverse {0} could not be deleted.'.format(dataverse.alias)
+            )
 
         self.get_service_document(refresh=True)
 

dataverse/dataset.py

@@ -185,16 +185,18 @@ def get_metadata(self, version='latest', refresh=False):
         if not self.dataverse:
             raise NoContainerError('This dataset has not been added to a Dataverse.')
 
-        url = 'https://{0}/api/datasets/{1}/versions/:{2}'.format(
-            self.connection.host,
+        url = '{0}/datasets/{1}/versions/:{2}'.format(
+            self.connection.native_base_url,
             self.id,
             version,
         )
 
         resp = requests.get(url, params={'key': self.connection.token})
 
         if resp.status_code == 404:
-            raise VersionJsonNotFoundError('JSON metadata could not be found for this version.')
+            raise VersionJsonNotFoundError(
+                'JSON metadata could not be found for this version.'
+            )
         elif resp.status_code != 200:
             raise ConnectionError('JSON metadata could not be retrieved.')
 
@@ -203,7 +205,11 @@ def get_metadata(self, version='latest', refresh=False):
 
         # Update corresponding version metadata if retrieving 'latest'
         if version == 'latest':
-            latest_version = 'latest-published' if metadata['versionState'] == 'RELEASED' else 'draft'
+            latest_version = (
+                'latest-published'
+                if metadata['versionState'] == 'RELEASED'
+                else 'draft'
+            )
             self._metadata[latest_version] = metadata
 
         return metadata
@@ -214,8 +220,8 @@ def update_metadata(self, metadata):
 
         :param dict metadata: json retrieved from `get_version_metadata`
         """
-        url = 'https://{0}/api/datasets/{1}/versions/:draft'.format(
-            self.connection.host,
+        url = '{0}/datasets/{1}/versions/:draft'.format(
+            self.connection.native_base_url,
             self.id,
         )
         resp = requests.put(

dataverse/dataverse.py

@@ -51,8 +51,8 @@ def get_contents(self, refresh=False):
         if not refresh and self._contents_json:
             return self._contents_json
 
-        content_uri = 'https://{0}/api/dataverses/{1}/contents'.format(
-            self.connection.host, self.alias
+        content_uri = '{0}/dataverses/{1}/contents'.format(
+            self.connection.native_base_url, self.alias
         )
         resp = requests.get(
             content_uri,
@@ -76,8 +76,8 @@ def get_collection_info(self, refresh=False):
         return self._collection_info
 
     def publish(self):
-        edit_uri = 'https://{0}/dvn/api/data-deposit/v1.1/swordv2/edit/dataverse/{1}'.format(
-            self.connection.host, self.alias
+        edit_uri = '{0}/edit/dataverse/{1}'.format(
+            self.connection.sword_base_url, self.alias
         )
         resp = requests.post(
             edit_uri,

dataverse/exceptions.py

@@ -1,5 +1,6 @@
 from __future__ import absolute_import
 
+
 class DataverseError(Exception):
     """Base exception class for Dataverse-related error."""
     pass

dataverse/file.py

@@ -9,15 +9,16 @@ def __init__(self, dataset, name, file_id=None):
         self.name = sanitize(name)
         self.id = file_id
 
-        self.download_url = 'http://{0}/api/access/datafile/{1}'.format(
-            dataset.connection.host, self.id
+        self.download_url = '{0}/access/datafile/{1}'.format(
+            dataset.connection.native_base_url, self.id
         )
-        self.edit_media_uri = 'https://{0}/dvn/api/data-deposit/v1.1/swordv2/edit-media/file/{1}'.format(
-            dataset.connection.host, self.id
+        edit_media_base = '{0}/edit-media/file/{1}'
+        self.edit_media_uri = edit_media_base.format(
+            dataset.connection.sword_base_url, self.id
         )
 
     @classmethod
     def from_json(cls, dataset, json):
         name = json['datafile']['name']
         file_id = json['datafile']['id']
-        return cls(dataset, name, file_id)
+        return cls(dataset, name, file_id)

dataverse/test/test_dataverse.py

@@ -120,7 +120,9 @@ def test_connect_unauthorized(self):
     def test_connect_unknown_failure(self):
         httpretty.register_uri(
             httpretty.GET,
-            'https://{host}/dvn/api/data-deposit/v1.1/swordv2/service-document'.format(host=TEST_HOST),
+            'https://{host}/dvn/api/data-deposit/v1.1/swordv2/service-document'.format(
+                host=TEST_HOST
+            ),
             status=400,
         )
 
@@ -229,7 +231,8 @@ def test_init_from_xml(self):
             tag='rights'
         ).text
         assert title == 'Roasting at Home'
-        assert publisher == 'Creative Commons CC-BY 3.0 (unported) http://creativecommons.org/licenses/by/3.0/'
+        assert publisher == 'Creative Commons CC-BY 3.0 (unported) ' \
+                            'http://creativecommons.org/licenses/by/3.0/'
 
 
 class TestDatasetOperations(DataverseServerTestBase):

readme.md

@@ -51,3 +51,7 @@ To run tests:
 Or, to run a specific test:
 
     $ py.test dataverse/test/test_dataverse.py::TestClassName::test_method_name
+    
+To check for style:
+
+    $ flake8 .

setup.cfg

@@ -0,0 +1,3 @@
+[flake8]
+max-line-length = 100
+exclude = dataverse/__init__.py,dataverse/settings/__init__.py

setup.py

@@ -12,6 +12,7 @@
 TESTS_REQUIRE = [
     'httpretty>=0.8.8',
     'pytest>=2.7.0',
+    'flake8>=2.4.0',
 ]