Skip to content

Commit 066350e

Browse files
committed
refactor: remove getDatasetTypeByNameOrId method from DatasetRepository and its implementations
1 parent 4cc0129 commit 066350e

File tree

5 files changed

+1
-32
lines changed

5 files changed

+1
-32
lines changed

src/dataset/domain/repositories/DatasetRepository.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,5 +66,4 @@ export interface DatasetRepository {
6666
unlink(datasetId: string | number, collectionIdOrAlias: string | number): Promise<void>
6767
getDatasetLinkedCollections: (datasetId: string | number) => Promise<CollectionSummary[]>
6868
getAvailableDatasetTypes: () => Promise<DatasetType[]>
69-
getDatasetTypeByNameOrId: (nameOrId: string | number) => Promise<DatasetType>
7069
}

src/dataset/domain/useCases/getDatasetTypeByNameOrId.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ import {
3939
unlinkDataset,
4040
getDatasetLinkedCollections,
4141
DatasetType,
42-
getDatasetAvailableDatasetTypes,
43-
getDatasetAvailableDatasetType
42+
getDatasetAvailableDatasetTypes
4443
} from '@iqss/dataverse-client-javascript'
4544
import { JSDatasetMapper } from '../mappers/JSDatasetMapper'
4645
import { DatasetPaginationInfo } from '../../domain/models/DatasetPaginationInfo'
@@ -430,10 +429,6 @@ export class DatasetJSDataverseRepository implements DatasetRepository {
430429
return getDatasetAvailableDatasetTypes.execute()
431430
}
432431

433-
getDatasetTypeByNameOrId(nameOrId: string | number): Promise<DatasetType> {
434-
return getDatasetAvailableDatasetType.execute(nameOrId)
435-
}
436-
437432
/*
438433
TODO: This is a temporary solution as this use case doesn't exist in js-dataverse yet and the API should also return the file store type rather than name only.
439434
After https://github.com/IQSS/dataverse/issues/11695 is implemented, create a js-dataverse use case.

src/stories/dataset/DatasetErrorMockRepository.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -190,12 +190,4 @@ export class DatasetErrorMockRepository implements DatasetMockRepository {
190190
}, FakerHelper.loadingTimout())
191191
})
192192
}
193-
194-
getDatasetTypeByNameOrId(_nameOrId: string | number): Promise<DatasetType> {
195-
return new Promise((_resolve, reject) => {
196-
setTimeout(() => {
197-
reject('Error thrown from mock')
198-
}, FakerHelper.loadingTimout())
199-
})
200-
}
201193
}

src/stories/dataset/DatasetMockRepository.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -218,12 +218,4 @@ export class DatasetMockRepository implements DatasetRepository {
218218
}, FakerHelper.loadingTimout())
219219
})
220220
}
221-
222-
getDatasetTypeByNameOrId(_nameOrId: string | number): Promise<DatasetType> {
223-
return new Promise((resolve) => {
224-
setTimeout(() => {
225-
resolve(DatasetTypeMother.creatDefaultDatasetType())
226-
}, FakerHelper.loadingTimout())
227-
})
228-
}
229221
}

0 commit comments

Comments
 (0)