Skip to content

Commit 3771980

Browse files
committed
fix: wording while deleting draft dataset
1 parent e1957ab commit 3771980

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

public/locales/en/dataset.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
},
6969
"deleteDatasetModal": {
7070
"title": "Delete Dataset",
71-
"message": "Are you sure you want to delete this dataset? This action cannot be undone.",
71+
"message": "Are you sure you want to delete this draft version? Files will be reverted to the most recently published version. You cannot undelete this draft.",
7272
"defaultDatasetDeleteError": "An error occurred while deleting the dataset."
7373
}
7474
},
@@ -137,7 +137,7 @@
137137
"heading": "Unpublished Dataset Private URL",
138138
"alertText": "This unpublished dataset is being privately shared."
139139
},
140-
"datasetDeletedSuccess": "The dataset has been deleted."
140+
"datasetDeletedSuccess": "The dataset draft has been deleted."
141141
},
142142
"termsTab": {
143143
"editTermsButton": "Edit Term Requirements",

tests/component/sections/dataset/dataset-action-buttons/edit-dataset-menu/DeleteDraftDatasetButton.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ describe('DeleteDraftDatasetButton', () => {
8383
cy.findByRole('button', { name: 'Delete Dataset' }).click()
8484

8585
cy.findByRole('dialog').should('exist')
86-
cy.findByText(/Are you sure you want to delete this dataset?/i).should('exist')
86+
cy.findByText(/Are you sure you want to delete this draft version?/i).should('exist')
8787
})
8888

8989
it('closes confirmation modal when cancel is clicked', () => {
@@ -118,7 +118,7 @@ describe('DeleteDraftDatasetButton', () => {
118118
cy.findByRole('dialog').should('exist')
119119
cy.findByRole('button', { name: 'Delete' }).click()
120120
cy.findByRole('dialog').should('not.exist')
121-
cy.findByText(/The dataset has been deleted./).should('exist')
121+
cy.findByText(/The dataset draft has been deleted./).should('exist')
122122
})
123123

124124
it('should not delete dataset if delete button clicked and repository fails', () => {

tests/component/sections/dataset/dataset-action-buttons/edit-dataset-menu/EditDatasetMenu.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,9 @@ describe('EditDatasetMenu', () => {
203203
)
204204
cy.findByRole('button', { name: 'Edit Dataset' }).click()
205205
cy.findByRole('button', { name: /Delete/ }).click()
206-
cy.findByText(/Are you sure you want to delete this dataset?/i).should('exist')
206+
cy.findByText(/Are you sure you want to delete this draft version?/i).should('exist')
207207
cy.findByRole('button', { name: 'Delete' }).click()
208-
cy.findByText(/The dataset has been deleted./).should('exist')
208+
cy.findByText(/The dataset draft has been deleted./).should('exist')
209209

210210
const searchParams = new URLSearchParams({
211211
[QueryParamKey.PERSISTENT_ID]: dataset.persistentId,

tests/e2e-integration/e2e/sections/dataset/Dataset.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,9 +304,9 @@ describe('Dataset', () => {
304304

305305
cy.findByRole('button', { name: 'Edit Dataset' }).should('exist').click()
306306
cy.findByRole('button', { name: 'Delete Dataset' }).should('exist').click()
307-
cy.findByText(/Are you sure you want to delete this dataset?/i).should('exist')
307+
cy.findByText(/Are you sure you want to delete this draft version?/i).should('exist')
308308
cy.findByRole('button', { name: 'Delete' }).should('exist').click()
309-
cy.findByText(/The dataset has been deleted./i).should('exist')
309+
cy.findByText(/The dataset draft has been deleted./i).should('exist')
310310
})
311311
})
312312
})

0 commit comments

Comments
 (0)