add logic for PublishDatasetHelpText.tsx warning text, fix translation

Author: ekraffmiller

public/locales/en/dataset.json

@@ -116,7 +116,7 @@
     "previouslyReleasedQuestion": "Are you sure you want to republish this dataset?",
     "releaseCollectionQuestion": "This dataset cannot be published until <a>{{parentCollectionName}}</a> is published. Would you like to publish both right now?",
     "requiresMajorRelease": "Due to the nature of the changes to the current draft this will be a major release ({{versionNumber}})",
-    "termsText": "To publish with custom Terms of Use, click the Cancel button and go to the Terms tab for this dataset.",
+    "termsText": "To change the terms for this version, click the Cancel button and go to the Terms tab for this dataset.",
     "selectVersion": "Select if this is a minor or major version update.",
     "continueButton": "Continue",
     "cancelButton": "Cancel",

src/sections/dataset/publish-dataset/PublishDatasetHelpText.tsx

@@ -13,18 +13,6 @@ interface PublishDatasetHelpTextProps {
   requiresMajorVersionUpdate?: boolean
 }
 
-function getWarningTextKey(
-  releasedVersionExists: boolean,
-  parentCollectionIsReleased: boolean | undefined
-): string {
-  if (!releasedVersionExists) {
-    if (!parentCollectionIsReleased) {
-      return 'publish.releaseCollectionQuestion'
-    } else return 'publish.draftQuestion'
-  }
-  return 'publish.previouslyReleasedQuestion'
-}
-
 export function PublishDatasetHelpText({
   releasedVersionExists,
   nextMajorVersion,
@@ -34,20 +22,24 @@ export function PublishDatasetHelpText({
   requiresMajorVersionUpdate
 }: PublishDatasetHelpTextProps) {
   const { t } = useTranslation('dataset')
-  const warningText = getWarningTextKey(releasedVersionExists, parentCollectionIsReleased)
 
   return (
     <Stack direction="vertical">
       <p className={styles.warningText}>
-        {!parentCollectionIsReleased ? (
+        {!releasedVersionExists && parentCollectionIsReleased && <>{t('publish.draftQuestion')}</>}
+        {!releasedVersionExists && !parentCollectionIsReleased && (
           <Trans
             t={t}
-            i18nKey={warningText}
+            i18nKey={'publish.releaseCollectionQuestion'}
             values={{ parentCollectionName }}
             components={{ a: <Link to={RouteWithParams.COLLECTIONS(parentCollectionId)} /> }}
           />
-        ) : (
-          <>{t(warningText)}</>
+        )}
+        {releasedVersionExists && !requiresMajorVersionUpdate && (
+          <>{t('publish.previouslyReleasedQuestion')}</>
+        )}
+        {releasedVersionExists && requiresMajorVersionUpdate && (
+          <Trans t={t} i18nKey={'publish.requiresMajorRelease'} values={{ nextMajorVersion }} />
         )}
       </p>
       <p>{t('publish.termsText')}</p>