Skip to content

Commit a60f4df

Browse files
committed
test: duplicated json text
1 parent 6b4a6af commit a60f4df

File tree

3 files changed

+8
-21
lines changed

3 files changed

+8
-21
lines changed

public/locales/en/dataset.json

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
"license": {
1111
"title": "License/Data Use Agreement",
1212
"altTextPrefix": "License image for ",
13-
"description": "This dataset will be published under the terms specified below. Our Community Norms as well as good scientific practices expect that proper credit is given via citation.",
14-
"moreInfo": "More information"
13+
"description": "This dataset will be published under the terms specified below. Our Community Norms as well as good scientific practices expect that proper credit is given via citation."
1514
},
16-
"loading": "Loading...",
1715
"citation": {
1816
"status": {
1917
"draft": {
@@ -273,7 +271,6 @@
273271
"deaccessionedReason": "Deaccessioned Reason",
274272
"error": "Error on loading dataset versions"
275273
},
276-
"getDatasetVersionDiffError": "Error Fetching Dataset Version Differences",
277274
"datasetVersionSummary": {
278275
"firstPublished": "This is the First Published Version.",
279276
"firstDraft": "This is a draft version.",
@@ -355,9 +352,7 @@
355352
"licenseRequired": "Please select a license for this dataset",
356353
"customTermsRequired": "Terms of use is required.",
357354
"customTermsLabel": "Custom Dataset Terms",
358-
"licenseDescription": "This dataset will be published under the terms specified below. Our Community Norms as well as good scientific practices expect that proper credit is given via citation.",
359-
"errorLoadingLicenses": "Error loading licenses",
360-
"saveSuccessMessage": "Dataset terms saved! License: {{license}}, Custom Terms: {{customTerms}}"
355+
"licenseDescription": "This dataset will be published under the terms specified below. Our Community Norms as well as good scientific practices expect that proper credit is given via citation."
361356
},
362357
"restrictedFilesTerms": {
363358
"title": "Restricted Files + Terms of Access",

src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ import { DatasetDTO } from '../../domain/useCases/DTOs/DatasetDTO'
5353
import { DatasetDTOMapper } from '../mappers/DatasetDTOMapper'
5454
import { DatasetsWithCount } from '../../domain/models/DatasetsWithCount'
5555
import { VersionUpdateType } from '../../domain/models/VersionUpdateType'
56-
import { DatasetVersionSummarySubset } from '@/dataset/domain/models/DatasetVersionSummaryInfo'
56+
import { DatasetVersionSummaryInfo } from '@/dataset/domain/models/DatasetVersionSummaryInfo'
5757
import { DatasetDownloadCount } from '@/dataset/domain/models/DatasetDownloadCount'
5858
import { FormattedCitation, CitationFormat } from '@/dataset/domain/models/DatasetCitation'
5959
import { DatasetLicenseUpdateRequest } from '../../domain/models/DatasetLicenseUpdateRequest'
@@ -382,16 +382,10 @@ export class DatasetJSDataverseRepository implements DatasetRepository {
382382
throw new Error(error.message)
383383
})
384384
}
385-
getDatasetVersionsSummaries(
386-
datasetId: number | string,
387-
limit?: number,
388-
offset?: number
389-
): Promise<DatasetVersionSummarySubset> {
390-
return getDatasetVersionsSummaries
391-
.execute(datasetId, limit, offset)
392-
.catch((error: ReadError) => {
393-
throw error
394-
})
385+
getDatasetVersionsSummaries(datasetId: number | string): Promise<DatasetVersionSummaryInfo[]> {
386+
return getDatasetVersionsSummaries.execute(datasetId).catch((error: ReadError) => {
387+
throw error
388+
})
395389
}
396390
getDownloadCount(
397391
datasetId: string | number,

src/sections/edit-dataset-terms/dataset-terms-tab/DatasetTermsTab.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -209,9 +209,7 @@ export function DatasetTermsTab({
209209
{isLoadingLicenses ? (
210210
<Spinner variant="light" animation="border" size="sm" />
211211
) : errorLicenses ? (
212-
<Alert variant="danger">
213-
{t('editTerms.datasetTerms.errorLoadingLicenses')}
214-
</Alert>
212+
<Alert variant="danger">{tShared('loading')}</Alert>
215213
) : (
216214
licenseOptions.map((option) => (
217215
<option key={option.value} value={option.value}>

0 commit comments

Comments
 (0)