test: remove testid and find by text instead

Author: g-saracca

src/sections/create-collection/CreateCollection.tsx

@@ -64,7 +64,7 @@ export function CreateCollection({
 
   if (collectionUserPermissions && !canUserAddCollection) {
     return (
-      <div className="pt-4" data-testid="not-allowed-to-create-collection-alert">
+      <div className="pt-4">
         <Alert variant="danger" dismissible={false}>
           {t('notAllowedToCreateCollection')}
         </Alert>

src/sections/edit-collection/EditCollection.tsx

@@ -64,7 +64,7 @@ export const EditCollection = ({
 
   if (collectionUserPermissions && !canUserEditCollection) {
     return (
-      <div className="pt-4" data-testid="not-allowed-to-edit-collection-alert">
+      <div className="pt-4">
         <Alert variant="danger" dismissible={false}>
           {t('notAllowedToEditCollection')}
         </Alert>

tests/component/sections/create-collection/CreateCollection.spec.tsx

@@ -103,11 +103,14 @@ describe('CreateCollection', () => {
   })
 
   it('should show alert error message when user is not allowed to create collection', () => {
-    collectionRepository.getUserPermissions = cy.stub().resolves(
-      CollectionMother.createUserPermissions({
-        canAddCollection: false
-      })
-    )
+    const DELAYED_TIME = 200
+    collectionRepository.getUserPermissions = cy.stub().callsFake(() => {
+      return Cypress.Promise.delay(DELAYED_TIME).then(() =>
+        CollectionMother.createUserPermissions({
+          canAddCollection: false
+        })
+      )
+    })
 
     cy.mountAuthenticated(
       <CreateCollection
@@ -116,18 +119,33 @@ describe('CreateCollection', () => {
         metadataBlockInfoRepository={metadataBlockInfoRepository}
       />
     )
-    cy.findAllByTestId('not-allowed-to-create-collection-alert').should('exist')
+
+    cy.wait(DELAYED_TIME * 2)
+
+    cy.findByText(
+      /You do not have permissions to create a collection within this collection./
+    ).should('exist')
   })
 
   it('should not show alert error message when user is allowed to create collection', () => {
+    const DELAYED_TIME = 200
+    collectionRepository.getUserPermissions = cy.stub().callsFake(() => {
+      return Cypress.Promise.delay(DELAYED_TIME).then(() => userPermissionsMock)
+    })
+
     cy.mountAuthenticated(
       <CreateCollection
         collectionRepository={collectionRepository}
         parentCollectionId="root"
         metadataBlockInfoRepository={metadataBlockInfoRepository}
       />
     )
-    cy.findAllByTestId('not-allowed-to-create-collection-alert').should('not.exist')
+
+    cy.wait(DELAYED_TIME * 2)
+
+    cy.findByText(
+      /You do not have permissions to create a collection within this collection./
+    ).should('not.exist')
   })
 
   it('should show alert error message when getting the user permissions fails', () => {

tests/component/sections/edit-collection/EditCollection.spec.tsx

@@ -33,7 +33,7 @@ const allMetadataBlocksMock = [
 const testUser = UserMother.create()
 const userRepository: UserRepository = {} as UserRepository
 
-describe('CreateCollection', () => {
+describe('EditCollection', () => {
   beforeEach(() => {
     collectionRepository.create = cy.stub().resolves(1)
     collectionRepository.getById = cy.stub().resolves(collection)
@@ -103,11 +103,14 @@ describe('CreateCollection', () => {
   })
 
   it('should show alert error message when user is not allowed to edit the collection', () => {
-    collectionRepository.getUserPermissions = cy.stub().resolves(
-      CollectionMother.createUserPermissions({
-        canEditCollection: false
-      })
-    )
+    const DELAYED_TIME = 200
+    collectionRepository.getUserPermissions = cy.stub().callsFake(() => {
+      return Cypress.Promise.delay(DELAYED_TIME).then(() =>
+        CollectionMother.createUserPermissions({
+          canEditCollection: false
+        })
+      )
+    })
 
     cy.mountAuthenticated(
       <EditCollection
@@ -116,18 +119,33 @@ describe('CreateCollection', () => {
         metadataBlockInfoRepository={metadataBlockInfoRepository}
       />
     )
-    cy.findAllByTestId('not-allowed-to-edit-collection-alert').should('exist')
+
+    cy.wait(DELAYED_TIME * 2)
+
+    cy.findByText(/You do not have permissions to edit this collection./, { timeout: 0 }).should(
+      'exist'
+    )
   })
 
   it('should not show alert error message when user is allowed to edit the collection', () => {
+    const DELAYED_TIME = 200
+    collectionRepository.getUserPermissions = cy.stub().callsFake(() => {
+      return Cypress.Promise.delay(DELAYED_TIME).then(() => userPermissionsMock)
+    })
+
     cy.mountAuthenticated(
       <EditCollection
         collectionId="root"
         collectionRepository={collectionRepository}
         metadataBlockInfoRepository={metadataBlockInfoRepository}
       />
     )
-    cy.findAllByTestId('not-allowed-to-edit-collection-alert').should('not.exist')
+
+    cy.wait(DELAYED_TIME * 2)
+
+    cy.findByText(/You do not have permissions to edit this collection./, { timeout: 0 }).should(
+      'not.exist'
+    )
   })
 
   it('should show alert error message when getting the user permissions fails', () => {