cleanups after reviewing PR

Author: g-saracca

.storybook/preview-head.html

@@ -1,7 +1,4 @@
-<!-- Load runtime app config before stories so requireAppConfig() can initialize -->
 <script src="/config.js"></script>
 <script>
   window.global = window
-  // Note: /config.js sets window.__APP_CONFIG__ at runtime for Storybook too.
-  // Our preview.tsx will validate it early via initAppConfig().
 </script>

.storybook/preview.tsx

@@ -23,8 +23,6 @@ const preview: Preview = {
   },
   decorators: [
     (Story) => {
-      // Validate runtime app config once when Storybook starts. This will read window.__APP_CONFIG__
-      // that we inject via preview-head.html (/config.js) and cache it for requireAppConfig().
       const result = initAppConfig()
       if (!result.ok) {
         console.error('Storybook runtime config invalid/missing:', result.message)

cypress.config.ts

@@ -38,5 +38,5 @@ export default defineConfig({
     codeCoverage: {
       exclude: ['tests/**/*.*', '**/ErrorPage.tsx']
     }
-  },
+  }
 })

public/config.js

@@ -14,7 +14,7 @@ window.__APP_CONFIG__ = {
     // All auth-related storage keys will be prefixed with this string
     localStorageKeyPrefix: 'DV_'
   },
-  // UI languages available to users
+  // UI languages available to users (if more than one is provided a language switcher will be shown)
   languages: [
     { code: 'en', name: 'English' },
     { code: 'es', name: 'Español' }

src/config.ts

@@ -8,13 +8,6 @@ declare global {
 
 let CONFIG: AppConfig | undefined
 
-/**
- * This function initializes the application configuration by validating and loading it from the global window object.
- * There is a script tag in index.html that loads /config.js at runtime, which sets window.__APP_CONFIG__.
- * This helps changing configuration at runtime without rebuilding the application.
- * It returns an object indicating whether the initialization was successful or not, along with the configuration value or an error message.
- */
-
 const AppConfigSchema = z.object({
   backendUrl: z.url(),
   oidc: z.object({
@@ -39,6 +32,12 @@ export type AppConfigResult =
   | { ok: true; value: AppConfig }
   | { ok: false; message: string; schemaError?: string }
 
+/**
+ * This function initializes the application configuration by validating and loading it from the global window object.
+ * There is a script tag in index.html that loads /config.js at runtime, which sets window.__APP_CONFIG__.
+ * This helps changing configuration at runtime without rebuilding the application.
+ * It returns an object indicating whether the initialization was successful or not, along with the configuration value or an error message.
+ */
 export function initAppConfig(): AppConfigResult {
   const raw = typeof window !== 'undefined' ? window.__APP_CONFIG__ : undefined
 

src/i18n.ts

@@ -44,7 +44,6 @@ i18next.on('languageChanged', (lng) => setHtmlLangAndDir(lng))
  * 2. Browser language (if supported)
  * 3. Default language from app config
  */
-
 function defineLanguage(): string {
   const storedLang = localStorage.getItem(LANGUAGE_LOCAL_STORAGE_KEY)
   const supportedLangs = appConfig.languages.map((l) => l.code.toLowerCase())
@@ -78,7 +77,7 @@ function setHtmlLangAndDir(lng: string | undefined) {
 
   html.setAttribute('lang', baseLang)
 
-  // This could be the first step into supporting RTL languages, but there is still a lot to do in the UI.
+  // This is the first step into supporting RTL languages, but there is still a lot to do in the UI.
   const rtlLangs = new Set(['ar', 'fa', 'he', 'iw', 'kd', 'pk', 'ps', 'ug', 'ur', 'yi'])
   html.setAttribute('dir', rtlLangs.has(baseLang) ? 'rtl' : 'ltr')
 }

src/sections/dataset/dataset-action-buttons/DatasetToolsOptions.tsx

@@ -86,7 +86,7 @@ const ToolOption = ({
         externalToolsRepository,
         persistentId,
         toolId,
-        { preview: false, locale: i18n.language }
+        { preview: false, locale: i18n.languages[0] }
       )
 
       // Change the location of the new window to the tool URL

src/sections/file/file-action-buttons/access-file-menu/FileToolOptions.tsx

@@ -110,7 +110,7 @@ const ToolOption = ({
         externalToolsRepository,
         fileId,
         toolId,
-        { preview: false, locale: i18n.language }
+        { preview: false, locale: i18n.languages[0] }
       )
       // Change the location of the new window to the tool URL
       newWindow.location.href = fileExternalTool.toolUrlResolved

src/sections/file/file-embedded-external-tool/FileEmbeddedExternalTool.tsx

@@ -61,7 +61,7 @@ export const FileEmbeddedExternalTool = ({
           externalToolsRepository,
           file.id,
           toolIdSelected,
-          { preview: true, locale: i18n.language }
+          { preview: true, locale: i18n.languages[0] }
         )
 
         setFileExternalToolResolved(fileExternalTool)
@@ -78,7 +78,7 @@ export const FileEmbeddedExternalTool = ({
     }
 
     void fetchFileExternalToolResolved()
-  }, [isInView, toolIdSelected, externalToolsRepository, file.id, t, i18n.language])
+  }, [isInView, toolIdSelected, externalToolsRepository, file.id, t, i18n.languages])
 
   return (
     <section>