make changes for code review

Author: ekraffmiller

src/info/infrastructure/repositories/DataverseInfoJSDataverseRepository.ts

@@ -110,21 +110,13 @@ export class DataverseInfoJSDataverseRepository implements DataverseInfoReposito
       .execute()
       .then((text) => {
         const trimmedLength = text?.trim().length ?? 0
-        console.debug(
-          `[DataverseInfo] Loaded ${SettingName.PUBLISH_DATASET_DISCLAIMER_TEXT} (length=${trimmedLength})`
-        )
 
         return {
           name: SettingName.PUBLISH_DATASET_DISCLAIMER_TEXT,
           value: text
         }
       })
       .catch((error: unknown) => {
-        console.warn(
-          `[DataverseInfo] Failed loading ${SettingName.PUBLISH_DATASET_DISCLAIMER_TEXT}; defaulting to empty string`,
-          error
-        )
-
         // In case of error, we default to an empty string which indicates no disclaimer text.
         return {
           name: SettingName.PUBLISH_DATASET_DISCLAIMER_TEXT,

src/sections/dataset/publish-dataset/PublishDatasetModal.module.scss

@@ -17,7 +17,6 @@
 .customPopupTextBlock {
   border: 1px solid $dv-border-color;
   background-color: #f8f9fa;
-  border-left: 4px solid $dv-primary-color;
   padding: 0.75rem 1rem;
   border-radius: 0.25rem;
 }

src/sections/dataset/publish-dataset/PublishDatasetModal.tsx

@@ -119,7 +119,9 @@ export function PublishDatasetModal({
           />
 
           {shouldShowCustomPopupText && (
-            <p className={styles.secondaryText}>{datasetPublishPopupCustomText}</p>
+            <div className={styles.customPopupTextBlock}>
+              <p className={styles.customPopupText}>{datasetPublishPopupCustomText}</p>
+            </div>
           )}
 
           {releasedVersionExists && !requiresMajorVersionUpdate && (

tests/component/sections/dataset/dataset-publish/PublishDatasetModal.spec.tsx

@@ -224,6 +224,7 @@ describe('PublishDatasetModal', () => {
 
     cy.findByText(/Custom Dataset Terms/).should('exist')
   })
+
   it('Displays disclaimer text from settings', () => {
     const dataverseInfoRepository = new DataverseInfoMockRepository()
     const disclaimerText = 'This is custom text for the dataset publish popup.'
@@ -236,6 +237,7 @@ describe('PublishDatasetModal', () => {
 
     cy.findByText(disclaimerText).should('exist')
   })
+
   it('Disables the continue button until the user checks the disclaimer text', () => {
     const dataverseInfoRepository = new DataverseInfoMockRepository()
     const disclaimerText = 'This is disclaimer text for the dataset publish popup.'
@@ -250,6 +252,7 @@ describe('PublishDatasetModal', () => {
     cy.findByRole('checkbox', { name: disclaimerText }).click()
     cy.findByRole('button', { name: 'Continue' }).should('not.be.disabled')
   })
+
   it('Displays the custom popup text if it is available', () => {
     const dataverseInfoRepository = new DataverseInfoMockRepository()
     const popupText = 'This is custom text for the popup.'