Skip to content

Comments

Replace file button in dataset page#640

Merged
ofahimIQSS merged 10 commits intodevelopfrom
feat/635-replace-file-btn-in-dataset-page
Apr 9, 2025
Merged

Replace file button in dataset page#640
ofahimIQSS merged 10 commits intodevelopfrom
feat/635-replace-file-btn-in-dataset-page

Conversation

@g-saracca
Copy link
Contributor

@g-saracca g-saracca commented Apr 1, 2025

What this PR does / why we need it:

Adds the Replace File button in the dataset files table, currently it only exists in the File page

Which issue(s) this PR closes:

Suggestions on how to test this:

  1. Create a dataset and upload a file.
  2. Navigate to that dataset and click edit file => Replace in the files table.
  3. You should be redirected to the replace a file, and after replacing you should be redirected back to the dataset in draft mode.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

No

Additional documentation:

No

@github-actions github-actions bot added FY25 Sprint 20 FY25 Sprint 20 (2025-03-26 - 2025-04-09) GREI Re-arch GREI re-architecture-related SPA.Q1.6 Files Page: Files Edit Options labels Apr 1, 2025
@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels Apr 1, 2025
@g-saracca g-saracca moved this to Ready for Review ⏩ in IQSS Dataverse Project Apr 1, 2025
@coveralls
Copy link

coveralls commented Apr 1, 2025 •
edited
Loading

Coverage Status

coverage: 98.084% (+0.5%) from 97.624%
when pulling 480babf on feat/635-replace-file-btn-in-dataset-page
into e426a7d on develop.

@g-saracca g-saracca changed the title Feat/635 replace file btn in dataset page Replace file button in dataset page Apr 1, 2025
@g-saracca g-saracca moved this from Ready for Review ⏩ to In Progress 💻 in IQSS Dataverse Project Apr 2, 2025
@g-saracca g-saracca self-assigned this Apr 2, 2025
@g-saracca g-saracca moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Apr 2, 2025
@g-saracca g-saracca removed their assignment Apr 2, 2025
@g-saracca g-saracca requested a review from ChengShi-1 April 7, 2025 12:40
@ChengShi-1 ChengShi-1 self-assigned this Apr 7, 2025
@ChengShi-1 ChengShi-1 moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Apr 7, 2025
ChengShi-1
ChengShi-1 reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi German, good job! just two things here

  • If the file type is unknown, we could put an unknown or something by default inside the parentheses( )
    image

  • we could add tests to EditFileMenu.spec.tsx as well for the replace button

@g-saracca
Copy link
Contributor Author

g-saracca commented Apr 7, 2025

Hi @ChengShi-1 could you tell me the file extension that you try with? So I can add it also, apart from the unknown label.

@g-saracca
Copy link
Contributor Author

g-saracca commented Apr 7, 2025

@ChengShi-1 all changes applied. I changed the replace file button onClick listener with navigate for a link, same as I did with the replace file button in the dataset page 👍🏼 , I also add a test for it.

@g-saracca g-saracca assigned g-saracca and unassigned g-saracca Apr 7, 2025
@g-saracca
Copy link
Contributor Author

g-saracca commented Apr 8, 2025

@ChengShi-1 sorry, I need to add some more tests to increase coverage a bit. Will let you know when is ready again 👍🏼

@g-saracca g-saracca removed their assignment Apr 8, 2025
@g-saracca
Copy link
Contributor Author

g-saracca commented Apr 8, 2025

Ready for review 👍🏼

ChengShi-1
ChengShi-1 previously approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Apr 8, 2025
@ChengShi-1 ChengShi-1 removed their assignment Apr 8, 2025
@ofahimIQSS ofahimIQSS self-assigned this Apr 8, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Apr 8, 2025
@ofahimIQSS
Copy link
Contributor

ofahimIQSS commented Apr 8, 2025

noticed there were 3 pending checks on this:
image

@ChengShi-1
Copy link
Contributor

ChengShi-1 commented Apr 8, 2025

@g-saracca Hi German, notice some conflicts existing

@ChengShi-1 ChengShi-1 self-requested a review April 9, 2025 13:04
@github-project-automation github-project-automation bot moved this from QA ✅ to Ready for QA ⏩ in IQSS Dataverse Project Apr 9, 2025
@g-saracca
Copy link
Contributor Author

g-saracca commented Apr 9, 2025

@ofahimIQSS UI reviews and conflicts solved 👍🏼

@scolapasta scolapasta moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Apr 9, 2025
@GPortas GPortas added the SPA.Q2 Not related to any specific Q2 feature label Apr 9, 2025
@ofahimIQSS
Copy link
Contributor

ofahimIQSS commented Apr 9, 2025

Looks good, merging PR
Uploading Screen Recording 2025-04-09 at 12.11.44 PM.mov…

@ofahimIQSS ofahimIQSS merged commit 1dab2fe into develop Apr 9, 2025
15 of 16 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Apr 9, 2025
@ofahimIQSS ofahimIQSS deleted the feat/635-replace-file-btn-in-dataset-page branch April 9, 2025 16:12
@ofahimIQSS ofahimIQSS removed their assignment Apr 9, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Apr 10, 2025
@cmbz cmbz mentioned this pull request Apr 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChengShi-1 ChengShi-1 ChengShi-1 approved these changes

Assignees

No one assigned

Labels

FY25 Sprint 20 FY25 Sprint 20 (2025-03-26 - 2025-04-09) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q1.6 Files Page: Files Edit Options SPA.Q2 Not related to any specific Q2 feature

Projects

IQSS Dataverse Project
Status: Done 🧹

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the Replace File button in Dataset Files table

5 participants

@g-saracca @coveralls @ofahimIQSS @ChengShi-1 @GPortas