Skip to content

Commit 62f976e

Browse files
committed
updates per review
1 parent c7c7e70 commit 62f976e

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

doc/release-notes/11612-RAHistory.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Dataverse can now track the history of role assignments, allowing administrators
44

55
## Key components of this feature:
66

7-
- **Feature Flag**: The functionality can be enabled/disabled via the `ROLE_ASSIGNMENT_HISTORY` feature flag
7+
- **Feature Flag**: The functionality can be enabled/disabled via the `ROLE_ASSIGNMENT_HISTORY` feature flag (default is `off`)
88
- **UI Integration**: New history panels on permission management pages showing the complete history of role assignments/revocations
99
- **CSV Export**: Administrators can download the role assignment history for a given collection or dataset (or files in a dataset) as a CSV file directly from the new panels
1010
- **API Access**: New API endpoints provide access to role assignment history in both JSON and CSV formats:

src/main/java/edu/harvard/iq/dataverse/ManageFilePermissionsPage.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,8 @@ public void setRenderFileMessages(boolean renderFileMessages) {
584584
this.renderFileMessages = renderFileMessages;
585585
}
586586

587-
public String getsignedUrlForRAHistoryCsv() {
587+
public String getSignedUrlForRAHistoryCsv() {
588+
//Including /v1 is required for the signature to validate
588589
String apiPath = "/api/v1/datasets/" + dataset.getId() + "/files/permissions/history";
589590

590591
try {

src/main/java/edu/harvard/iq/dataverse/ManagePermissionsPage.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -696,9 +696,9 @@ public void setRenderRoleMessages(Boolean renderRoleMessages) {
696696
this.renderRoleMessages = renderRoleMessages;
697697
}
698698

699-
public String getsignedUrlForRAHistoryCsv() {
699+
public String getSignedUrlForRAHistoryCsv() {
700700
String apiPath;
701-
701+
//Including /v1 in these urls is required for the signature to validate
702702
if (dvObject instanceof Dataverse dv) {
703703
// For Dataverses, use the dataverses API endpoint with the alias
704704
apiPath = "/api/v1/dataverses/" + dv.getAlias() + "/permissions/history";

0 commit comments

Comments
 (0)