Skip to content

Commit 6d0afad

Browse files
authored
Merge pull request #11033 from IQSS/11032-async-datasetit-test-failure
add wait to async export call
2 parents 66abe87 + a04cdab commit 6d0afad

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

src/test/java/edu/harvard/iq/dataverse/api/DatasetsIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4242,7 +4242,7 @@ public void testCitationDate() throws IOException {
42424242
.statusCode(OK.getStatusCode())
42434243
.body("data.message", is(expectedCitation));
42444244

4245-
Response exportDatasetAsDublinCore = UtilIT.exportDataset(datasetPid, "oai_dc", apiToken);
4245+
Response exportDatasetAsDublinCore = UtilIT.exportDataset(datasetPid, "oai_dc", apiToken, true);
42464246
exportDatasetAsDublinCore.prettyPrint();
42474247
exportDatasetAsDublinCore.then().assertThat()
42484248
.body("oai_dc.type", equalTo("Dataset"))
@@ -4259,7 +4259,7 @@ public void testCitationDate() throws IOException {
42594259
rexport.then().assertThat().statusCode(OK.getStatusCode());
42604260

42614261
String todayDate = LocalDate.now().format(DateTimeFormatter.ofPattern("yyyy-MM-dd"));
4262-
Response exportPostClear = UtilIT.exportDataset(datasetPid, "oai_dc", apiToken);
4262+
Response exportPostClear = UtilIT.exportDataset(datasetPid, "oai_dc", apiToken, true);
42634263
exportPostClear.prettyPrint();
42644264
exportPostClear.then().assertThat()
42654265
.body("oai_dc.type", equalTo("Dataset"))

src/test/java/edu/harvard/iq/dataverse/api/UtilIT.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2161,19 +2161,22 @@ static Response uploadProvFreeForm(String idOrPersistentId, JsonObject jsonObjec
21612161
// return requestSpecification.delete("/api/files/" + idInPath + "/prov-freeform" + optionalQueryParam);
21622162
// }
21632163
static Response exportDataset(String datasetPersistentId, String exporter) {
2164-
return exportDataset(datasetPersistentId, exporter, null);
2164+
return exportDataset(datasetPersistentId, exporter, null, false);
21652165
}
2166-
21672166
static Response exportDataset(String datasetPersistentId, String exporter, String apiToken) {
2168-
// http://localhost:8080/api/datasets/export?exporter=dataverse_json&persistentId=doi%3A10.5072/FK2/W6WIMQ
2167+
return exportDataset(datasetPersistentId, exporter, apiToken, false);
2168+
}
2169+
static Response exportDataset(String datasetPersistentId, String exporter, String apiToken, boolean wait) {
2170+
// Wait for the Async call to finish to get the updated data
2171+
if (wait) {
2172+
sleepForReexport(datasetPersistentId, apiToken, 10);
2173+
}
21692174
RequestSpecification requestSpecification = given();
21702175
if (apiToken != null) {
21712176
requestSpecification = given()
21722177
.header(UtilIT.API_TOKEN_HTTP_HEADER, apiToken);
21732178
}
21742179
return requestSpecification
2175-
// .header(API_TOKEN_HTTP_HEADER, apiToken)
2176-
// .get("/api/datasets/:persistentId/export" + "?persistentId=" + datasetPersistentId + "&exporter=" + exporter);
21772180
.get("/api/datasets/export" + "?persistentId=" + datasetPersistentId + "&exporter=" + exporter);
21782181
}
21792182

0 commit comments

Comments
 (0)