missing ! - also check file in dataset as in existing code

qqmyers · qqmyers · commit 86ae20d1783e · 2025-09-02T11:50:27.000-04:00
diff --git a/src/main/java/edu/harvard/iq/dataverse/dataverse/featured/DataverseFeaturedItemServiceBean.java b/src/main/java/edu/harvard/iq/dataverse/dataverse/featured/DataverseFeaturedItemServiceBean.java
@@ -76,7 +76,7 @@ public void deleteInvalidatedFeaturedItemsByDataset(Dataset dataset) {
                 DataFile df = (DataFile) featuredItem.getDvObject();
                 
                 // Check if the file is restricted or deleted
-                if (df.isRestricted() || df.isInDatasetVersion(latestVersion)) {
+                if (df.isRestricted() || (dataset.equals(df.getOwner()) && !df.isInDatasetVersion(latestVersion))) {
                     logger.fine("Deleting invalidated Featured Item for " + (df.isRestricted() ? "Restricted" : "Deleted") + " Datafile ID: " + df.getId());
                     deleteAllByDvObjectId(df.getId());
                 }

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public void deleteInvalidatedFeaturedItemsByDataset(Dataset dataset) {`
`76`	`76`	`DataFile df = (DataFile) featuredItem.getDvObject();`
`77`	`77`
`78`	`78`	`// Check if the file is restricted or deleted`
`79`		`- if (df.isRestricted() \|\| df.isInDatasetVersion(latestVersion)) {`
	`79`	`+ if (df.isRestricted() \|\| (dataset.equals(df.getOwner()) && !df.isInDatasetVersion(latestVersion))) {`
`80`	`80`	`logger.fine("Deleting invalidated Featured Item for " + (df.isRestricted() ? "Restricted" : "Deleted") + " Datafile ID: " + df.getId());`
`81`	`81`	`deleteAllByDvObjectId(df.getId());`
`82`	`82`	`}`