minor tweaks

Author: qqmyers

src/main/java/edu/harvard/iq/dataverse/DatasetVersionUI.java

@@ -458,10 +458,11 @@ public void setMetadataValueBlocks(DatasetVersion datasetVersion) {
                         mdb.setEmpty(false);
                         datasetFieldsForView.add(dsf);
                     }
-                    //Setting Local Display on Create on mdb when there are any set at dataverse level 
-                       if (dsf.getDatasetFieldType().getLocalDisplayOnCreate() != null && dsf.getDatasetFieldType().getLocalDisplayOnCreate()){
-                            mdb.setLocalDisplayOnCreate(true);
-                       }
+                    // Setting Local Display on Create on mdb when there are any set at dataverse
+                    // level
+                    if (dsf.getDatasetFieldType().shouldDisplayOnCreate()) {
+                        mdb.setLocalDisplayOnCreate(true);
+                    }
                 }
             }
 

src/main/java/edu/harvard/iq/dataverse/MetadataBlock.java

@@ -101,17 +101,18 @@ public void setDatasetFieldTypes(List<DatasetFieldType> datasetFieldTypes) {
     }
 
     public boolean isDisplayOnCreate() {
-        // relying on "should" doesn't seem to work in context of a template 
-        // adding a transient that is updated in the DatasetVersionUI to fix
+        //Localize case - e.g. being called in the context of a specific collection 
+        if (getLocalDisplayOnCreate() != null){
+            return getLocalDisplayOnCreate();
+        }
+        // Non-localized case - the datasetFieldTypes are straight from the database and
+        // never have dsfType.localDsiplayOnCreate set.
         for (DatasetFieldType dsfType : datasetFieldTypes) {
-            boolean shouldDisplayOnCreate = dsfType.shouldDisplayOnCreate();
+            boolean shouldDisplayOnCreate = dsfType.isDisplayOnCreate();
             if (shouldDisplayOnCreate) {
                 return true;
             }
         }
-        if (getLocalDisplayOnCreate() != null){
-            return getLocalDisplayOnCreate();
-        }
         return false;
     }