fix(settings): improve JSON handling in SettingsServiceBean and add tests for arrays #11654

Enhanced `listAllAsJson` to robustly handle JSON parsing with proper fallback for invalid JSON, which means it is some primitive setting.

Added new unit tests to ensure accurate processing of JSON arrays and objects in settings.

Author: poikilotherm

src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java

@@ -13,6 +13,7 @@
 import jakarta.json.Json;
 import jakarta.json.JsonArray;
 import jakarta.json.JsonArrayBuilder;
+import jakarta.json.JsonException;
 import jakarta.json.JsonObject;
 import jakarta.json.JsonObjectBuilder;
 import jakarta.json.JsonString;
@@ -1188,13 +1189,14 @@ public JsonObject listAllAsJson() {
         settings.forEach(setting -> {
             String name = convertToJsonKey(setting);
 
-            // In case the setting is a JSON object, treat it a such in the output (so the API can return valid JSON)
-            if (setting.getContent().trim().startsWith("{"))
-                response.add(name, Json.createObjectBuilder(JsonUtil.getJsonObject(setting.getContent())));
-            else
+            try {
+                // In case the setting is JSON, treat it as such in the output (so the API can return valid JSON)
+                response.add(name, JsonUtil.getJsonValue(setting.getContent()));
+            } catch (JsonException e) {
+                // This wasn't valid JSON, so we just add it as a string
                 response.add(name, setting.getContent());
             }
-        );
+        });
 
         return response.build();
     }

src/test/java/edu/harvard/iq/dataverse/settings/SettingsServiceBeanTest.java

@@ -1,6 +1,7 @@
 package edu.harvard.iq.dataverse.settings;
 
 import jakarta.json.Json;
+import jakarta.json.JsonArray;
 import jakarta.json.JsonObject;
 import jakarta.persistence.EntityManager;
 import jakarta.persistence.TypedQuery;
@@ -197,7 +198,7 @@ void testListAllAsJson_nonLocalizedSettings() {
         }
 
         @Test
-        void testListAllAsJson_jsonSetting() {
+        void testListAllAsJson_jsonObjectSetting() {
             // Given
             JsonObject expected = Json.createObjectBuilder()
                 .add("default", "2147483648")
@@ -218,6 +219,28 @@ void testListAllAsJson_jsonSetting() {
             assertEquals(expected.toString(), result.getJsonObject(SettingsServiceBean.Key.MaxFileUploadSizeInBytes.toString()).toString());
         }
 
+        @Test
+        void testListAllAsJson_jsonArraySetting() {
+            // Given
+            JsonArray expected = Json.createArrayBuilder()
+                .add(2147483648L)
+                .add("4000000000")
+                .add("8000000000")
+                .build();
+            
+            List<Setting> resultList = List.of(
+                new Setting(SettingsServiceBean.Key.MaxFileUploadSizeInBytes.toString(), "[2147483648, \"4000000000\", \"8000000000\"]")
+            );
+            when(typedQuery.getResultList()).thenReturn(resultList);
+            
+            // When
+            JsonObject result = settingsServiceBean.listAllAsJson();
+            
+            // Then
+            assertEquals(1, result.size());
+            assertEquals(expected.toString(), result.getJsonArray(SettingsServiceBean.Key.MaxFileUploadSizeInBytes.toString()).toString());
+        }
+        
         @Test
         void testListAllAsJson_localizedSettings() {
             // Given