Fixing a test - there is no reason for one of the tests to modify a value created in the initial setup method for all the tests to use; since tests are not run in any obvious/intuitive order, this can lead to unexpected results. #9620

Author: landreev

src/test/java/edu/harvard/iq/dataverse/api/AccessIT.java

@@ -499,7 +499,7 @@ public void testRequestAccess() throws InterruptedException {
         basicFileName = "004.txt";
         String basicPathToFile = "scripts/search/data/replace_test/" + basicFileName;
         Response basicAddResponse = UtilIT.uploadFileViaNative(datasetIdNew.toString(), basicPathToFile, apiToken);
-        basicFileId = JsonPath.from(basicAddResponse.body().asString()).getInt("data.files[0].dataFile.id");
+        Integer basicFileIdNew = JsonPath.from(basicAddResponse.body().asString()).getInt("data.files[0].dataFile.id");
 
         String tabFile3NameRestrictedNew = "stata13-auto-withstrls.dta";
         String tab3PathToFile = "scripts/search/data/tabular/" + tabFile3NameRestrictedNew;
@@ -557,7 +557,7 @@ public void testRequestAccess() throws InterruptedException {
         assertEquals(400, requestFileAccessResponse.getStatusCode());
 
         //if you make a request of a public file you should also get a command exception
-        requestFileAccessResponse = UtilIT.requestFileAccess(basicFileId.toString(), apiTokenRando);
+        requestFileAccessResponse = UtilIT.requestFileAccess(basicFileIdNew.toString(), apiTokenRando);
         assertEquals(400, requestFileAccessResponse.getStatusCode());