Merge pull request #10118 from QualitativeDataRepository/IQSS/10117-customquestion_limit_and_failure

IQSS/10117-increase-guestbook-question-length

Author: ofahimIQSS

doc/release-notes/10117-guestbook-question-size-limit-raised.md

@@ -0,0 +1 @@
+Custom questions in Guestbooks can now be more than 255 characters and the bug causing a silent failure when questions were longer than this limit has been fixed.

src/main/java/edu/harvard/iq/dataverse/CustomQuestion.java

@@ -2,7 +2,7 @@
 import java.io.Serializable;
 import java.util.List;
 import jakarta.persistence.*;
-import org.hibernate.validator.constraints.NotBlank;
+import jakarta.validation.constraints.NotBlank;
 
 /**
  *
@@ -41,7 +41,7 @@ public void setId(Long id) {
     private String questionType;
 
     @NotBlank(message = "{custom.questiontext}")
-    @Column( nullable = false )
+    @Column( nullable = false, columnDefinition = "TEXT")
     private String questionString;
     private boolean required;
 

src/main/java/edu/harvard/iq/dataverse/GuestbookPage.java

@@ -322,7 +322,7 @@ public String save() {
             logger.info("Guestbook Page Command Exception. Dataverse: " + dataverse.getName());
             logger.info(ex.toString());
             FacesContext.getCurrentInstance().addMessage(null, new FacesMessage(FacesMessage.SEVERITY_FATAL, BundleUtil.getStringFromBundle("guestbook.save.fail"), " - " + ex.toString()));
-            //logger.severe(ex.getMessage());
+            return null;
         }
         editMode = null;
         String msg = (create)? BundleUtil.getStringFromBundle("guestbook.create"): BundleUtil.getStringFromBundle("guestbook.save");

src/main/resources/db/migration/V6.4.0.2.sql

@@ -0,0 +1,2 @@
+-- #10118
+ALTER TABLE customquestion ALTER COLUMN questionstring TYPE text;

src/main/webapp/resources/iqbs/messages.xhtml

@@ -63,7 +63,7 @@
                         <f:convertDateTime pattern="yyyy-MM-dd HH:mm:ss" type="date" />
                     </h:outputText>
                     <strong>Server: </strong>
-                    #{systemConfig.dataverseServer}
+                    #{systemConfig.dataverseSiteUrl}
                 </ui:fragment>
             </div>
             #{msg.rendered()}