Skip to content

Commit bd45e31

Browse files
committed
style(ct): simplify password change scripts by removing unnecessary newlines in error handling blocks
1 parent 25bec63 commit bd45e31

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

modules/container-base/src/main/docker/scripts/init_1_change_passwords.sh

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@ set -euo pipefail
88
# Someone set the env var for passwords - get the new password in. Otherwise print warning.
99
# https://docs.openshift.com/container-platform/4.14/openshift_images/create-images.html#avoid-default-passwords
1010
if [ "$LINUX_PASSWORD" != "payara" ]; then
11-
echo -e "$LINUX_USER\n$LINUX_PASSWORD\n$LINUX_PASSWORD" | passwd || {
12-
echo "Linux password unchanged!"
13-
}
11+
echo -e "$LINUX_USER\n$LINUX_PASSWORD\n$LINUX_PASSWORD" | passwd || { echo "Linux password unchanged!"; }
1412
else
1513
echo "IMPORTANT: THIS CONTAINER USES THE DEFAULT PASSWORD FOR USER \"${LINUX_USER}\"! ('payara')"
1614
echo " To change the password, set the LINUX_PASSWORD env var."
@@ -21,9 +19,7 @@ if [ "$PAYARA_ADMIN_PASSWORD" != "admin" ]; then
2119
PASSWORD_FILE=$(mktemp)
2220
echo "AS_ADMIN_PASSWORD=admin" > "$PASSWORD_FILE"
2321
echo "AS_ADMIN_NEWPASSWORD=${PAYARA_ADMIN_PASSWORD}" >> "$PASSWORD_FILE"
24-
asadmin --user="${PAYARA_ADMIN_USER}" --passwordfile="$PASSWORD_FILE" change-admin-password --domain_name="${DOMAIN_NAME}" || {
25-
echo "Payara password unchanged!"
26-
}
22+
asadmin --user="${PAYARA_ADMIN_USER}" --passwordfile="$PASSWORD_FILE" change-admin-password --domain_name="${DOMAIN_NAME}" || { echo "Payara password unchanged!"; }
2723
rm "$PASSWORD_FILE"
2824
else
2925
echo "IMPORTANT: THIS CONTAINER USES THE DEFAULT PASSWORD FOR PAYARA ADMIN \"${PAYARA_ADMIN_USER}\"! ('admin')"
@@ -39,9 +35,7 @@ if [ "$DOMAIN_PASSWORD" != "changeit" ]; then
3935
PASSWORD_FILE=$(mktemp)
4036
echo "AS_ADMIN_MASTERPASSWORD=changeit" >> "$PASSWORD_FILE"
4137
echo "AS_ADMIN_NEWMASTERPASSWORD=${DOMAIN_PASSWORD}" >> "$PASSWORD_FILE"
42-
asadmin --user="${PAYARA_ADMIN_USER}" --passwordfile="$PASSWORD_FILE" change-master-password --savemasterpassword false "${DOMAIN_NAME}" || {
43-
echo "Domain password unchanged!"
44-
}
38+
asadmin --user="${PAYARA_ADMIN_USER}" --passwordfile="$PASSWORD_FILE" change-master-password --savemasterpassword false "${DOMAIN_NAME}" || { echo "Domain password unchanged!"; }
4539
rm "$PASSWORD_FILE"
4640
else
4741
echo "IMPORTANT: THIS CONTAINER USES THE DEFAULT DOMAIN \"MASTER\" PASSWORD! ('changeit')"

0 commit comments

Comments
 (0)