Skip to content

Commit cd48216

Browse files
authored
Merge pull request #11390 from IQSS/11376-add-version-note-to-diff-summary
11376 add version note to diff summary
2 parents 7aa6235 + ec14707 commit cd48216

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

src/main/java/edu/harvard/iq/dataverse/DatasetVersionDifference.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1782,11 +1782,13 @@ public JsonObjectBuilder compareVersionsAsJson() {
17821782
JsonObjectBuilder jobVersion = new NullSafeJsonBuilder();
17831783
jobVersion.add("versionNumber", originalVersion.getFriendlyVersionNumber());
17841784
jobVersion.add("versionState", originalVersion.getVersionState().name());
1785+
jobVersion.add("versionNote", originalVersion.getVersionNote());
17851786
jobVersion.add("lastUpdatedDate", new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'").format(originalVersion.getLastUpdateTime()));
17861787
job.add("oldVersion", jobVersion);
17871788
jobVersion = new NullSafeJsonBuilder();
17881789
jobVersion.add("versionNumber", newVersion.getFriendlyVersionNumber());
17891790
jobVersion.add("versionState", newVersion.getVersionState().name());
1791+
jobVersion.add("versionNote", newVersion.getVersionNote());
17901792
jobVersion.add("lastUpdatedDate", new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'").format(newVersion.getLastUpdateTime()));
17911793
job.add("newVersion", jobVersion);
17921794

src/main/java/edu/harvard/iq/dataverse/api/Datasets.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3009,7 +3009,7 @@ public Response getCompareVersionsSummary(@Context ContainerRequestContext crc,
30093009
} else {
30103010
versionBuilder.add("summary", dvdiff.getSummaryDifferenceAsJson());
30113011
}
3012-
3012+
versionBuilder.add("versionNote", dv.getVersionNote());
30133013
versionBuilder.add("contributors", datasetversionService.getContributorsNames(dv));
30143014
versionBuilder.add("publishedOn", !dv.isDraft() ? dv.getPublicationDateAsString() : "");
30153015
differenceSummaries.add(versionBuilder);

src/main/java/propertyFiles/Bundle.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2169,6 +2169,7 @@ file.viewDiffDialog.dialog.warning=Please select two versions to view the differ
21692169
file.viewDiffDialog.notAvailable=N/A
21702170
file.viewDiffDialog.version=Version
21712171
file.viewDiffDialog.lastUpdated=Last Updated
2172+
file.viewDiffDialog.versionNote=Version Note
21722173
file.viewDiffDialog.fileID=File ID
21732174
file.viewDiffDialog.fileName=Name
21742175
file.viewDiffDialog.fileType=Type

src/main/webapp/dataset.xhtml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1440,11 +1440,13 @@
14401440
</div>
14411441
<div class="pull-left">
14421442
#{bundle['file.viewDiffDialog.version']}: #{DatasetPage.datasetVersionDifference.originalVersion.semanticVersion}<br/>
1443-
#{bundle['file.viewDiffDialog.lastUpdated']}: #{DatasetPage.datasetVersionDifference.originalVersion.localeLastUpdateTime}
1443+
#{bundle['file.viewDiffDialog.lastUpdated']}: #{DatasetPage.datasetVersionDifference.originalVersion.localeLastUpdateTime}<br/>
1444+
<p:fragment rendered="#{versionNoteEnabled}">#{bundle['file.viewDiffDialog.versionNote']}: #{DatasetPage.datasetVersionDifference.originalVersion.versionNote}</p:fragment>
14441445
</div>
14451446
<div class="pull-left">
14461447
#{bundle['file.viewDiffDialog.version']}: #{DatasetPage.datasetVersionDifference.newVersion.semanticVersion}<br/>
1447-
#{bundle['file.viewDiffDialog.lastUpdated']}: #{DatasetPage.datasetVersionDifference.newVersion.localeLastUpdateTime}
1448+
#{bundle['file.viewDiffDialog.lastUpdated']}: #{DatasetPage.datasetVersionDifference.newVersion.localeLastUpdateTime}<br/>
1449+
<p:fragment rendered="#{versionNoteEnabled}">#{bundle['file.viewDiffDialog.versionNote']}: #{DatasetPage.datasetVersionDifference.newVersion.versionNote}</p:fragment>
14481450
</div>
14491451
</div>
14501452
<ui:fragment rendered="#{!empty(DatasetPage.datasetVersionDifference.detailDataByBlock)}">

0 commit comments

Comments
 (0)