completed copy-paste; reverted needless changes

Author: jo-pol

src/main/java/edu/harvard/iq/dataverse/DatasetPage.java

@@ -38,7 +38,6 @@
 import edu.harvard.iq.dataverse.engine.command.impl.PublishDataverseCommand;
 import edu.harvard.iq.dataverse.engine.command.impl.UpdateDatasetVersionCommand;
 import edu.harvard.iq.dataverse.export.ExportService;
-import edu.harvard.iq.dataverse.util.MarkupChecker;
 import edu.harvard.iq.dataverse.util.cache.CacheFactoryBean;
 import io.gdcc.spi.export.ExportException;
 import io.gdcc.spi.export.Exporter;
@@ -1652,12 +1651,11 @@ public void setDisplayCitation(String displayCitation) {
     }
 
     public String getDisplayTitle() {
-        //displayCitation = dataset.getCitation(false, workingVersion);
         return displayTitle;
     }
 
-    public void setDisplayTitle(String displayCitation) {
-        this.displayCitation = displayTitle;
+    public void setDisplayTitle(String displayTitle) {
+        this.displayTitle = displayTitle;
     }
 
     public String getDropBoxSelection() {

src/main/java/edu/harvard/iq/dataverse/dataaccess/FileAccessIO.java

@@ -608,7 +608,7 @@ private List<Path> listCachedFiles() throws IOException {
             datasetDirectoryPath = Paths.get(getDatasetDirectory());
         }
 
-        if (datasetDirectoryPath == null) {
+          if (datasetDirectoryPath == null) {
             throw new IOException("Could not determine the filesystem directory of the parent dataset.");
         }
 

src/main/java/edu/harvard/iq/dataverse/search/IndexServiceBean.java

@@ -86,7 +86,6 @@
 import jakarta.ejb.Stateless;
 import jakarta.ejb.TransactionAttribute;
 
-import static edu.harvard.iq.dataverse.DatasetField.NA_VALUE;
 import static jakarta.ejb.TransactionAttributeType.REQUIRES_NEW;
 
 import jakarta.inject.Inject;
@@ -267,7 +266,7 @@ public Future<String> indexDataverse(Dataverse dataverse, boolean processPaths)
         Set<String> langs = settingsService.getConfiguredLanguages();
         for (ControlledVocabularyValue dataverseSubject : dataverse.getDataverseSubjects()) {
             String subject = dataverseSubject.getStrValue();
-            if (!subject.equals(NA_VALUE)) {
+            if (!subject.equals(DatasetField.NA_VALUE)) {
              // Index in all used languages (display and metadata languages
                 for(String locale: langs) {
                     solrInputDocument.addField(SearchFields.DATAVERSE_SUBJECT, dataverseSubject.getLocaleStrValue(locale));
@@ -1062,7 +1061,6 @@ public SolrInputDocuments toSolrDocs(IndexableDataset indexableDataset, Set<Long
             if (datasetVersion.isInReview()) {
                 solrInputDocument.addField(SearchFields.PUBLICATION_STATUS, IN_REVIEW_STRING);
             }
-
             CurationStatus status = datasetVersion.getCurrentCurationStatus();
             if(status != null && Strings.isNotBlank(status.getLabel())) {
                 solrInputDocument.addField(SearchFields.CURATION_STATUS, status.getLabel());
@@ -1260,7 +1258,7 @@ public SolrInputDocuments toSolrDocs(IndexableDataset indexableDataset, Set<Long
                              */
                             if (dsf.getControlledVocabularyValues().isEmpty()) {
                                 for (DatasetFieldValue dfv : dsf.getDatasetFieldValues()) {
-                                    if (dfv.getValue() == null || dfv.getValue().equals(NA_VALUE)) {
+                                    if (dfv.getValue() == null || dfv.getValue().equals(DatasetField.NA_VALUE)) {
                                         continue;
                                     }
                                     solrInputDocument.addField(solrFieldSearchable, dfv.getValue());
@@ -1271,7 +1269,7 @@ public SolrInputDocuments toSolrDocs(IndexableDataset indexableDataset, Set<Long
                                 }
                             } else {
                                 for (ControlledVocabularyValue controlledVocabularyValue : dsf.getControlledVocabularyValues()) {
-                                    if (controlledVocabularyValue.getStrValue().equals(NA_VALUE)) {
+                                    if (controlledVocabularyValue.getStrValue().equals(DatasetField.NA_VALUE)) {
                                         continue;
                                     }
 
@@ -1308,7 +1306,7 @@ public SolrInputDocuments toSolrDocs(IndexableDataset indexableDataset, Set<Long
                                     }
                                 } else {
                                     var values = dsf.getDisplayValues(); // for proper display of facets with &apos;
-                                    values.removeAll(Arrays.asList(NA_VALUE));
+                                    values.removeAll(Arrays.asList(DatasetField.NA_VALUE));
                                     solrInputDocument.addField(solrFieldFacetable, values);
                                 }
                             }